[pkg-fetchmail-maint] Bug in postinst
Héctor García
hector at debian.org
Tue Nov 15 11:53:32 UTC 2005
El mar, 15-11-2005 a las 09:36 +0100, Loïc Minier escribió:
> Let's STOP loosing time with issues as stupid as these. Let's be
> constructive and efficient: please have a look at the latest version in
> SVN, and explain what remaining issue there are. I see:
> 1/ the permission always overriden in postinst on this dir, but /var is
> not /etc, and I find it acceptable; I would call it safer
I don't like the permision been always overriden. If the dir existed and
the admin changed something, we should not change it back.
> 2/ the fact that the home creation was kept under adduser, which is of
> no importance when the chmod is run unconditionally afterwards
>
At the moment, the only strange thing I see on svn (taken apart my
dislikes, which are only personal opinions not tecnical ones), are this
lines
if [ -d /var/run/fetchmail ]; then
mkdir -p /var/run/fetchmail
fi
which makes no sense at all, "If the dir exits, create it again".
It should be at least
if ! [ -d /var/run/fetchmail ]; then
mkdir -p /var/run/fetchmail
fi
> Let us know if you see more problems in the SVN version, and why these
> are actual problems (please distinguish regressions if possible).
>
The only thing is that I don't see why /var/run/fetchmail must be 700.
I found it fine for new installs, but changing local admin permisions
(on install and on every run of init) looks too much for me.
Ragards,
Héctor
More information about the pkg-fetchmail-maint
mailing list