[pkg-fgfs-crew] Security fix for FlightGear

[Markus Wanner]

Hi,

On 05/17/2017 08:57 AM, Salvatore Bonaccorso wrote:
>>> For stable: We think this does need a DSA on its own, can you schedule
>>                                 ^ not

okay, so I'll upload to 'stable'.

@Florent: with the given patch for 3.0.0, flightgear doesn't currently
compile (nor does 2016.4.4 with its patch). Did you actually try to
compile the stable release branches, or did you just cherry pick the
patch? Or did I somehow mess up the patches?

Preparation for the stable upload can be found here:
https://anonscm.debian.org/git/collab-maint/flightgear.git/log/?h=jessie

The build for 3.0.0 errs out with:

> /home/markus/flightgear.git/src/Autopilot/route_mgr.cxx: In function 'bool commandSaveFlightPlan(const SGPropertyNode*)':
> /home/markus/flightgear.git/src/Autopilot/route_mgr.cxx:79:69: error: no matching function for call to 'fgValidatePath(SGPath&, bool)'
>                                                      true /* write */);
>                                                                      ^
> /home/markus/flightgear.git/src/Autopilot/route_mgr.cxx:79:69: note: candidates are:
> In file included from /home/markus/flightgear.git/src/Autopilot/route_mgr.cxx:59:0:
> /home/markus/flightgear.git/src/Main/util.hxx:44:13: note: const char* fgValidatePath(const char*, bool)
>  const char *fgValidatePath (const char *path, bool write);
>              ^
> /home/markus/flightgear.git/src/Main/util.hxx:44:13: note:   no known conversion for argument 1 from 'SGPath' to 'const char*'
> /home/markus/flightgear.git/src/Main/util.hxx:45:13: note: std::string fgValidatePath(const string&, bool)
>  std::string fgValidatePath(const std::string& path, bool write);
>              ^
> /home/markus/flightgear.git/src/Main/util.hxx:45:13: note:   no known conversion for argument 1 from 'SGPath' to 'const string& {aka const std::basic_string<char>&}'
> src/Main/CMakeFiles/fgfs.dir/build.make:1483: recipe for target 'src/Main/CMakeFiles/fgfs.dir/__/Autopilot/route_mgr.cxx.o' failed


The build for 2016.4.4 errs out with:

> /home/markus/pkg-flightgear/flightgear.git/src/Autopilot/route_mgr.cxx: In function ‘bool commandSaveFlightPlan(const SGPropertyNode*)’:
> /home/markus/pkg-flightgear/flightgear.git/src/Autopilot/route_mgr.cxx:77:52: error: conversion from ‘SGPath’ to non-scalar type ‘const string {aka const std::__cxx11::basic_string<char>}’ requested
>    const std::string authorizedPath = fgValidatePath(path,
>                                       ~~~~~~~~~~~~~~^~~~~~
>                                                      true /* write */);
>                                                      ~~~~~~~~~~~~~~~~~
> src/Main/CMakeFiles/fgfs.dir/build.make:1577: recipe for target 'src/Main/CMakeFiles/fgfs.dir/__/Autopilot/route_mgr.cxx.o' failed


I cannot currently investigate further, but have to defer that until
this evening, at the very least.

Kind Regards

Markus Wanner


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fgfs-crew/attachments/20170517/f94d1682/attachment.sig>