[Pkg-firebird-general] lintian reports for firebird2 packages

[Grzegorz B. Prokopski]

W li¶cie z wto, 29-06-2004, godz. 07:26, Daniel Urban pisze: 
> Hi
>  
> Report is below.
> I've got rid of fbslup.sh but now I've got error in
> firebird2-server-common
> (E: firebird2-server-common: lengthy-symlink usr/lib/firebird2/lib
> ../../lib)

"This link goes up, and then back down into the same subdirectory.
 Making it shorter will improve its chances of finding the right file if
 the user's system has lots of symlinked directories.

 Refer to Policy Manual, section 11.5 for details."

So it should be easy to fix by just making it "..".

> What errors from listed are critical and doesn't let us to put this 
> in sarge? (Grzegorz?)

To get past ftpmasters you want the package to:
a) have ideal content of ./debian directory (so that nobody could
complain by just lookint at it)
b) be lintian and/or linda -clean (if there's some nasty E: or W: that
you know is bogus, you can override it by putting a file into
/usr/share/lintian/overrides/ to shut it up).

> For a moment I upload new sources and new debs (compiled on sid)
> on server http://debian.sente.pl/fb2

Great!

> Grzegorz, what else I have to do before you could make the initian
> upload?

See above and below.

>  
> lintian -i firebird2-server-common_1.5.0-1_i386.deb
> -------------
> E: firebird2-server-common: lengthy-symlink usr/lib/firebird2/lib
> ../../lib

Should be fixed.


> W: firebird2-server-common: binary-or-shlib-defines-rpath
> ./usr/lib/firebird2/UDF/ib_udf.so /usr/lib/firebird2/lib
> W: firebird2-server-common: binary-or-shlib-defines-rpath
> ./usr/lib/firebird2/intl/fbintl /usr/lib/firebird2/lib

Do we really need these libs to contain rpaths? See
 
	http://wiki.debian.net/index.cgi?RpathIssue

for reference.  It *might* be, that fb2 needs rpaths to operate properly
(i.e. if the libs it links to are not in /lib or /usr/lib directory).
In such case it should be documented in README.Debian and put into
/usr/share/lintian/overrides/firebird2-server-common


> W: firebird2-server-common: missing-depends-line

You need to find out this one.  Will this package be usable w/ any
shared-lib dependencies?  If yes, then just shut linitan up like above.


> E: firebird2-super-server: binary-without-manpage fbmgr

You could at least write a simple 5-liner manpage pointing to some
documentation on the web.  A single sentence w/ an URL at the end
would be sufficient.  You can symlink such a page to other binaries

> ==================================================
> lintian -i firebird2-classic-server_1.5.0-1_i386.deb
> -------------
> W: firebird2-classic-server: killall-is-dangerous prerm:37
> N:
> N:   The maintainer script seems to call killall. Since this utility
> kills
> N:   processes by name, it may well end up killing unrelated
> processes.
> N:   Most uses of killall should use start-stop-daemon instead.

The lintian is right.  killall is ugly.  Would you be able to check
whether s-s-d wouldn't do the same work better?  I think that if
you don't give it a PID file, but only an executable - it will
kill all intances of this executable (NOT all processes of the same
name - as killall does).


> W: libfirebird2-classic: non-dev-pkg-with-shlib-symlink
> usr/lib/libfbclient.so.1.5.0 usr/lib/libfbclient.so

yes, the .so file should be moved to -dev package


> W: libfirebird2-classic: non-dev-pkg-with-shlib-symlink
> usr/lib/libfbembed.so.1.5.0 usr/lib/libfbembed.so

> W: libfirebird2-classic: binary-or-shlib-defines-rpath
> ./usr/lib/libfbclient.so.1.5.0 /usr/lib/firebird2/lib

> W: libfirebird2-classic: binary-or-shlib-defines-rpath
> ./usr/lib/libfbembed.so.1.5.0 /usr/lib/firebird2/lib

> W: libfirebird2-super: non-dev-pkg-with-shlib-symlink
> usr/lib/libfbclient.so.1.5.0 usr/lib/libfbclient.so

> W: libfirebird2-super: binary-or-shlib-defines-rpath
> ./usr/lib/libfbclient.so.1.5.0 /usr/lib/firebird2/lib

> E: firebird2-utils: binary-without-manpage gdef

> E: firebird2-utils: binary-without-manpage gfix
> E: firebird2-utils: binary-without-manpage gpre
> E: firebird2-utils: binary-without-manpage gsec
> E: firebird2-utils: binary-without-manpage gstat
> E: firebird2-utils: binary-without-manpage qli

Same as above.

Let me know if you have further questions. HTH,

			Grzegorz B. Prokopski

-- 
Grzegorz B. Prokopski      <gadek@debian.org>
Debian GNU/Linux           http://www.debian.org
SableVM - LGPL'ed Java VM  http://www.sablevm.org
Why SableVM ?!?            http://devel.sablevm.org/wiki/Features