[pkg-fso-maint] automake patches

Joachim Breitner nomeata at debian.org
Sat Dec 27 22:28:43 UTC 2008


Hi,

while working on packaging SHR for Debian, I found some issues with your
automake files: Their dist target did not put all required files in the
generated tarball. Here are some patches to amend that, please apply
them:

ophonekitd:

diff --git a/Makefile.am b/Makefile.am
index 31176bc..d0fc02e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,3 +4,4 @@ MAINTAINERCLEANFILES = \
        config.h.in config.sub configure install-sh \
        ltconfig ltmain.sh missing mkinstalldirs \
        stamp-h.in acconfig.h stamp-h depcomp
+EXTRA_DIST = data
diff --git a/src/Makefile.am b/src/Makefile.am
index d28775a..1cb24c7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -3,6 +3,8 @@ MAINTAINERCLEANFILES = Makefile.in
 ophonekitd-usage-service-glue.h: ${top_builddir}/src/dbus/ophonekitd-usage.xml
        $(DBUSBINDINGTOOL) --mode=glib-server --output=$@ --prefix=ophonekitd_usage_service $^
 
+EXTRA_DIST = dbus/ophonekitd-usage.xml
+
 bin_PROGRAMS = ophonekitd
 dbus_sources = ophonekitd-usage-service-glue.h
 
@@ -19,7 +21,8 @@ ophonekitd_SOURCES = $(dbus_sources) \
        ophonekitd-dbus-usage.c \
        ophonekitd-dbus-usage.h \
        ophonekitd-dbus.c \
-       ophonekitd-dbus.h 
+       ophonekitd-dbus.h \
+       ophonekitd-dbus-common.h
 
 ophonekitd_CFLAGS = \
        -DDATADIR=\"$(datadir)\" \


libframeword-phonegui-efl:

diff --git a/src/Makefile.am b/src/Makefile.am
index 2dd08be..71c5dc4 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -28,6 +28,7 @@ libframeworkd_phonegui_efl_la_SOURCES = \
        util/window.h util/window.c \
        util/view.h util/view.c \
        view/dialog-view.c \
+       view/dialer-view.c \
        view/contact-edit-view.c \
        view/contact-delete-view.c \
        view/contact-list-view.c \
@@ -40,5 +41,6 @@ libframeworkd_phonegui_efl_la_SOURCES = \
        view/call-incoming-view.c \
        view/call-active-view.c \
        view/sim-auth-input-view.c \
-       view/ussd-view.c
+       view/ussd-view.c \
+       view/views.h
 

Additionally, you have some files in the OE repository, e.g.
http://shr.bearstech.com/git/?p=shr-overlay.git;a=blob;f=openembedded/packages/ophonekitd/ophonekitd/80ophonekitd;h=89043622ad32d71bc81fba898af033bf9a2c031f;hb=master
which should probaby be shipped in the data/ directory of the source.


thanks
Joachim
-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20081227/b0606867/attachment.pgp 


More information about the pkg-fso-maint mailing list