[pkg-fso-maint] [Fwd: patch to install.sh (Debian at FreeRunner)]

[Luca Capello]

Hi there!

On Mon, 02 Feb 2009 11:28:41 +0100, Joachim Breitner wrote:
> I think Steffen’s changes are fine, anyone disagree? And does someone
> want to comment on his remarts about kernel installation?
>
> Maybe we should remove vfat-support altogether and just have people
> install Qi or adjust their uboot environment?

I will comment after having (re)read the whole thread, which does not
mean I will do it today.

> -------- Weitergeleitete Nachricht --------
> Von: Steffen Moeller <steffen_moeller at gmx.de>
[...]
> I just ran through install.sh and did the following changes.

If you provide Git patches (with e.g. `git format-patch origin/master`),
one per each change, it would be less work for us and your name would
directly appear on `git log` output :-)

> Apparently dosfstools got updated in the meantime.

Applied [1], thank you!

> The description of what the apt target is doing I found too difficult
> (I understood you'd prepare some kind of proxy or so) - maybe you can
> come up with something even better.

It is difficult to find a better wording, because IMHO the actual one is
correct: it not only populates /etc/apt/sources.lists, but also sets
other APT-related stuff (APT::Install-Recommends [2] and pkg-fso-keyring
for SecureAPT [3]).

We can reflect what is printed when starting/ending this stage,
i.e. changing the description to "Configure APT", is it better?

> The final bit seems to be syntactically problematic.
[...]
> @@ -800,7 +799,7 @@
>  # Stage unmount
>  #
>  echo "Unmounting microSD card partitions"
> -if ! [ "$SINGLE_PART" = "true" ]; then
> +if [ "$SINGLE_PART" != "true" ]; then
>         umount $INST_DIR/boot
>  fi
>  umount $INST_DIR

I, as well, prefer your syntax over the existing one and it is also
present at line 605: both corrected [4].  The rationale is that having a
positive test is always preferable that testing for a non-positive one.

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://git.debian.org/?p=pkg-fso/files.git;a=commitdiff;h=934771b09bb7d738622a6386adc40277a9ec2526
[2] http://lists.debian.org/debian-devel-announce/2007/08/msg00000.html
[3] http://wiki.debian.org/SecureApt
[4] http://git.debian.org/?p=pkg-fso/files.git;a=commitdiff;h=98578198b91c2a0f471c96f1414c8a0b3eaeb294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090204/8edcca7b/attachment-0001.pgp