[pkg-fso-maint] install.sh: various minor corrections (was Re: some issues in install.sh)

[Luca Capello]

Hi Brian!

On Sun, 14 Jun 2009 22:09:36 +0200, Brian DeRocher wrote:
> Likewise, line 695 can be re-factored, no bug there though.

Please better explain, maybe with a diff, what you are referring to: I
do not see how the code below can be refactored...

--8<---------------cut here---------------start------------->8---
	echo " * Waiting for partitions to appear"
	intern_sleep_seconds=3
	if [ "$SINGLE_PART" = "true" ]; then
		intern_devtest="test -e ${SD_DEVICE}p1"
	else
		intern_devtest="test -e ${SD_DEVICE}p1 -a -e ${SD_DEVICE}p2"
	fi

	while ! $intern_devtest; do
		if [ "$intern_sleep_seconds" = 15 ]; then
			echo "E: Partitioning has failed, partitions have not been created"
			exit 1
		fi
		sleep 3
		intern_sleep_seconds=$(( $intern_sleep_seconds + 3 ))
	done
	echo " * Partition table created"
--8<---------------cut here---------------end--------------->8---

> rootpartno is declared, but it's never used.  line 604
>
> EXTRA_TASKS is declared, but never used.

Both can be removed IMHO, maybe they were used during some tests and
then forgot there, Steffen?

> MOUNT_PROC could use some explanation.  Which packages need it.  Is there any 
> harm in just mounting proc?

Please read the discussion at

  http://lists.alioth.debian.org/pipermail/pkg-fso-maint/2009-March/000881.html

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090615/9b4272ab/attachment.pgp>