[pkg-fso-maint] install.sh: various minor corrections (was Re: some issues in install.sh)

Steffen Moeller steffen_moeller at gmx.de
Mon Jun 15 16:24:02 UTC 2009


Hello,

Luca Capello wrote:

> On Sun, 14 Jun 2009 22:09:36 +0200, Brian DeRocher wrote:
>> 
>> rootpartno is declared, but it's never used.  line 604
>>
>> EXTRA_TASKS is declared, but never used.
> 
> Both can be removed IMHO, maybe they were used during some tests and
> then forgot there, Steffen?

Please remove it when you are at it. I have no idea what these were about.

Much like you, I also have implemented the apparently trivial first patch and refrained
from an immediate upload being afraid to have broken something, for which however I did
not yet have the time.

Brian, the whole install.sh script is somewhat driven by an "attempt not to change what
appears to work" kind of attitude and another attitude that says "any larger rewrite of
anything should be for the Debian installer". Time is floating, though.

Many greetings

Steffen



More information about the pkg-fso-maint mailing list