[pkg-fso-maint] investigating FTBFS of libfsotransport on sparc

[Jens Seidel]

Hi Heiko,

On Fri, Jun 11, 2010 at 10:18:45AM +0200, Heiko Stuebner wrote:
> Am Donnerstag 10 Juni 2010 schrieb Sebastian Reichel:
> > He would add --disable-fast-baud to the configure script to solve the
> > SPARC problem.
> I have prepared and attached a patch adding this option to libfsotransport

> Subject: [PATCH] libfsotransport: add option to conditionally disable fast baud rates

You can drop "add option to" :-)
 
> diff --git a/libfsotransport/configure.ac b/libfsotransport/configure.ac
> +# check for disabling of fast baud rates
> +AC_ARG_ENABLE(fast-baud,
> +  [  --disable-fast-baud            Disable fast baud rates (default=enabled)],

I suggest you use

AS_HELP_STRING([--disable-fast-baud], [Disable fast baud rates (default=enabled)]

for the second line as this avoid that you care about the indentaion (number
of spaces). I would also omit "(default=enabled)" as AC_ARG_ENABLE flags
always change the default behaviour.

> +  fastbaud="no", fastbaud="yes")

This is wrong! The first argument should be [fastbaud="$enableval"] as this
is also called if --enable-fast-baud is used (and in this case you don't
want "no", right?).

I also suggest to replace the [action-if-not-given] (fastbaud="yes") by an
compiler test. Something as
AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
  include "...termios.h"
  int tspeed = Linux.Termios.B2500000 + Linux.Termios.B4000000;
]])],fastbaud="yes",fastbaud="no")

Please check other code as well for this error (and verify that I'm right).
See e.g. http://www.gnu.org/software/autoconf/manual/autoconf.html

>  echo "  debug build.............: $debug"
>  echo
> +echo "  fast baud rates ........: $fastbaud"

A "." after "rates" is missing for consistency :-))

Jens