[pkg-fso-maint] investigating FTBFS of libfsotransport on sparc

[Heiko Stübner]

Hi Jens,

thanks for the input.

I have attached the cleaned patch against the latest cornucopia git.


Am Freitag 11 Juni 2010, 10:49:34 schrieb Jens Seidel:
> Hi Heiko,
> 
> On Fri, Jun 11, 2010 at 10:18:45AM +0200, Heiko Stuebner wrote:
> > Am Donnerstag 10 Juni 2010 schrieb Sebastian Reichel:
> You can drop "add option to" :-)
done


> > diff --git a/libfsotransport/configure.ac b/libfsotransport/configure.ac
> > +# check for disabling of fast baud rates
> > +AC_ARG_ENABLE(fast-baud,
> > +  [  --disable-fast-baud            Disable fast baud rates
> > (default=enabled)],
> 
> I suggest you use
> 
> AS_HELP_STRING([--disable-fast-baud], [Disable fast baud rates
> (default=enabled)]
> for the second line as this avoid that you care about the indentaion
> (number of spaces). I would also omit "(default=enabled)" as AC_ARG_ENABLE
> flags always change the default behaviour.
done, but final formating decisions will be Mickeys call.


> > +  fastbaud="no", fastbaud="yes")
> 
> This is wrong! The first argument should be [fastbaud="$enableval"] as this
> is also called if --enable-fast-baud is used (and in this case you don't
> want "no", right?).
> I also suggest to replace the [action-if-not-given] (fastbaud="yes") by an
> compiler test.
this is my first time of really messing with autoconf stuff - so this hint (and 
the example code) was extremly helpful :-)

Fortunatly this also takes care of the arch-specific enabling or disabling of 
the fast baud rates.

> >  echo "  debug build.............: $debug"
> >  echo
> > 
> > +echo "  fast baud rates ........: $fastbaud"
> 
> A "." after "rates" is missing for consistency :-))
done :-)


so, thanks again
Heiko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libfsotransport-conditionally-disable-fast-baud-rate.patch
Type: text/x-patch
Size: 2851 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20100612/c9c8f514/attachment.bin>