[pkg-fso-maint] Need a quick review of vala-terminal changes in git

[Sebastian Reichel]

On Wed, Dec 14, 2011 at 11:27:20PM +0100, Philipp Kaluza wrote:
> Wow, that was fast. Thank you.

I was just working on updating other FSO stuff when I got your
mail.

> Am 14.12.2011 23:12, schrieb Sebastian Reichel:
> > You forgot to patch away the generated files from the release.
> Otherwise you have local changes.
> 
> Could you elaborate on that ? During the BSP I talked with jluebbe about
> this very problem, and we concluded that adding the generated files (and
> the .stamp file) to debian/clean would be enough, since dh_clean is
> called before diffing and generating the .debian.tar.gz file. Then I
> deleted them from git to make gbp happy. But I thought I had even tested
> twice-in-a-row builds, but apparently I missed something ?

Adding them debian/clean was important, too. This will remove the
files after building. The problem is, that these files existed
initially in the tarball. So you have a diff. There are two
solutions:

 * Adding a debian patch, which removes the files, which
   will automatically readd the original files after the
   build.
 * Removing the files from the orig.tar.bz2

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20111215/594dd6a6/attachment-0001.pgp>