[pkg-fso-maint] Need a quick review of vala-terminal changes in git

[Joachim Breitner]

Hi,

thanks @Philipp and @Sebastian for taking care of this.

Am Donnerstag, den 15.12.2011, 00:32 +0100 schrieb Sebastian Reichel:
> On Wed, Dec 14, 2011 at 11:27:20PM +0100, Philipp Kaluza wrote:
> > Am 14.12.2011 23:12, schrieb Sebastian Reichel:
> > > You forgot to patch away the generated files from the release.
> > > Otherwise you have local changes.
> > 
> > Could you elaborate on that ? During the BSP I talked with jluebbe about
> > this very problem, and we concluded that adding the generated files (and
> > the .stamp file) to debian/clean would be enough, since dh_clean is
> > called before diffing and generating the .debian.tar.gz file. Then I
> > deleted them from git to make gbp happy. But I thought I had even tested
> > twice-in-a-row builds, but apparently I missed something ?
> 
> Adding them debian/clean was important, too. This will remove the
> files after building. The problem is, that these files existed
> initially in the tarball. So you have a diff. There are two
> solutions:
> 
>  * Adding a debian patch, which removes the files, which
>    will automatically readd the original files after the
>    build.
>  * Removing the files from the orig.tar.bz2

hmm, I’m surprised if that is really true. dpkg ignores delete files
when generating the diff, i.e. they do not constitue local changes.
Also, dpkg-buildpackage runs debian/rules clean before calling
dpkg-source to generate the source package. So from my experience, and
without checking the specifics of this package, I agree with Philipp
that adding the files to debian/clean should be enough; and if I am
wrong or something weird happend in this case, I am curious about what
it might be.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20111215/186a7813/attachment.pgp>