[pkg-fso-maint] Bug#693577: libfso-glib: not properly built from source (actual source is in fso-specs)

Paul Wise pabs at debian.org
Sun Nov 18 02:40:22 UTC 2012 

Source: libfso-glib
Severity: serious
Usertags: built-using sentpatch
Tags: patch

Not sure if this bug should be RC or not, please downgrade it if not.
Either way, I suppose it should be wheezy-ignore since fixing it will
probably require a transition.

The source code that is in this package is all generated (see below) and
as far as I can tell, despite build-depending on the required source
(fso-specs) and the tools (vala-dbus-binding-tool) required to build
that source, the build process does not generate those files from
source.

https://buildd.debian.org/status/fetch.php?pkg=libfso-glib&arch=i386&ver=2012.05.24.1-1.1&stamp=1348873883

The package should also be using the new Built-Using field since it uses
source from another package:

http://www.debian.org/doc/debian-policy/ch-relationships.html#s-built-using

In addition the build system should be verbose, not silent.

If I delete the generated code and build from the actual source then the
package FTBFS because the ABI specified in fso-specs is different from
the ABI specified by the version of fso-specs

Please ask upstream to drop the generated files from their tarball and
instead force people to build-depend on the specs to prevent the sources
for the library and the specs from getting out-of-sync.

This patch should fix the not-building-from-source and silent-rules
issue but it will not fix the ABI change issue.

--- a/debian/rules
+++ b/debian/rules
@@ -2,9 +2,13 @@
 %:
 	dh $@ --with quilt --with autoreconf
 
+override_dh_auto_clean:
+	dh_auto_clean
+	rm -f src/*.vala src/*.vapi src/*.h src/*.c
+
 override_dh_auto_configure:
 	find . -name *_vala.stamp | xargs rm -f
-	dh_auto_configure -- --enable-vala
+	dh_auto_configure -- --enable-vala --disable-silent-rules
 
 override_dh_strip:
 	dh_strip --dbg-package=libfso-glib-dbg

pabs at chianamo ~/tmp/libfso-glib-2012.05.24.1 $ head -n1 src/*
==> src/freesmartphone-audio.c <==
/* freesmartphone-audio.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-audio.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone.c <==
/* freesmartphone.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-context.c <==
/* freesmartphone-context.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-context.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone-data.c <==
/* freesmartphone-data.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-data.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone-device.c <==
/* freesmartphone-device.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-device.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone-gsm.c <==
/* freesmartphone-gsm.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-gsm.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone.h <==
/* freesmartphone.h generated by valac 0.14.2, the Vala compiler, do not modify */

==> src/freesmartphone-pim.c <==
/* freesmartphone-pim.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-pim.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone-time.c <==
/* freesmartphone-time.c generated by valac 0.14.2, the Vala compiler

==> src/freesmartphone-time.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/freesmartphone.vala <==
/* Generated by vala-dbus-binding-tool 0.3.3. Do not modify! */

==> src/fso-glib-1.0.deps <==
glib-2.0

==> src/fso-glib-1.0.vapi <==
/* fso-glib-1.0.vapi generated by valac 0.14.2, do not modify. */

==> src/libfso_glib_la_vala.stamp <==
stamp

==> src/Makefile.am <==
include $(top_srcdir)/Makefile.decl

==> src/Makefile.in <==
# Makefile.in generated by automake 1.11.3 from Makefile.am.


dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libfso-glib1/DEBIAN/symbols doesn't match completely debian/libfso-glib1.symbols
--- debian/libfso-glib1.symbols (libfso-glib1_2012.05.24.1-1.1_amd64)
+++ dpkg-gensymbolsRXr7IC	2012-11-18 02:21:28.008968520 +0000
@@ -352,6 +352,8 @@
  free_smartphone_gsm_call_activate_conference at Base 2012.02.16.1
  free_smartphone_gsm_call_activate_conference_finish at Base 2012.02.16.1
  free_smartphone_gsm_call_activate_finish at Base 2012.02.16.1
+ free_smartphone_gsm_call_deflect at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_deflect_finish at Base 2012.05.24.1-1.1
  free_smartphone_gsm_call_detail_copy at Base 2012.02.16.1
  free_smartphone_gsm_call_detail_destroy at Base 2012.02.16.1
  free_smartphone_gsm_call_detail_dup at Base 2012.02.16.1
@@ -361,6 +363,24 @@
  free_smartphone_gsm_call_detail_init at Base 2012.02.16.1
  free_smartphone_gsm_call_emergency at Base 2012.02.16.1
  free_smartphone_gsm_call_emergency_finish at Base 2012.02.16.1
+ free_smartphone_gsm_call_forwarding_disable at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_disable_all at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_disable_all_finish at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_disable_finish at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_enable at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_enable_finish at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_get_status at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_get_status_finish at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_get_type at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_proxy_get_type at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_register_object at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_disable at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_disable_all at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_enable at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_get_status at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_get_type at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_proxy_get_type at Base 2012.05.24.1-1.1
+ free_smartphone_gsm_call_forwarding_sync_register_object at Base 2012.05.24.1-1.1
  free_smartphone_gsm_call_get_type at Base 2012.02.16.1
  free_smartphone_gsm_call_hold_active at Base 2012.02.16.1
  free_smartphone_gsm_call_hold_active_finish at Base 2012.02.16.1
@@ -385,6 +405,7 @@
  free_smartphone_gsm_call_status_to_string at Base 2012.02.16.1
  free_smartphone_gsm_call_sync_activate at Base 2012.02.16.1
  free_smartphone_gsm_call_sync_activate_conference at Base 2012.02.16.1
+ free_smartphone_gsm_call_sync_deflect at Base 2012.05.24.1-1.1
  free_smartphone_gsm_call_sync_emergency at Base 2012.02.16.1
  free_smartphone_gsm_call_sync_get_type at Base 2012.02.16.1
  free_smartphone_gsm_call_sync_hold_active at Base 2012.02.16.1
@@ -521,12 +542,12 @@
  free_smartphone_gsm_mux_sync_register_object at Base 2012.02.16.1
  free_smartphone_gsm_mux_sync_release_channel at Base 2012.02.16.1
  free_smartphone_gsm_mux_sync_set_status at Base 2012.02.16.1
- free_smartphone_gsm_network_disable_call_forwarding at Base 2012.02.16.1
- free_smartphone_gsm_network_disable_call_forwarding_finish at Base 2012.02.16.1
- free_smartphone_gsm_network_enable_call_forwarding at Base 2012.02.16.1
- free_smartphone_gsm_network_enable_call_forwarding_finish at Base 2012.02.16.1
- free_smartphone_gsm_network_get_call_forwarding at Base 2012.02.16.1
- free_smartphone_gsm_network_get_call_forwarding_finish at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_disable_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_disable_call_forwarding_finish at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_enable_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_enable_call_forwarding_finish at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_get_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_get_call_forwarding_finish at Base 2012.02.16.1
  free_smartphone_gsm_network_get_calling_identification at Base 2012.02.16.1
  free_smartphone_gsm_network_get_calling_identification_finish at Base 2012.02.16.1
  free_smartphone_gsm_network_get_signal_strength at Base 2012.02.16.1
@@ -555,9 +576,9 @@
  free_smartphone_gsm_network_send_ussd_request_finish at Base 2012.02.16.1
  free_smartphone_gsm_network_set_calling_identification at Base 2012.02.16.1
  free_smartphone_gsm_network_set_calling_identification_finish at Base 2012.02.16.1
- free_smartphone_gsm_network_sync_disable_call_forwarding at Base 2012.02.16.1
- free_smartphone_gsm_network_sync_enable_call_forwarding at Base 2012.02.16.1
- free_smartphone_gsm_network_sync_get_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_sync_disable_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_sync_enable_call_forwarding at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_network_sync_get_call_forwarding at Base 2012.02.16.1
  free_smartphone_gsm_network_sync_get_calling_identification at Base 2012.02.16.1
  free_smartphone_gsm_network_sync_get_signal_strength at Base 2012.02.16.1
  free_smartphone_gsm_network_sync_get_status at Base 2012.02.16.1
@@ -582,7 +603,7 @@
  free_smartphone_gsm_pdp_get_credentials at Base 2012.02.16.1
  free_smartphone_gsm_pdp_get_credentials_finish at Base 2012.02.16.1
  free_smartphone_gsm_pdp_get_roaming_allowed at Base 2012.02.16.1
- free_smartphone_gsm_pdp_get_roaming_allowed_finish at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_pdp_get_roaming_allowed_finish at Base 2012.02.16.1
  free_smartphone_gsm_pdp_get_type at Base 2012.02.16.1
  free_smartphone_gsm_pdp_internal_status_update at Base 2012.02.16.1
  free_smartphone_gsm_pdp_internal_status_update_finish at Base 2012.02.16.1
@@ -591,7 +612,7 @@
  free_smartphone_gsm_pdp_set_credentials at Base 2012.02.16.1
  free_smartphone_gsm_pdp_set_credentials_finish at Base 2012.02.16.1
  free_smartphone_gsm_pdp_set_roaming_allowed at Base 2012.02.16.1
- free_smartphone_gsm_pdp_set_roaming_allowed_finish at Base 2012.02.16.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_gsm_pdp_set_roaming_allowed_finish at Base 2012.02.16.1
  free_smartphone_gsm_pdp_sync_activate_context at Base 2012.02.16.1
  free_smartphone_gsm_pdp_sync_deactivate_context at Base 2012.02.16.1
  free_smartphone_gsm_pdp_sync_get_context_status at Base 2012.02.16.1
@@ -738,15 +759,15 @@
  free_smartphone_info_sync_get_type at Base 2012.02.16.1
  free_smartphone_info_sync_proxy_get_type at Base 2012.02.16.1
  free_smartphone_info_sync_register_object at Base 2012.02.16.1
- free_smartphone_location_get_location at Base 2012.05.24.1
- free_smartphone_location_get_location_finish at Base 2012.05.24.1
- free_smartphone_location_get_type at Base 2012.05.24.1
- free_smartphone_location_proxy_get_type at Base 2012.05.24.1
- free_smartphone_location_register_object at Base 2012.05.24.1
- free_smartphone_location_sync_get_location at Base 2012.05.24.1
- free_smartphone_location_sync_get_type at Base 2012.05.24.1
- free_smartphone_location_sync_proxy_get_type at Base 2012.05.24.1
- free_smartphone_location_sync_register_object at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_get_location at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_get_location_finish at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_proxy_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_register_object at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_sync_get_location at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_sync_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_sync_proxy_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_location_sync_register_object at Base 2012.05.24.1
  free_smartphone_network_get_type at Base 2012.02.16.1
  free_smartphone_network_offer_default_route at Base 2012.02.16.1
  free_smartphone_network_offer_default_route_finish at Base 2012.02.16.1
@@ -1021,18 +1042,18 @@
  free_smartphone_pim_fields_sync_register_object at Base 2012.02.16.1
  free_smartphone_pim_message_delete at Base 2012.02.16.1
  free_smartphone_pim_message_delete_finish at Base 2012.02.16.1
- free_smartphone_pim_message_folder_get_message_count at Base 2012.05.24.1
- free_smartphone_pim_message_folder_get_message_count_finish at Base 2012.05.24.1
- free_smartphone_pim_message_folder_get_message_paths at Base 2012.05.24.1
- free_smartphone_pim_message_folder_get_message_paths_finish at Base 2012.05.24.1
- free_smartphone_pim_message_folder_get_type at Base 2012.05.24.1
- free_smartphone_pim_message_folder_proxy_get_type at Base 2012.05.24.1
- free_smartphone_pim_message_folder_register_object at Base 2012.05.24.1
- free_smartphone_pim_message_folder_sync_get_message_count at Base 2012.05.24.1
- free_smartphone_pim_message_folder_sync_get_message_paths at Base 2012.05.24.1
- free_smartphone_pim_message_folder_sync_get_type at Base 2012.05.24.1
- free_smartphone_pim_message_folder_sync_proxy_get_type at Base 2012.05.24.1
- free_smartphone_pim_message_folder_sync_register_object at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_get_message_count at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_get_message_count_finish at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_get_message_paths at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_get_message_paths_finish at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_proxy_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_register_object at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_sync_get_message_count at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_sync_get_message_paths at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_sync_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_sync_proxy_get_type at Base 2012.05.24.1
+#MISSING: 2012.05.24.1-1.1# free_smartphone_pim_message_folder_sync_register_object at Base 2012.05.24.1
  free_smartphone_pim_message_get_content at Base 2012.02.16.1
  free_smartphone_pim_message_get_content_finish at Base 2012.02.16.1
  free_smartphone_pim_message_get_multiple_fields at Base 2012.02.16.1
@@ -1286,6 +1307,8 @@
  free_smartphone_resource_enable at Base 2012.02.16.1
  free_smartphone_resource_enable_finish at Base 2012.02.16.1
  free_smartphone_resource_error_quark at Base 2012.02.16.1
+ free_smartphone_resource_get_default_policy at Base 2012.05.24.1-1.1
+ free_smartphone_resource_get_default_policy_finish at Base 2012.05.24.1-1.1
  free_smartphone_resource_get_dependencies at Base 2012.02.16.1
  free_smartphone_resource_get_dependencies_finish at Base 2012.02.16.1
  free_smartphone_resource_get_type at Base 2012.02.16.1
@@ -1297,6 +1320,7 @@
  free_smartphone_resource_suspend_finish at Base 2012.02.16.1
  free_smartphone_resource_sync_disable at Base 2012.02.16.1
  free_smartphone_resource_sync_enable at Base 2012.02.16.1
+ free_smartphone_resource_sync_get_default_policy at Base 2012.05.24.1-1.1
  free_smartphone_resource_sync_get_dependencies at Base 2012.02.16.1
  free_smartphone_resource_sync_get_type at Base 2012.02.16.1
  free_smartphone_resource_sync_proxy_get_type at Base 2012.02.16.1
dh_makeshlibs: dpkg-gensymbols -plibfso-glib1 -Idebian/libfso-glib1.symbols -Pdebian/libfso-glib1 -edebian/libfso-glib1/usr/lib/x86_64-linux-gnu/libfso-glib.so.1.0.0

-- 
bye,
pabs

http://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20121118/f6be054d/attachment.pgp>

More information about the pkg-fso-maint mailing list