[Pkg-ganeti-devel] Fwd: Initial debian/ directory

[Guido Trotter]

On Wed, Oct 03, 2007 at 05:57:25PM -0300, Leonardo Rodrigues de Mello wrote:

Hi!

Thanks a lot for your tests!


> Tested, and fixed some issues:
> first issue, the os-search-path in rules was not correct:

Oh, yeah! I had noticed too and thought I committed the other version! Let's
definitely fix that! :)

> I believe that the email of ganeti packaging team can be this
> maillinglist, 

yes

> there was one mispelling of maintenance in the file
> copyright and solved lot almost all warnings from lintian. There is
> just one warning now, about manpage of ganeti-master.
> 

we'll look into that...

> -Recommends: drbd0.7-utils, xen-linux-system-2.6.18-5-xen-vserver-686
> | xen-linux-system-2.6.18-4-xen-686 |
> xen-linux-system-2.6.18-5-xen-686 |
> xen-linux-system-2.6.18-4-xen-vserver-686
> +Recommends: xen-linux-system-2.6.18-5-xen-vserver-686 |
> xen-linux-system-2.6.18-4-xen-686 | xen-linux-system-2.6.18-5-xen-686
> | xen-linux-system-2.6.18-4-xen-vserver-686
>  Suggests: drbd0.7-module-source, drbd0.7-utils

Why not having utils as recommends and source as suggests? On many systems you
will need the utils, while the kernel might be come from some other place or be
compiled centrally and shipped to all the nodes...

> -It was then taken over for official Debian maintainance by the Debian
> Ganeti Team.
> +It was then taken over for official Debian  maintenance by the Debian
> Ganeti Team.
> 

Yes, without the double space... :)


> +  --with-os-search-path=/srv/ganeti/os,/usr/local/lib/ganeti/os,/usr/local/share/ganeti/os,/usr/lib/ganeti/os,/usr/share/ganeti/os

Yes! :)

> +binary-post-install/ganeti::
> +       find debian/$(cdbs_curpkg) -name '*.py[co]' -print0 | xargs -0 rm -f --
> +       find debian/$(cdbs_curpkg) -name '*.py' -print | grep -v _autoconf.py | xargs chmod a+x --

Do we really need all of them to be executable?

> There one issue with ganeti autotools build system, related to initd
> script.. this script is inside directory doc/examples, Actualy, when
> someone run make install inside doc/examples/ it will put ganeti.initd
> inside /usr/bin/ganeti.initd

Wops, I hadn't noticed... I believe that the best solution for now would just be
to remove it in binary-post-install/ganeti::, and avoid modifying upstream's
makefiles... even though modifying them, from upstream, might make sense...
We'll talk about it! :)

Thanks!

Guido