[Pkg-gnupg-commit] [libassuan] 150/437: Doc updates.

[Eric Dorland]

This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository libassuan.

commit 8f03bae28a23027c383bab16d0bf9df78f56d2e6
Author: Werner Koch <wk at gnupg.org>
Date:   Tue Jun 27 10:37:31 2006 +0000

    Doc updates.
---
 TODO                | 6 ++++++
 src/assuan-client.c | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/TODO b/TODO
index e02e984..3e9161c 100644
--- a/TODO
+++ b/TODO
@@ -3,3 +3,9 @@
 * When turning libassuan into a shared library, provide a general
   version as well as a Pth-enabled one.
 * Need API documentation.
+* assuan_transact returns immetitely on an error in the callback
+  function.  It might be Better to return the error to the caller. As
+  an example see dirmngr-client, where we need to send empty reponses
+  for unknown inquiries, albeit dirmngr itself would handle the
+  returns for assuan_inquire gracefully.  We need to chekc all
+  applications whether it is safe to change this.
diff --git a/src/assuan-client.c b/src/assuan-client.c
index 7275314..56ce299 100644
--- a/src/assuan-client.c
+++ b/src/assuan-client.c
@@ -125,7 +125,9 @@ _assuan_read_from_server (ASSUAN_CONTEXT ctx, int *okay, int *off)
  * 
  * Return value: 0 on success or error code.  The error code may be
  * the one one returned by the server in error lines or from the
- * callback functions.
+ * callback functions.  Take care: When a callback returns an error
+ * this function returns immediately with an error and thus the caller
+ * will altter return an Assuan error (write erro in most cases).
  **/
 assuan_error_t
 assuan_transact (ASSUAN_CONTEXT ctx,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/libassuan.git