[Pkg-gnupg-commit] [gnupg2] 275/292: scd: Don't limit to ST-2xxx for PC/SC.

[Daniel Kahn Gillmor]

This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch master
in repository gnupg2.

commit b6066ab18a67195817babaf9eccf896c2b3c7b0e
Author: NIIBE Yutaka <gniibe at fsij.org>
Date:   Fri Nov 18 08:54:04 2016 +0900

    scd: Don't limit to ST-2xxx for PC/SC.
    
    * scd/apdu.c (pcsc_vendor_specific_init): Only check vender ID.
    
    --
    
    Some other products by Cherry works with pinpad, although it only works
    for smaller keys (RSA 1024).  TPDU support is good for larger keys.
    
    Signed-off-by: NIIBE Yutaka <gniibe at fsij.org>
---
 scd/apdu.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/scd/apdu.c b/scd/apdu.c
index 3e2b609..54f3b30 100644
--- a/scd/apdu.c
+++ b/scd/apdu.c
@@ -1896,8 +1896,12 @@ pcsc_vendor_specific_init (int slot)
       reader_table[slot].is_spr532 = 1;
       reader_table[slot].pinpad_varlen_supported = 1;
     }
-  else if (vendor == 0x046a && product == 0x003e) /* Cherry ST-2xxx */
+  else if (vendor == 0x046a)
     {
+      /* Cherry ST-2xxx (product == 0x003e) supports TPDU level
+       * exchange.  Other products which only support short APDU level
+       * exchange only work with shorter keys like RSA 1024.
+       */
       reader_table[slot].pcsc.pinmax = 15;
       reader_table[slot].pinpad_varlen_supported = 1;
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gnupg2.git