[Pkg-gnupg-commit] [gpgme] 325/412: qt: Clarify comment and strings in tofuinfo test

[Daniel Kahn Gillmor]

This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch master
in repository gpgme.

commit ab3fbdbd05cfd1b039bb5b1eb3941fbb4bcf6307
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Mon Sep 5 16:54:50 2016 +0200

    qt: Clarify comment and strings in tofuinfo test
    
    * lang/qt/tests/t-tofuinfo.cpp (testTofuSignCount)
    (testTofuKeyList): Ensure distinct messages. Clarify comment.
---
 lang/qt/tests/t-tofuinfo.cpp | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lang/qt/tests/t-tofuinfo.cpp b/lang/qt/tests/t-tofuinfo.cpp
index f7238f3..5646f70 100644
--- a/lang/qt/tests/t-tofuinfo.cpp
+++ b/lang/qt/tests/t-tofuinfo.cpp
@@ -230,6 +230,12 @@ private Q_SLOTS:
         Key key = keys[0];
         Q_ASSERT(!key.isNull());
 
+        /* As we sign & verify quickly here we need different
+         * messages to avoid having them treated as the same
+         * message if they were created within the same second.
+         * Alternatively we could use the same message and wait
+         * a second between each call. But this would slow down
+         * the testsuite. */
         signAndVerify(QStringLiteral("Hello"), key, 1);
         key.update();
         signAndVerify(QStringLiteral("Hello2"), key, 2);
@@ -258,12 +264,10 @@ private Q_SLOTS:
         auto keyCopy = key;
         keyCopy.update();
         auto sigCnt = keyCopy.userID(0).tofuInfo().signCount();
-        signAndVerify(QStringLiteral("Hello"), keyCopy,
+        signAndVerify(QStringLiteral("Hello5"), keyCopy,
                       sigCnt + 1);
         keyCopy.update();
-        /* For some reason if you remove the " World" part of
-         * the next message the test fails. */
-        signAndVerify(QStringLiteral("Hello World"), keyCopy,
+        signAndVerify(QStringLiteral("Hello6"), keyCopy,
                       sigCnt + 2);
 
         /* Now another one but with tofu */

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gpgme.git