[Pkg-gnupg-commit] [gpgme] 08/12: core: Fix error checking in _gpgme_mkstemp.

Daniel Kahn Gillmor dkg at fifthhorseman.net
Thu Sep 22 23:29:28 UTC 2016


This is an automated email from the git hooks/post-receive script.

dkg pushed a commit to branch cleanup-2016-09-22
in repository gpgme.

commit c447b64d5989845a2ae2cf8fb30a92d2a0bd05af
Author: Werner Koch <wk at gnupg.org>
Date:   Thu Sep 22 12:46:06 2016 +0200

    core: Fix error checking in _gpgme_mkstemp.
    
    * src/w32-util.c (_gpgme_mkstemp): Fix error checking.
    (dlopen): Mark FLAGS as unused.
    
    Signed-off-by: Werner Koch <wk at gnupg.org>
---
 src/w32-util.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/w32-util.c b/src/w32-util.c
index edac750..9d42139 100644
--- a/src/w32-util.c
+++ b/src/w32-util.c
@@ -98,6 +98,8 @@ static GPG_ERR_INLINE void *
 dlopen (const char * name, int flag)
 {
   void * hd = LoadLibrary (name);
+
+  (void)flag;
   return hd;
 }
 
@@ -754,7 +756,7 @@ _gpgme_mkstemp (int *fd, char **name)
   if (!tmpname)
     return -1;
   *fd = my_mkstemp (tmpname);
-  if (fd < 0)
+  if (*fd < 0)
     {
       free (tmpname);
       return -1;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-gnupg/gpgme.git



More information about the Pkg-gnupg-commit mailing list