[Pkg-graphite-maint] Tools for graphites peripheral region
    Jonas Genannt 
    jonas.genannt at capi2name.de
       
    Tue Dec 17 21:06:53 UTC 2013
    
    
  
Hello Andreas,
> as I wrote I started the packaging on logster.
cool, thanks for your work!
> It would be great if you could take a look.
I had a quick look, need to do an closer look, after the have had a look at the last
point:
* d/control:
  - change Maintainer to Graphite Group (e.g graphite-web)
  - add yourself as Uploader
* logster.dir is not used, do you mean logster.dirs? (man dh_installdirs)
* you are using logster.mainpages on the other side you have
only "docs". I prefer having all <packagename>.foo. That makes
easier if you add later an second binary package to that.
* if you ship var/log/logster, you should also add an logrotate job for cleanup
* if you want to ship var/log/logester you should also remove var/log/logster on purge
  (postrm) Script
* you have written an manpage, perhaps you want to create an Pull request on Github, to
  add it to upstream? (I also use markdown/ronn for that and create an manpage with it)
  (see graphite-web package) 
* libraries are missing in the binary deb, the directory "logster/parsers" is missing
  so you can't use logster at the moment from the debian package.
  I build logster via clean chroot with sbuild
Thanks!
	Jonas
    
    
More information about the Pkg-graphite-maint
mailing list