[Pkg-graphite-maint] Tools for graphites peripheral region

[Andreas Rütten]

Hi Jonas,

Am Tue, 17 Dec 2013 22:06:53 +0100
schrieb Jonas Genannt <jonas.genannt at capi2name.de>:

> I had a quick look, need to do an closer look, after the have had a
> look at the last point:

Thanks a lot, and sorry for not so carefully first try. Some points are
so obvious.

 
> * d/control:
>   - change Maintainer to Graphite Group (e.g graphite-web)
>   - add yourself as Uploader

Fixed in git

> * logster.dir is not used, do you mean logster.dirs? (man
> dh_installdirs)

Fixed in git

> * you are using logster.mainpages on the other side you have
> only "docs". I prefer having all <packagename>.foo. That makes
> easier if you add later an second binary package to that.

Fixed in git to <packagename>.foo for all
 
> * if you ship var/log/logster, you should also add an logrotate job
> for cleanup

Fixed in git
 
> * if you want to ship var/log/logester you should also remove
> var/log/logster on purge (postrm) Script

Fixed in git
 
> * you have written an manpage, perhaps you want to create an Pull
> request on Github, to add it to upstream? (I also use markdown/ronn
> for that and create an manpage with it) (see graphite-web package) 

I definitely plan to send it upstream. I just want to wait until
the package as finished the review period.
 
> * libraries are missing in the binary deb, the directory
> "logster/parsers" is missing so you can't use logster at the moment
> from the debian package. I build logster via clean chroot with sbuild

Right, I missed that.
Looks like this is fixed upstream.
https://github.com/etsy/logster/commit/57de61a3d9fe3f21a9456984fb7fb39b8603b660#diff-2eeaed663bd0d25b7e608891384b7298
But not in the last released version and I also didn't test it until
now.


I'm using pbuilder for clean builds but still have some difficulties
with the used buildsystem and playing around with python-distutils and
pybuild.


I'll keep you informed about my progress.


Cheers,
Andreas





-- 
Andreas Rütten                           mailto:AndreasRuetten at gmx.de
                                           xmpp:AndreasRuetten at gmx.de
                                          irc://irc.oftc.net/aruetten

4096R: 0x6C9DFFB2 / 8394 99DA 59BD BCE2 3FC8 3A9E 6633 0089 6C9D FFB2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-graphite-maint/attachments/20131219/e7d01216/attachment.sig>