Lionel Elie Mamane
lionel at mamane.lu
Sat Jan 28 03:48:44 UTC 2006
On Mon, Jan 23, 2006 at 10:19:32PM +0100, Lionel Elie Mamane wrote:
> On Mon, Dec 19, 2005 at 11:28:00PM +0100, Lionel Elie Mamane wrote:
>> On Fri, Dec 16, 2005 at 01:30:53AM +0100, Gregory Colpart wrote:
>>> I need a sponsor for my horde-sam packages.
>> It seems natural that the DDs in team will sponsor you. Tell us
>> when you think the packages are good for an upload.
>>> Non-final version (I prepare some patches) can be download here :
>> I'll try to look at it, but don't hold your breath. Quite busy
>> lately and for some weeks to come.
> Haven't had the time yet. Sorry about that. Lemme know when you have
> a final version ready.
I took a cursory glance at it.
- Please document the changes you did with respect to upstream in
debian/changelog. Every patch in debian/patches/ warrants its entry
- If you don't mind, please put me in Uploaders, so that I see the
package on my qa.debian.org/developer.php page. Thanks.
- Don't ship the upstream INSTALL document; large parts of it don't
apply to Debian users that installed it through the package. Ship
the relevant parts of it, with paths eventually corrected, in
README.Debian or so.
- when you use the s command of sed with a pattern or replacement
that uses slashes, it is easier (and more readable) to use another
separator for the command. So instead of
sed -e "s/\/usr\/local\/bin/\/usr\/bin/"
you can use
sed -e "s|/usr/local/bin|/usr/bin|"
sed -e "s@/usr/local/bin@/usr/bin@"
- the binary targets are wrong: the package is "architecture: all",
so it is in binary-arch that nothing happens and in binary-indep
that things happen. Your current code does the opposite :)
More information about the pkg-horde-hackers