[pkg-horde] horde-sam

[Gregory Colpart]

On Sat, Jan 28, 2006 at 04:48:44AM +0100, Lionel Elie Mamane wrote:
> On Mon, Jan 23, 2006 at 10:19:32PM +0100, Lionel Elie Mamane wrote:
> > On Mon, Dec 19, 2005 at 11:28:00PM +0100, Lionel Elie Mamane wrote:
> >> On Fri, Dec 16, 2005 at 01:30:53AM +0100, Gregory Colpart wrote:
> 
> >>> I need a sponsor for my horde-sam packages.
> 
> >> It seems natural that the DDs in team will sponsor you. Tell us
> >> when you think the packages are good for an upload.
> 
> >>> Non-final version (I prepare some patches) can be download here :
> 
> >>> http://gcolpart.evolix.net/debian/horde-sam/
> 
> >> I'll try to look at it, but don't hold your breath. Quite busy
> >> lately and for some weeks to come.
> 
> > Haven't had the time yet. Sorry about that. Lemme know when you have
> > a final version ready.
> 
> I took a cursory glance at it.
> 
>  - Please document the changes you did with respect to upstream in
>    debian/changelog. Every patch in debian/patches/ warrants its entry
>    in debian/changelog.

done. I have now 2 little patches (typo bug in reality).
I removed the third patch obsoleted by an upstream commit.

>  - If you don't mind, please put me in Uploaders, so that I see the
>    package on my qa.debian.org/developer.php page. Thanks.

done. I put you and me as describe on Debian policy :
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Uploaders

>  - Don't ship the upstream INSTALL document; large parts of it don't
>    apply to Debian users that installed it through the package. Ship
>    the relevant parts of it, with paths eventually corrected, in
>    README.Debian or so.

done.

>  - when you use the s command of sed with a pattern or replacement
>    that uses slashes, it is easier (and more readable) to use another
>    separator for the command. So instead of
> 
>    sed -e "s/\/usr\/local\/bin/\/usr\/bin/"
> 
>    you can use
> 
>    sed -e "s|/usr/local/bin|/usr/bin|"
> 
>    or
> 
>    sed -e "s@/usr/local/bin@/usr/bin@"
> 
>    or ...

done.

>  - the binary targets are wrong: the package is "architecture: all",
>    so it is in binary-arch that nothing happens and in binary-indep
>    that things happen. Your current code does the opposite :)

oops! done.


Final version can be download here :

http://gcolpart.evolix.net/debian/horde-sam/

I will upload it when I finish reading your links and infos on
GNU Arch. Now I just "archive-setup" horde--*-0.


Thanks,
-- 
Gregory Colpart <reg at evolix.fr>  GnuPG:1024D/C1027A0E
Evolix - Informatique et Logiciels Libres http://www.evolix.fr/