Bug#358434: [Pkg-icecast-devel] Bug#358434: Fix for MPEG Audio layer 2

[Jonas Smedegaard]

package libshout
tags 358434 wontfix
thanks

On Sat, 20 May 2006 15:07:36 +0100 Nicholas J Humfrey wrote:

> 
> Simply comment out lines 300 and 301 in mp3.c.
> 
> //        if (mh->layer != 2)
> //                return 0;
> 
> 
> Or possibly just allow Layers 2 and 3:
> 
>          if (mh->layer != 2 || mh->layer != 1)
>                  return 0;

You initially stated that only layer 3 audio was accepted, but the
original lines corresponding to the above seems to say that only layer
2 is allowed (non-2 returns false).

I'd really appreciate it if you would would instead get in touch with
upstream and try to convince them to to the correction, as I cannot
judge if this change could cause unwanted side-effects.

I'll keep this bugreport open, but tag it "wontfix". If you for some
reason fail to convince upstream but still believe it to be useful for
Debian to include this patch, then please provide a pointer to the
discussion with them, and your more detailed arguments (I think I'm not
completely impossible to convince :-) ).


 - Jonas

-- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

 - Enden er nær: http://www.shibumi.org/eoti.htm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-icecast-devel/attachments/20060715/cd9e90bb/attachment.pgp