Bug#358434: [Pkg-icecast-devel] Bug#358434: Fix for MPEG Audio layer 2

[Nicholas J Humfrey]

Ok, I will have a go at convincing upstream. I am sure I have emailed  
the icecast-dev mailing list in the past and didn't get any response.  
But will give it another go.

Note that the value for 'layer' in the frame header isn't the same as  
the layer number:

http://www.mp3-tech.org/programmer/frame_header.html

00 - reserved
01 - Layer III
10 - Layer II
11 - Layer I


Thanks,

nick.


On 15 Jul 2006, at 12:29, Jonas Smedegaard wrote:

> package libshout
> tags 358434 wontfix
> thanks
>
> On Sat, 20 May 2006 15:07:36 +0100 Nicholas J Humfrey wrote:
>
>>
>> Simply comment out lines 300 and 301 in mp3.c.
>>
>> //        if (mh->layer != 2)
>> //                return 0;
>>
>>
>> Or possibly just allow Layers 2 and 3:
>>
>>          if (mh->layer != 2 || mh->layer != 1)
>>                  return 0;
>
> You initially stated that only layer 3 audio was accepted, but the
> original lines corresponding to the above seems to say that only layer
> 2 is allowed (non-2 returns false).
>
> I'd really appreciate it if you would would instead get in touch with
> upstream and try to convince them to to the correction, as I cannot
> judge if this change could cause unwanted side-effects.
>
> I'll keep this bugreport open, but tag it "wontfix". If you for some
> reason fail to convince upstream but still believe it to be useful for
> Debian to include this patch, then please provide a pointer to the
> discussion with them, and your more detailed arguments (I think I'm  
> not
> completely impossible to convince :-) ).
>
>
>  - Jonas
>
> -- 
> * Jonas Smedegaard - idealist og Internet-arkitekt
> * Tlf.: +45 40843136  Website: http://dr.jones.dk/
>
>  - Enden er nær: http://www.shibumi.org/eoti.htm