[Pkg-ime-devel] [RFS] skim package
minghua at rice.edu
Sun Aug 7 21:58:01 UTC 2005
On Tue, Aug 02, 2005 at 10:57:05AM +0800, William J Beksi wrote:
> I am looking for someone to sponsor my skim package. The source for
> skim_1.2.3-1 is here:
> It's neither lintian nor linda clean. Any comments and/or criticisms
> would be greatly appreciated.
Thanks for the work on skim packaging. I've just had a brief look on
your packages (didn't try to build it), and I have a few comments:
1. How did you generated skim_1.2.3.orig.tar.gz? I know that upstream
only releases bzipped tarballes, but I uncompressed your tarball and the
one from upstream, they don't match:
It's usually desirable to use the upstream tarballs as much as possible.
2. You have stuff about dpatch in debian/rules, and Build-Depends on
dpatch. However you don't have any dpatches, not even a debian/patches
directory. Is this intentional?
3. You have the following in build dependency:
I believe it's wrong. You should Build-Depend on packages of
development files (-dev ones), not the packages of runtime files.
More information about the Pkg-ime-devel