[Pkg-ime-devel] [RFS] skim package

[Ming Hua]

On Tue, Aug 02, 2005 at 10:57:05AM +0800, William J Beksi wrote:
> 
> Greetings,
> I am looking for someone to sponsor my skim package. The source for
> skim_1.2.3-1 is here:
> http://mentors.debian.net/debian/pool/main/s/skim/
> 
> It's neither lintian nor linda clean. Any comments and/or criticisms
> would be greatly appreciated.

Hi William,

Thanks for the work on skim packaging.  I've just had a brief look on
your packages (didn't try to build it), and I have a few comments:

1. How did you generated skim_1.2.3.orig.tar.gz?  I know that upstream
only releases bzipped tarballes, but I uncompressed your tarball and the
one from upstream, they don't match:
    3b051e68bb4fa032f0a08de4683ff6fa  skim-1.2.3.tar
    96554f5aee54c67598d5c93484079a66  skim_1.2.3.orig.tar
It's usually desirable to use the upstream tarballs as much as possible.

2. You have stuff about dpatch in debian/rules, and Build-Depends on
dpatch.  However you don't have any dpatches, not even a debian/patches
directory.  Is this intentional?

3. You have the following in build dependency:
    libpng12-0, libfam0c102
I believe it's wrong.  You should Build-Depend on packages of
development files (-dev ones), not the packages of runtime files.

Regards,
Ming
2005.08.07