[Pkg-ime-devel] [RFS] skim package
William J Beksi
wjbeksi at users.sourceforge.net
Mon Aug 8 13:23:38 UTC 2005
Hi Ming Hua,
Ming Hua wrote:
> Thanks for the work on skim packaging. I've just had a brief look on
> your packages (didn't try to build it), and I have a few comments:
> 1. How did you generated skim_1.2.3.orig.tar.gz? I know that upstream
> only releases bzipped tarballes, but I uncompressed your tarball and the
> one from upstream, they don't match:
> 3b051e68bb4fa032f0a08de4683ff6fa skim-1.2.3.tar
> 96554f5aee54c67598d5c93484079a66 skim_1.2.3.orig.tar
> It's usually desirable to use the upstream tarballs as much as possible.
I'm using the upstream bzipped tarball, however it seems dh_make does
not like the "bz2" extension, I get the following error message from
"Source file is a bz2 but bzip2 or gzip not available at
/usr/bin/dh_make line 409, <STDIN> line 2."
That is why I renamed the extension, maybe I should ask upstream to
rename the extension to "bzip2"?
> 2. You have stuff about dpatch in debian/rules, and Build-Depends on
> dpatch. However you don't have any dpatches, not even a debian/patches
> directory. Is this intentional?
Yes, I did not modify the orginal source code so I have no patches from
the first build of skim. I added the dpatch stuff to debian/rules for
> 3. You have the following in build dependency:
> libpng12-0, libfam0c102
> I believe it's wrong. You should Build-Depend on packages of
> development files (-dev ones), not the packages of runtime files.
Yes, it's wrong. libpng12-0 and libfam0c102 are skim runtime
dependencies, I will correct this.
Thank you for your comments. :-)
William J Beksi <wjbeksi at users.sourceforge.net>
GPG Key Fingerprint = ED4B 32C3 69E6 C2B7 705C 263F CB2F 3253 E7E1 DB3B
More information about the Pkg-ime-devel