[Pkg-ime-devel] Fwd: new sunpinyin packages,

[Liang Guo]

Hi, Thomas,

Thank you for your careful review.

2010/8/24 Thomas Goirand <zigo at debian.org>:
> Hi,
>
> Here's my comments.
>
> All packages:
> -------------
> First thing, the target distribution that you have set is "unstable",
> and as Debian Squeeze is now frozen, you should set it to experimental
> (which was also what you wanted to do). Please change your
> debian/changelog for these 3 packages.

change the target distribution to "experimental"

> Open-gram:
> ----------
> 1/ If you have a specific GPL-3 license for the debian folder, you
> should have a copyright notice that corresponds to it. Please add it
> there, just referencing the /usr/share/common-licenses/GPL-3 isn't enough.

I changed to use CC-by-SA 3.0,  as the upstream software. and changed
debian/copyright file, if any inappropriate, please let me know.

> 2/ You've set yourself as the maintainer of the package. While I think
> this is a good idea if you want to maintain the package after the first
> sponsoring of it, this isn't consistent at all with the other 2
> packages. Are you sure this is what you want to do here?

I've change maintainer to IME packaging team and uploader to me.

> ibus-sunpinyin:
> ---------------
> 1/ In your debian/rules, you are doing:
> cd wrapper/ibus/ && $(SCONS) install [...]
>
> Instead of doing a cd, you could use the -C flag of scons, which seems
> to works the same way as GNU make does:
>
> $(SCONS) -C wrapper/ibus install
>
> That is truth for 3 of your targets: clean, build and install. Please
> modify as I said.
fixed

>
> 2/ There's still no LGPL-2.1 copyright notice in your debian/copyright.
> Please, I'm spending time checking your package, it's quite annoying me
> if I have to check for things that I told you already. So take care of
> that one in your next upload to mentors. FTP-Masters hate me already
> because I did bad work previously, if this happens again, I might loose
> my upload rights. If this happens because you didn't take care of what I
> told you previously, I'll remember you all my life... So I say it again
> nicely a last time: please add a copyright notice for ALL the licenses
> that your packages are using.
It's my mistake, I've forgot to sync debian/copyright files with sunpinyin.
and now, license part of debian/copyright of sunpinyin and ibus-sunpinyin
are same.

> 3/ All of the package are using LGPL-2.1 AND CCDL, but not your debian/*
> files, so you are adding some restrictions. While this is perfectly fine
> and legal, most of the time, the debian/* content would be at least as
> permissive as the rest of the package, not less. Is it really what you
> want to do?
I've changed to use LGPL-2.1 or CDDL

>
> 4/ Still in your debian/copyright, I can see:
>
> Files: *
> Copyright: 2007, Sun Microsystems, Inc.
>
> This is wrong because you should write:
>
> Copyright: (c) 2007, Sun Microsystems, Inc.
I've added (c) to  debian/copyright in three packages, but I think it is not
forcible, please see http://dep.debian.net/deps/dep5/

>
> to make it legal. Also, I really think that 2007 isn't the only date, as
> Kov Chai has been working on it in this year of 2010, and he isn't even
> listed there. Writing "Upstream author" is very different from
> "Copyright". Here, is Sun Microsystems the copyright holder of the work
> of Kov Chai? Is Kov Chai working for or having a contract with them?
> This doesn't seem right to me... Also, apart from the license files,
> there's only the "wrapper" folder that contains only the work from Kov
> Chai. Are you sure that your debian/copyright is correct?
>

Hi, Kov,  would you like to explain this and double check the copyright
information in these package ?

> Let me know what you think of all the above,
>
> Thomas
>
I've uploaded these package to mentors.d.n, would you like to review again ?

dget http://mentors.debian.net/debian/pool/main/s/sunpinyin/sunpinyin_2.0.2-1.dsc
dget http://mentors.debian.net/debian/pool/main/o/open-gram/open-gram_0.1.22-1.dsc
dget http://mentors.debian.net/debian/pool/main/i/ibus-sunpinyin/ibus-sunpinyin_2.0.2-1.dsc

Regards and Thanks,
-- 
Liang Guo
http://bluestone.cublog.cn