[Pkg-iscsi-maintainers] Bug#665966: /etc/init.d/open-iscsi stop does not kill all iscsid processes

[Gwendal Grignou]

Package: open-iscsi
Version: 2.0.872-2
Severity: normal
Tags: patch

open-iscsi stop script does not kill all iscsid processes:
when starting, iscisd is forking in 2 process, one for management, the other
for logging [child].
Because in the stop function, we invoke start-stop-daemon with the KILL option,
only the parent is killed. Using TERM option kills both.



diff -u src.orig/debian/open-iscsi.init src/debian/open-iscsi.init
--- src.orig/debian/open-iscsi.init	2012-03-15 12:14:11.000000000 +0800
+++ src/debian/open-iscsi.init	2012-03-23 16:19:05.000000000 +0800
@@ -164,7 +164,7 @@
 
 	stoptargets
 	log_daemon_msg "Stopping iSCSI initiator service"
-	start-stop-daemon --stop --quiet --pidfile $PIDFILE --signal KILL --exec $DAEMON
+	start-stop-daemon --stop --quiet --pidfile $PIDFILE --signal TERM --exec $DAEMON
 	rm -f $PIDFILE
 	modprobe -r ib_iser 2>/dev/null
 	modprobe -r iscsi_tcp 2>/dev/null