[Pkg-iscsi-maintainers] Bug#809334: Bug#809334: Bug#809320: open-iscsi: no session termination on stop
Ritesh Raj Sarraf
rrs at debian.org
Sun Feb 7 10:56:52 UTC 2016
On Sun, 2016-02-07 at 11:39 +0100, Christian Seiler wrote:
> That's not so great.
> I looked at the source code of logout-all.sh again found
> the mistake: when reading in /run/o-i/s-k-s, it would just use
> XXX=$(cat /run/o-i/s-k-s)
> But to then check whether a session was excluded, it would use
> the in_set code also used in umountiscsi.sh. Problem with that
> code is that it expects whitespaces as separators for the values,
> while reading in the file will have newlines as terminators.
> I've pushed a fix to git. I don't have a test setup that uses
> multiple sessions (but I tested the functionality in a separate
> shell script), so you should definitely test it - but it doesn't
> break for single sessions at least, which I could test here.
And here, my sanboot setup with multiple sessions is working fine with
your fix now.
> Could you therefore please test the current git master on alioth?
Done. and it works perfect now. Thanks.
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 801 bytes
Desc: This is a digitally signed message part
More information about the Pkg-iscsi-maintainers