[Pkg-iscsi-maintainers] Bug#809334: Bug#809334: Bug#809320: open-iscsi: no session termination on stop

[Christian Seiler]

Control: tags -1 + pending

On 02/07/2016 11:56 AM, Ritesh Raj Sarraf wrote:
> On Sun, 2016-02-07 at 11:39 +0100, Christian Seiler wrote:
>> That's not so great.
>>
>> I looked at the source code of logout-all.sh again found
>> the mistake: when reading in /run/o-i/s-k-s, it would just use
>> XXX=$(cat /run/o-i/s-k-s)
>> But to then check whether a session was excluded, it would use
>> the in_set code also used in umountiscsi.sh. Problem with that
>> code is that it expects whitespaces as separators for the values,
>> while reading in the file will have newlines as terminators.
>>
> 
> 
>> I've pushed a fix to git. I don't have a test setup that uses
>> multiple sessions (but I tested the functionality in a separate
>> shell script), so you should definitely test it - but it doesn't
>> break for single sessions at least, which I could test here.
>>
> 
> And here, my sanboot setup with multiple sessions is working fine with
> your fix now.

Fantastic. :-)

Regards,
Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20160207/ab37eb54/attachment-0001.sig>