[Dict-common-dev] UTF-8 and ispell

Agustin Martin agustin.martin at hispalinux.es
Fri Sep 28 14:22:45 UTC 2007


Hi, Rafael

On Thu, Sep 27, 2007 at 10:24:24AM +0200, Rafael Laboissiere wrote:
> [Cc: to the pkg-jed-devel and dict-common-dev mailing lists]
> 
> Hi Paul,
> 
> Thanks for the patch, it took faster than I thought to adapt
> dictionaries-common for the new ispell.sl with improved aspell and UTF-8
> support.  I am attaching below the patch that I in fact applied to jed-extra
> 2.4. Notice that I have made aspell the default program, instead of ispell.
> 
> I have changed the dictionaries-common package to generate the necessary
> calls to aspell_add_dictionary in jed-ispell-dicts.sl file.  I am attaching
> below this file as it is generated in my system.  Note that the appropriate
> strings are wrapped around "if (_slang_utf8_ok) {...} else {...}".  I did
> not implemented the \x{...} encoding as you suggested.  This would
> complicate DictonariesCommon without necessity.
> 
> The changed dictionaries-common package is available in my private
> apt-getable repository [1], just in case someone wants to try it.
> 
> Now, we have to make a plan to release this to Debian.  The first step would
> be to integrate the new ispell.sl in jed-extra, either by making a new
> upstream release of jedmodes or simply by integrating the patch. The second
> step will be to release the new dictionaries-common package [Agustín: please
> review my patch to the dictionaries-common package attached below; it
> applies against the CVS sources as two days ago].  It has to be done in this
> order, otherwise jed will fail when loading jed-ispell-dicts.sl.

This means we need a versioned conflict on jed-extra in dictionaries-common.
Another possibility is try adding a fake definition for the aspell adding
function in case is not defined, but I do not know if this is possible and
is probably an overkill. What do you think is better?

I have been looking at the code and seems OK. However, when testing the
resulting file I noticed that bulgarian aspell dict uses \xxx octal chars
which are not translated.

> +dictionaries-common (0.85.2.1) UNRELEASED; urgency=low
...
> +  * debian.control: Build-Depends on libtext-iconv-perl (needed by
> +    build_jed_support in DictionariesCommon.pm)

Does dictionaries-common really need a Build-Depends on libtext-iconv-perl
or it is just a Depends what is needed. Furthermore, libtext-iconv-perl is
currently a required package, so that dependency seems not needed unless put
there only to make this useable under older releases.

> RCS file: /cvsroot/dict-common/dictionaries-common/debian/control,v
> +Build-Depends-Indep: docbook-xml, docbook-dsssl, jade, links, slice,
> + autoconf, recode, libtext-iconv-perl

Thanks for reformatting this to multiline, is much simpler to read. I will
also reformat this way the huge conflicts line.

-- 
Agustin



More information about the Pkg-jed-devel mailing list