Accepted john 1.6-28 (i386 source)

[Javier Fernández-Sanguino Peña]

--tThc/1wpZn/ma/RB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Guilherme,

Just wondering, is there any reason why you did not include my full=20
changelog entries in this new upload? I'm missing some of the changes I=20
made to the cronjob (and included in CVS). It's like if you had a conflict=
=20
in your CVS upload and removed those, check out:
http://cvs.alioth.debian.org/cgi-bin/cvsweb.cgi/john/debian/changelog.diff?=
r1=3D1.31&r2=3D1.32&cvsroot=3Dpkg-john

You actually also removed some of the changes, list the postrm ones:
http://cvs.alioth.debian.org/cgi-bin/cvsweb.cgi/john/debian/postrm.diff?r1=
=3D1.3&r2=3D1.4&cvsroot=3Dpkg-john

Since you have moved the conffiles to /etc/john you should have modified=20
the postrm code to remove the conffiles from there (as well as /var/run)

Finally, I believe that you don't handle the transition for conffiles under
/etc properly. I believe that the consensus on handling config files [1]
would be copying them over in preinst (from /etc/john.conf to
/etc/john/john.conf) plus other actions in postinst. The following code
(current John's preinst) does not look proper:

    if [ -e "/etc/john/john.conf" ]; then
        mv /etc/john/john.conf /etc/john/john.conf.old
    fi

Shouldn't it have been

    if [ -e "/etc/john.conf" ]; then
        cp /etc/john.ini /etc/john/john.conf
    fi

?

In any case, let's see how this package does... hopefully we will see if=20
the generic build target being used by all autobuilder in a few days and,=
=20
hopefully, the sparc buld will succeed

Regards

Javier

[1] http://lists.debian.org/debian-devel/2003/01/msg01213.html

--tThc/1wpZn/ma/RB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD4DBQFA8yRXi4sehJTrj0oRAlh0AJUWB2fP/d4R0hneg6jkOmO+0rttAJ9Qr3x8
akdY3h6+eu077BQKj96S0g==
=0T14
-----END PGP SIGNATURE-----

--tThc/1wpZn/ma/RB--