Accepted john 1.6-28 (i386 source)

[Javier Fernández-Sanguino Peña]

--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 13, 2004 at 01:52:55AM +0200, Javier Fern=E1ndez-Sanguino Pe=F1=
a wrote:
> Finally, I believe that you don't handle the transition for conffiles und=
er
> /etc properly. I believe that the consensus on handling config files [1]
> would be copying them over in preinst (from /etc/john.conf to

Hate to reply myself, but it seems you have done this in postinst. Is that=
=20
the correct place to do it?

In any case, with this config file move, which I suggested you not to do=20
:-) you have broken a number of things under extra/ included:

- the cronjob
- the mailer program
- the template check (if john.ini is missing), and when this is changed all=
=20
the translated templates will need to change too
- all the documentation (manpages et al) as well as some of the comments in=
=20
the config files themselves

You should have reviewed this package more carefully before doing the=20
upload, expect quite a lot of bug reports related to this change :-(

Regards

Javier

--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA8ygTi4sehJTrj0oRApwbAKCMdEj0PS4D3c3n/fkk7qIb1PYsnwCeIJpH
l/ZoVAp9+Za2rfAe5ZCLsQw=
=Z2+/
-----END PGP SIGNATURE-----

--yNb1oOkm5a9FJOVX--