Accepted john 1.6-28 (i386 source)

[Guilherme de S. Pastore]

Em Tue, 13 Jul 2004 02:08:51 +0200,
"Javier Fernández-Sanguino Peña" <jfs@computer.org> escreveu:

> On Tue, Jul 13, 2004 at 01:52:55AM +0200, Javier Fernández-Sanguino Peña wrote:
> > Finally, I believe that you don't handle the transition for conffiles under
> > /etc properly. I believe that the consensus on handling config files [1]
> > would be copying them over in preinst (from /etc/john.conf to
> 

They're simply not copied, they're moved. And in the preinst I just make
sure to move a file the user might have put in the way out of the way.

The transition is handled perfectly.

> Hate to reply myself, but it seems you have done this in postinst. Is that 
> the correct place to do it?
> 
> In any case, with this config file move, which I suggested you not to do 
> :-) you have broken a number of things under extra/ included:
> 
> - the cronjob

Fixed.

> - the mailer program

Fixed.

> - the template check (if john.ini is missing), and when this is changed all 
> the translated templates will need to change too

Fixed.

> - all the documentation (manpages et al) as well as some of the comments in 
> the config files themselves
> 

I had already fixed them. Check out.

> You should have reviewed this package more carefully before doing the 
> upload, expect quite a lot of bug reports related to this change :-(

There are quite a number of problems in the version in experimental,
please take a look at the recent bug report and get some changes from
unstable to there.
 
> Regards
> 
> Javier
> 

-- 
Guilherme de S. Pastore (fatalerror)
<gpastore@colband.com.br>