[SCM] ci-tooling packaging branch, master, updated. 406fe619eec7efd5f55d059e5f6764e17a621cf3

[Harald Sitter]

Gitweb-URL: http://git.debian.org/?p=pkg-kde/ci-tooling.git;a=commitdiff;h=406fe61

The following commit has been merged in the master branch:
commit 406fe619eec7efd5f55d059e5f6764e17a621cf3
Author: Harald Sitter <sitter at kde.org>
Date:   Mon Nov 30 12:17:08 2015 +0100

    document why we have an incredibly terrible hostcmd param
---
 lib/projects.rb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/projects.rb b/lib/projects.rb
index 005fec1..2bafc44 100644
--- a/lib/projects.rb
+++ b/lib/projects.rb
@@ -144,6 +144,12 @@ end
 # @private
 class ProjectFactory
   def self.find_all_repos(searchpath, hostcmd: 'ssh git.debian.org')
+    # This uses a command argument so we can test this in a way that bypasses
+    # ssh entirely. Otherwise the test would require a working SSH setup.
+    # Should this become a problem in the future we need a way to somehow force
+    # A different command. e.g. invidual classes SSHListing LocalListing
+    # where former probably derives from latter as to get very close testing
+    # coverage.
     output = `#{hostcmd} find #{searchpath} -maxdepth 1 -type d`
     fail 'Failed to find repo list on host' unless $? == 0
     output.chop.split(' ')

-- 
ci-tooling packaging