[SCM] ktp-common-internals packaging branch, master, updated. debian/15.12.1-2-1839-gf0635e9

Maximiliano Curia maxy at moszumanska.debian.org
Mon May 9 09:04:32 UTC 2016


Gitweb-URL: http://git.debian.org/?p=pkg-kde/applications/ktp-common-internals.git;a=commitdiff;h=eddc8ea

The following commit has been merged in the master branch:
commit eddc8ea4e0723e09c80c1bb8df500ea0b4034192
Author: Martin Klapetek <martin.klapetek at gmail.com>
Date:   Mon Jun 20 19:40:25 2011 +0200

    Prevent some crashes caused by array index being out of bounds
    
    Reviewed-by: David Edmundson
---
 models/accounts-model.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/models/accounts-model.cpp b/models/accounts-model.cpp
index e8867fc..383c933 100644
--- a/models/accounts-model.cpp
+++ b/models/accounts-model.cpp
@@ -265,7 +265,12 @@ bool AccountsModel::setData(const QModelIndex &index, const QVariant &value, int
 QModelIndex AccountsModel::index(int row, int column, const QModelIndex &parent) const
 {
     TreeNode *parentNode = mPriv->node(parent);
-    return createIndex(row, column, parentNode->childAt(row));
+    Q_ASSERT(parentNode);
+    if (row < parentNode->size()) {
+        return createIndex(row, column, parentNode->childAt(row));
+    }
+
+    return QModelIndex();
 }
 
 QModelIndex AccountsModel::index(TreeNode *node) const

-- 
ktp-common-internals packaging



More information about the pkg-kde-commits mailing list