[SCM] ktp-accounts-kcm packaging branch, master, updated. debian/15.12.1-1-1157-gc4589c5
Maximiliano Curia
maxy at moszumanska.debian.org
Fri May 27 23:57:50 UTC 2016
Gitweb-URL: http://git.debian.org/?p=pkg-kde/applications/ktp-accounts-kcm.git;a=commitdiff;h=da98167
The following commit has been merged in the master branch:
commit da98167ed318562de6c34344edbd0165e86c50d4
Author: George Goldberg <grundleborg at googlemail.com>
Date: Mon Aug 3 13:17:51 2009 +0000
Stick with a loop and deletelater() since qDeleteAll calls only delete, and I don't think this is good practice with widgets with signal/slot connections all over the place.
svn path=/trunk/playground/network/telepathy-accounts-kcm/; revision=1006307
---
src/add-account-assistant.cpp | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/add-account-assistant.cpp b/src/add-account-assistant.cpp
index 8c48f19..4e6e7f7 100644
--- a/src/add-account-assistant.cpp
+++ b/src/add-account-assistant.cpp
@@ -128,8 +128,11 @@ void AddAccountAssistant::next()
d->mandatoryParametersWidget = 0;
}
- // TODO: Check if this calls delete, or ->deleteLater() once I have internet access again :)
- qDeleteAll(d->optionalParametersWidgets);
+ foreach (AbstractAccountParametersWidget *w, d->optionalParametersWidgets) {
+ if (w) {
+ w->deleteLater();
+ }
+ }
d->optionalParametersWidgets.clear();
// Set up the Mandatory Parameters page
--
ktp-accounts-kcm packaging
More information about the pkg-kde-commits
mailing list