[SCM] kdeconnect packaging branch, master, updated. debian/0.9g-1-1183-g9d69498
Maximiliano Curia
maxy at moszumanska.debian.org
Fri Oct 14 14:28:38 UTC 2016
Gitweb-URL: http://git.debian.org/?p=pkg-kde/kde-extras/kdeconnect.git;a=commitdiff;h=c041026
The following commit has been merged in the master branch:
commit c041026317565b8501a8227563add8edb083482b
Author: Albert Vaca <albertvaka at gmail.com>
Date: Sun Jun 14 19:02:47 2015 -0700
Updated comment
---
plugins/notifications/notificationsplugin.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/plugins/notifications/notificationsplugin.cpp b/plugins/notifications/notificationsplugin.cpp
index b0d089c..badb5d3 100644
--- a/plugins/notifications/notificationsplugin.cpp
+++ b/plugins/notifications/notificationsplugin.cpp
@@ -46,9 +46,8 @@ NotificationsPlugin::~NotificationsPlugin()
{
//FIXME: Qt dbus does not allow to remove an adaptor! (it causes a crash in
// the next dbus access to its parent). The implication of not deleting this
- // is that disabling the plugin does not remove the interface (that will
- // return outdated values) and that enabling it again instantiates a second
- // adaptor.
+ // is that disabling the plugin leaks the interface. As a mitigation we are
+ // cleaning up the notifications inside the adaptor here.
//notificationsDbusInterface->deleteLater();
notificationsDbusInterface->clearNotifications();
}
--
kdeconnect packaging
More information about the pkg-kde-commits
mailing list