[SCM] kdeconnect packaging branch, master, updated. debian/0.9g-1-1183-g9d69498
Maximiliano Curia
maxy at moszumanska.debian.org
Fri Oct 14 14:28:53 UTC 2016
Gitweb-URL: http://git.debian.org/?p=pkg-kde/kde-extras/kdeconnect.git;a=commitdiff;h=1924173
The following commit has been merged in the master branch:
commit 1924173df206a03af8b119d62ff04dcb4cb629cf
Author: Boris Egorov <egorov at linux.com>
Date: Fri Aug 21 22:38:54 2015 +0600
Fix various krazy2 warnings
Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes], [normalize],
[postfixop], [spelling]
See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html
for details.
SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize
REVIEW: 124857
---
core/backends/lan/lanlinkprovider.cpp | 2 +-
core/backends/lan/socketlinereader.h | 2 +-
core/backends/lan/uploadjob.cpp | 3 +-
core/backends/lan/uploadjob.h | 2 +-
core/core_debug.h | 2 +-
core/daemon.cpp | 5 ++-
core/daemon.h | 2 +-
core/dbushelper.cpp | 2 +-
core/dbushelper.h | 2 +-
core/device.cpp | 4 +--
core/kdeconnectconfig.cpp | 3 +-
core/networkpackage.h | 2 +-
interfaces/dbusinterfaces.h | 16 +++++-----
interfaces/devicesmodel.cpp | 4 +--
interfaces/devicesmodel.h | 2 +-
interfaces/devicessortproxymodel.h | 2 +-
interfaces/interfaces_debug.h | 2 +-
interfaces/modeltest.cpp | 46 +++++++++++++--------------
interfaces/modeltest.h | 2 +-
interfaces/notificationsmodel.cpp | 6 ++--
interfaces/notificationsmodel.h | 2 +-
kio/kiokdeconnect.cpp | 4 +--
plasmoid/declarativeplugin/processrunner.h | 2 +-
plasmoid/declarativeplugin/responsewaiter.cpp | 3 +-
plasmoid/declarativeplugin/responsewaiter.h | 2 +-
plugins/mpriscontrol/mpriscontrolplugin.cpp | 2 +-
plugins/notifications/notification_debug.h | 2 +-
plugins/sftp/mounter.cpp | 2 +-
plugins/sftp/sftp_debug.h | 2 +-
plugins/share/autoclosingqfile.h | 2 +-
plugins/share/share_debug.h | 2 +-
31 files changed, 67 insertions(+), 69 deletions(-)
diff --git a/core/backends/lan/lanlinkprovider.cpp b/core/backends/lan/lanlinkprovider.cpp
index f5d2b22..2555668 100644
--- a/core/backends/lan/lanlinkprovider.cpp
+++ b/core/backends/lan/lanlinkprovider.cpp
@@ -223,7 +223,7 @@ void LanLinkProvider::newConnection()
configureSocket(socket);
//This socket is still managed by us (and child of the QTcpServer), if
//it disconnects before we manage to pass it to a LanDeviceLink, it's
- //our responsability to delete it. We do so with this connection.
+ //our responsibility to delete it. We do so with this connection.
connect(socket, SIGNAL(disconnected()),
socket, SLOT(deleteLater()));
connect(socket, SIGNAL(readyRead()),
diff --git a/core/backends/lan/socketlinereader.h b/core/backends/lan/socketlinereader.h
index b3be55a..29b059a 100644
--- a/core/backends/lan/socketlinereader.h
+++ b/core/backends/lan/socketlinereader.h
@@ -37,7 +37,7 @@ class SocketLineReader
Q_OBJECT
public:
- SocketLineReader(QTcpSocket* socket, QObject* parent = 0);
+ explicit SocketLineReader(QTcpSocket* socket, QObject* parent = 0);
QByteArray readLine() { return mPackages.dequeue(); }
qint64 write(const QByteArray& data) { return mSocket->write(data); }
diff --git a/core/backends/lan/uploadjob.cpp b/core/backends/lan/uploadjob.cpp
index b0d35fc..90978f2 100644
--- a/core/backends/lan/uploadjob.cpp
+++ b/core/backends/lan/uploadjob.cpp
@@ -18,10 +18,11 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
+#include "uploadjob.h"
+
#include <qalgorithms.h>
#include <QtGlobal>
-#include "uploadjob.h"
#include "core_debug.h"
UploadJob::UploadJob(const QSharedPointer<QIODevice>& source): KJob()
diff --git a/core/backends/lan/uploadjob.h b/core/backends/lan/uploadjob.h
index 12b6f7e..40056b3 100644
--- a/core/backends/lan/uploadjob.h
+++ b/core/backends/lan/uploadjob.h
@@ -34,7 +34,7 @@ class UploadJob
{
Q_OBJECT
public:
- UploadJob(const QSharedPointer<QIODevice>& source);
+ explicit UploadJob(const QSharedPointer<QIODevice>& source);
virtual void start();
QVariantMap getTransferInfo();
diff --git a/core/core_debug.h b/core/core_debug.h
index 33504de..93a0f1d 100644
--- a/core/core_debug.h
+++ b/core/core_debug.h
@@ -25,4 +25,4 @@
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_CORE)
-#endif //CORE_DEBUG_H
\ No newline at end of file
+#endif //CORE_DEBUG_H
diff --git a/core/daemon.cpp b/core/daemon.cpp
index af4c67b..cb6999e 100644
--- a/core/daemon.cpp
+++ b/core/daemon.cpp
@@ -31,7 +31,6 @@
#include "backends/lan/lanlinkprovider.h"
#include "backends/loopback/loopbacklinkprovider.h"
#include "device.h"
-#include "networkpackage.h"
#include "backends/devicelink.h"
#include "backends/linkprovider.h"
@@ -77,8 +76,8 @@ Daemon::Daemon(QObject *parent)
//Listen to new devices
Q_FOREACH (LinkProvider* a, d->mLinkProviders) {
- connect(a, SIGNAL(onConnectionReceived(NetworkPackage, DeviceLink*)),
- this, SLOT(onNewDeviceLink(NetworkPackage, DeviceLink*)));
+ connect(a, SIGNAL(onConnectionReceived(NetworkPackage,DeviceLink*)),
+ this, SLOT(onNewDeviceLink(NetworkPackage,DeviceLink*)));
}
setDiscoveryEnabled(true);
diff --git a/core/daemon.h b/core/daemon.h
index 674ca01..d263163 100644
--- a/core/daemon.h
+++ b/core/daemon.h
@@ -39,7 +39,7 @@ class KDECONNECTCORE_EXPORT Daemon
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.daemon")
public:
- Daemon(QObject *parent);
+ explicit Daemon(QObject *parent);
~Daemon();
public Q_SLOTS:
diff --git a/core/dbushelper.cpp b/core/dbushelper.cpp
index e188126..d1d24f4 100644
--- a/core/dbushelper.cpp
+++ b/core/dbushelper.cpp
@@ -30,4 +30,4 @@ void filterNonExportableCharacters(QString& s)
s.replace(regexp,"_");
}
-}
\ No newline at end of file
+}
diff --git a/core/dbushelper.h b/core/dbushelper.h
index 43b2286..b287a9f 100644
--- a/core/dbushelper.h
+++ b/core/dbushelper.h
@@ -26,4 +26,4 @@ namespace DbusHelper {
void filterNonExportableCharacters(QString& s);
}
-#endif
\ No newline at end of file
+#endif
diff --git a/core/device.cpp b/core/device.cpp
index c2dc609..d53b3c5 100644
--- a/core/device.cpp
+++ b/core/device.cpp
@@ -140,7 +140,7 @@ void Device::reloadPlugins()
//If we don't find intersection with the received on one end and the sent on the other, we don't
//let the plugin stay
//Also, if no capabilities are specified on the other end, we don't apply this optimizaton, as
- //we asume that the other client doesn't know about capabilities.
+ //we assume that the other client doesn't know about capabilities.
if (!m_incomingCapabilities.isEmpty() && !m_outgoingCapabilities.isEmpty()
&& (m_incomingCapabilities & outgoingInterfaces.toSet()).isEmpty()
&& (m_outgoingCapabilities & incomingInterfaces.toSet()).isEmpty()
@@ -512,7 +512,7 @@ QString Device::iconForStatus(bool reachable, bool paired) const
QString status = (reachable? (paired? QStringLiteral("connected") : QStringLiteral("disconnected")) : QStringLiteral("trusted"));
QString type = type2str(deviceType);
- return type+"-"+status;
+ return type+'-'+status;
}
void Device::setName(const QString &name)
diff --git a/core/kdeconnectconfig.cpp b/core/kdeconnectconfig.cpp
index 919505c..37f33d5 100644
--- a/core/kdeconnectconfig.cpp
+++ b/core/kdeconnectconfig.cpp
@@ -27,7 +27,6 @@
#include <QDebug>
#include <QFileInfo>
#include <QUuid>
-#include <QDebug>
#include <QDir>
#include <QStandardPaths>
#include <QCoreApplication>
@@ -114,7 +113,7 @@ KdeConnectConfig::KdeConnectConfig()
QString KdeConnectConfig::name()
{
- QString defaultName = qgetenv("USER") + "@" + QHostInfo::localHostName();
+ QString defaultName = qgetenv("USER") + '@' + QHostInfo::localHostName();
d->config->beginGroup("myself");
QString name = d->config->value("name", defaultName).toString();
d->config->endGroup();
diff --git a/core/networkpackage.h b/core/networkpackage.h
index 6a0bf9c..29549e5 100644
--- a/core/networkpackage.h
+++ b/core/networkpackage.h
@@ -52,7 +52,7 @@ public:
const static QCA::EncryptionAlgorithm EncryptionAlgorithm;
const static int ProtocolVersion;
- NetworkPackage(const QString& type);
+ explicit NetworkPackage(const QString& type);
static void createIdentityPackage(NetworkPackage*);
diff --git a/interfaces/dbusinterfaces.h b/interfaces/dbusinterfaces.h
index 2f51599..6d24d9b 100644
--- a/interfaces/dbusinterfaces.h
+++ b/interfaces/dbusinterfaces.h
@@ -42,7 +42,7 @@ class KDECONNECTINTERFACES_EXPORT DaemonDbusInterface
{
Q_OBJECT
public:
- DaemonDbusInterface(QObject* parent = 0);
+ explicit DaemonDbusInterface(QObject* parent = 0);
virtual ~DaemonDbusInterface();
static QString activatedService();
@@ -57,7 +57,7 @@ class KDECONNECTINTERFACES_EXPORT DeviceDbusInterface
Q_PROPERTY(bool isPaired READ isPaired NOTIFY pairingChangedProxy)
public:
- DeviceDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit DeviceDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~DeviceDbusInterface();
Q_SCRIPTABLE QString id() const;
@@ -75,7 +75,7 @@ class KDECONNECTINTERFACES_EXPORT DeviceBatteryDbusInterface
{
Q_OBJECT
public:
- DeviceBatteryDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit DeviceBatteryDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~DeviceBatteryDbusInterface();
};
@@ -84,7 +84,7 @@ class KDECONNECTINTERFACES_EXPORT DeviceNotificationsDbusInterface
{
Q_OBJECT
public:
- DeviceNotificationsDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit DeviceNotificationsDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~DeviceNotificationsDbusInterface();
};
@@ -102,7 +102,7 @@ class KDECONNECTINTERFACES_EXPORT SftpDbusInterface
{
Q_OBJECT
public:
- SftpDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit SftpDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~SftpDbusInterface();
};
@@ -119,7 +119,7 @@ class KDECONNECTINTERFACES_EXPORT MprisDbusInterface
Q_PROPERTY(int volume READ volume WRITE setVolume NOTIFY propertiesChangedProxy)
Q_PROPERTY(int position READ position WRITE setPosition NOTIFY propertiesChangedProxy)
public:
- MprisDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit MprisDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~MprisDbusInterface();
Q_SIGNALS:
@@ -131,7 +131,7 @@ class KDECONNECTINTERFACES_EXPORT RemoteControlDbusInterface
{
Q_OBJECT
public:
- RemoteControlDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit RemoteControlDbusInterface(const QString& deviceId, QObject* parent = 0);
~RemoteControlDbusInterface() override;
};
@@ -141,7 +141,7 @@ class KDECONNECTINTERFACES_EXPORT LockDeviceDbusInterface
Q_OBJECT
Q_PROPERTY(bool isLocked READ isLocked WRITE setIsLocked NOTIFY lockedChangedProxy)
public:
- LockDeviceDbusInterface(const QString& deviceId, QObject* parent = 0);
+ explicit LockDeviceDbusInterface(const QString& deviceId, QObject* parent = 0);
virtual ~LockDeviceDbusInterface();
Q_SIGNALS:
diff --git a/interfaces/devicesmodel.cpp b/interfaces/devicesmodel.cpp
index 11b56da..448343e 100644
--- a/interfaces/devicesmodel.cpp
+++ b/interfaces/devicesmodel.cpp
@@ -42,9 +42,9 @@ DevicesModel::DevicesModel(QObject *parent)
//new ModelTest(this, this);
- connect(this, SIGNAL(rowsRemoved(QModelIndex, int, int)),
+ connect(this, SIGNAL(rowsRemoved(QModelIndex,int,int)),
this, SIGNAL(rowsChanged()));
- connect(this, SIGNAL(rowsInserted(QModelIndex, int, int)),
+ connect(this, SIGNAL(rowsInserted(QModelIndex,int,int)),
this, SIGNAL(rowsChanged()));
connect(m_dbusInterface, SIGNAL(deviceAdded(QString)),
diff --git a/interfaces/devicesmodel.h b/interfaces/devicesmodel.h
index e96af81..6253025 100644
--- a/interfaces/devicesmodel.h
+++ b/interfaces/devicesmodel.h
@@ -57,7 +57,7 @@ public:
Q_FLAGS(StatusFilterFlags)
Q_ENUMS(StatusFilterFlag)
- DevicesModel(QObject *parent = 0);
+ explicit DevicesModel(QObject *parent = 0);
virtual ~DevicesModel();
void setDisplayFilter(int flags);
diff --git a/interfaces/devicessortproxymodel.h b/interfaces/devicessortproxymodel.h
index 54b7a0b..126112f 100644
--- a/interfaces/devicessortproxymodel.h
+++ b/interfaces/devicessortproxymodel.h
@@ -30,7 +30,7 @@ class KDECONNECTINTERFACES_EXPORT DevicesSortProxyModel : public QSortFilterProx
{
Q_OBJECT
public:
- DevicesSortProxyModel(DevicesModel* devicesModel = Q_NULLPTR);
+ explicit DevicesSortProxyModel(DevicesModel* devicesModel = Q_NULLPTR);
virtual bool lessThan(const QModelIndex& left, const QModelIndex& right) const;
virtual bool filterAcceptsRow(int source_row, const QModelIndex& source_parent) const;
virtual void setSourceModel(QAbstractItemModel *sourceModel);
diff --git a/interfaces/interfaces_debug.h b/interfaces/interfaces_debug.h
index 5083239..95e05f1 100644
--- a/interfaces/interfaces_debug.h
+++ b/interfaces/interfaces_debug.h
@@ -25,4 +25,4 @@
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_INTERFACES)
-#endif //KDECONNECT_INTERFACE_DEBUG_H
\ No newline at end of file
+#endif //KDECONNECT_INTERFACE_DEBUG_H
diff --git a/interfaces/modeltest.cpp b/interfaces/modeltest.cpp
index 9259487..3305bf1 100644
--- a/interfaces/modeltest.cpp
+++ b/interfaces/modeltest.cpp
@@ -21,10 +21,10 @@
**
****************************************************************************/
-#include <QtGui/QtGui>
-
#include "modeltest.h"
+#include <QtGui/QtGui>
+
Q_DECLARE_METATYPE(QModelIndex)
/*!
@@ -34,28 +34,28 @@ ModelTest::ModelTest(QAbstractItemModel *_model, QObject *parent) : QObject(pare
{
Q_ASSERT(model);
- connect(model, SIGNAL(columnsAboutToBeInserted(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(columnsAboutToBeInserted(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(columnsAboutToBeRemoved(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(columnsAboutToBeRemoved(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(columnsInserted(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(columnsInserted(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(columnsRemoved(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(columnsRemoved(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(dataChanged(const QModelIndex &, const QModelIndex &)),
+ connect(model, SIGNAL(dataChanged(QModelIndex,QModelIndex)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(headerDataChanged(Qt::Orientation, int, int)),
+ connect(model, SIGNAL(headerDataChanged(Qt::Orientation,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(layoutAboutToBeChanged ()), this, SLOT(runAllTests()));
- connect(model, SIGNAL(layoutChanged ()), this, SLOT(runAllTests()));
- connect(model, SIGNAL(modelReset ()), this, SLOT(runAllTests()));
- connect(model, SIGNAL(rowsAboutToBeInserted(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(layoutAboutToBeChanged()), this, SLOT(runAllTests()));
+ connect(model, SIGNAL(layoutChanged()), this, SLOT(runAllTests()));
+ connect(model, SIGNAL(modelReset()), this, SLOT(runAllTests()));
+ connect(model, SIGNAL(rowsAboutToBeInserted(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(rowsAboutToBeRemoved(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(rowsAboutToBeRemoved(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(rowsInserted(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(rowsInserted(QModelIndex,int,int)),
this, SLOT(runAllTests()));
- connect(model, SIGNAL(rowsRemoved(const QModelIndex &, int, int)),
+ connect(model, SIGNAL(rowsRemoved(QModelIndex,int,int)),
this, SLOT(runAllTests()));
// Special checks for inserting/removing
@@ -64,14 +64,14 @@ ModelTest::ModelTest(QAbstractItemModel *_model, QObject *parent) : QObject(pare
connect(model, SIGNAL(layoutChanged()),
this, SLOT(layoutChanged()));
- connect(model, SIGNAL(rowsAboutToBeInserted(const QModelIndex &, int, int)),
- this, SLOT(rowsAboutToBeInserted(const QModelIndex &, int, int)));
- connect(model, SIGNAL(rowsAboutToBeRemoved(const QModelIndex &, int, int)),
- this, SLOT(rowsAboutToBeRemoved(const QModelIndex &, int, int)));
- connect(model, SIGNAL(rowsInserted(const QModelIndex &, int, int)),
- this, SLOT(rowsInserted(const QModelIndex &, int, int)));
- connect(model, SIGNAL(rowsRemoved(const QModelIndex &, int, int)),
- this, SLOT(rowsRemoved(const QModelIndex &, int, int)));
+ connect(model, SIGNAL(rowsAboutToBeInserted(QModelIndex,int,int)),
+ this, SLOT(rowsAboutToBeInserted(QModelIndex,int,int)));
+ connect(model, SIGNAL(rowsAboutToBeRemoved(QModelIndex,int,int)),
+ this, SLOT(rowsAboutToBeRemoved(QModelIndex,int,int)));
+ connect(model, SIGNAL(rowsInserted(QModelIndex,int,int)),
+ this, SLOT(rowsInserted(QModelIndex,int,int)));
+ connect(model, SIGNAL(rowsRemoved(QModelIndex,int,int)),
+ this, SLOT(rowsRemoved(QModelIndex,int,int)));
runAllTests();
}
diff --git a/interfaces/modeltest.h b/interfaces/modeltest.h
index 38b6b2b..80a294b 100644
--- a/interfaces/modeltest.h
+++ b/interfaces/modeltest.h
@@ -33,7 +33,7 @@ class ModelTest : public QObject
Q_OBJECT
public:
- ModelTest(QAbstractItemModel *model, QObject *parent = 0);
+ explicit ModelTest(QAbstractItemModel *model, QObject *parent = 0);
private Q_SLOTS:
void nonDestructiveBasicTest();
diff --git a/interfaces/notificationsmodel.cpp b/interfaces/notificationsmodel.cpp
index aba4573..7545021 100644
--- a/interfaces/notificationsmodel.cpp
+++ b/interfaces/notificationsmodel.cpp
@@ -37,12 +37,12 @@ NotificationsModel::NotificationsModel(QObject* parent)
//new ModelTest(this, this);
- connect(this, SIGNAL(rowsInserted(QModelIndex, int, int)),
+ connect(this, SIGNAL(rowsInserted(QModelIndex,int,int)),
this, SIGNAL(rowsChanged()));
- connect(this, SIGNAL(rowsRemoved(QModelIndex, int, int)),
+ connect(this, SIGNAL(rowsRemoved(QModelIndex,int,int)),
this, SIGNAL(rowsChanged()));
- connect(this, SIGNAL(dataChanged(QModelIndex, QModelIndex)),
+ connect(this, SIGNAL(dataChanged(QModelIndex,QModelIndex)),
this, SIGNAL(anyDismissableChanged()));
diff --git a/interfaces/notificationsmodel.h b/interfaces/notificationsmodel.h
index c54ef65..a4ec4f3 100644
--- a/interfaces/notificationsmodel.h
+++ b/interfaces/notificationsmodel.h
@@ -47,7 +47,7 @@ public:
DbusInterfaceRole,
};
- NotificationsModel(QObject* parent = 0);
+ explicit NotificationsModel(QObject* parent = 0);
virtual ~NotificationsModel();
QString deviceId() const;
diff --git a/kio/kiokdeconnect.cpp b/kio/kiokdeconnect.cpp
index 0ac875d..f069abc 100644
--- a/kio/kiokdeconnect.cpp
+++ b/kio/kiokdeconnect.cpp
@@ -143,7 +143,7 @@ void KioKdeconnect::listDevice()
QVariantMap urls = urlreply.value();
- for (QVariantMap::iterator it = urls.begin(); it != urls.end(); it++) {
+ for (QVariantMap::iterator it = urls.begin(); it != urls.end(); ++it) {
QString path = it.key();
QString name = it.value().toString();
@@ -170,7 +170,7 @@ void KioKdeconnect::listDir(const QUrl &url)
{
qCDebug(KDECONNECT_KIO) << "Listing..." << url;
- /// Url is not used here becuase all we could care about the url is the host, and that's already
+ /// Url is not used here because all we could care about the url is the host, and that's already
/// handled in @p setHost
Q_UNUSED(url);
diff --git a/plasmoid/declarativeplugin/processrunner.h b/plasmoid/declarativeplugin/processrunner.h
index 20e86e6..ff314a1 100644
--- a/plasmoid/declarativeplugin/processrunner.h
+++ b/plasmoid/declarativeplugin/processrunner.h
@@ -27,7 +27,7 @@ class ProcessRunner : public QObject
Q_OBJECT
public:
- ProcessRunner(QObject *parent = 0);
+ explicit ProcessRunner(QObject *parent = 0);
~ProcessRunner();
Q_INVOKABLE void runKdeconnectKCM();
diff --git a/plasmoid/declarativeplugin/responsewaiter.cpp b/plasmoid/declarativeplugin/responsewaiter.cpp
index e909842..79892cb 100644
--- a/plasmoid/declarativeplugin/responsewaiter.cpp
+++ b/plasmoid/declarativeplugin/responsewaiter.cpp
@@ -1,11 +1,10 @@
+#include "responsewaiter.h"
#include <QDBusPendingCall>
#include <QDBusPendingReply>
#include <QDebug>
#include <QCoreApplication>
-#include "responsewaiter.h"
-
Q_DECLARE_METATYPE(QDBusPendingReply<>)
Q_DECLARE_METATYPE(QDBusPendingReply<QVariant>)
Q_DECLARE_METATYPE(QDBusPendingReply<bool>)
diff --git a/plasmoid/declarativeplugin/responsewaiter.h b/plasmoid/declarativeplugin/responsewaiter.h
index a2aec19..365e935 100644
--- a/plasmoid/declarativeplugin/responsewaiter.h
+++ b/plasmoid/declarativeplugin/responsewaiter.h
@@ -36,7 +36,7 @@ class DBusAsyncResponse : public QObject
Q_PROPERTY(bool autoDelete READ autodelete WRITE setAutodelete)
public:
- DBusAsyncResponse(QObject* parent = 0);
+ explicit DBusAsyncResponse(QObject* parent = 0);
virtual ~DBusAsyncResponse() {};
Q_INVOKABLE void setPendingCall(QVariant e);
diff --git a/plugins/mpriscontrol/mpriscontrolplugin.cpp b/plugins/mpriscontrol/mpriscontrolplugin.cpp
index 8318217..e543e7a 100644
--- a/plugins/mpriscontrol/mpriscontrolplugin.cpp
+++ b/plugins/mpriscontrol/mpriscontrolplugin.cpp
@@ -67,7 +67,7 @@ void MprisControlPlugin::addPlayer(const QString& service)
sendPlayerList();
OrgFreedesktopDBusPropertiesInterface* freedesktopInterface = new OrgFreedesktopDBusPropertiesInterface(service, "/org/mpris/MediaPlayer2", QDBusConnection::sessionBus(), this);
- connect(freedesktopInterface, SIGNAL(PropertiesChanged(QString, QVariantMap, QStringList)), this, SLOT(propertiesChanged(QString, QVariantMap)));
+ connect(freedesktopInterface, SIGNAL(PropertiesChanged(QString,QVariantMap,QStringList)), this, SLOT(propertiesChanged(QString,QVariantMap)));
OrgMprisMediaPlayer2PlayerInterface* mprisInterface0 = new OrgMprisMediaPlayer2PlayerInterface(service, "/org/mpris/MediaPlayer2", QDBusConnection::sessionBus());
connect(mprisInterface0, SIGNAL(Seeked(qlonglong)), this, SLOT(seeked(qlonglong)));
diff --git a/plugins/notifications/notification_debug.h b/plugins/notifications/notification_debug.h
index 09da52f..febca38 100644
--- a/plugins/notifications/notification_debug.h
+++ b/plugins/notifications/notification_debug.h
@@ -25,4 +25,4 @@
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_NOTIFICATION)
-#endif //NOTIFICATION_DEBUG_H
\ No newline at end of file
+#endif //NOTIFICATION_DEBUG_H
diff --git a/plugins/sftp/mounter.cpp b/plugins/sftp/mounter.cpp
index 916b102..a9c39f6 100644
--- a/plugins/sftp/mounter.cpp
+++ b/plugins/sftp/mounter.cpp
@@ -107,7 +107,7 @@ void Mounter::onPakcageReceived(const NetworkPackage& np)
const QString program = "sshfs";
QString path;
- if (np.has("multiPaths")) path = "/";
+ if (np.has("multiPaths")) path = '/';
else path = np.get<QString>("path");
const QStringList arguments = QStringList()
diff --git a/plugins/sftp/sftp_debug.h b/plugins/sftp/sftp_debug.h
index 30da8f8..b572494 100644
--- a/plugins/sftp/sftp_debug.h
+++ b/plugins/sftp/sftp_debug.h
@@ -25,4 +25,4 @@
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_SFTP)
-#endif //SFTP_DEBUG_H
\ No newline at end of file
+#endif //SFTP_DEBUG_H
diff --git a/plugins/share/autoclosingqfile.h b/plugins/share/autoclosingqfile.h
index bea1ea1..19f4fed 100644
--- a/plugins/share/autoclosingqfile.h
+++ b/plugins/share/autoclosingqfile.h
@@ -28,7 +28,7 @@ class AutoClosingQFile : public QFile
Q_OBJECT
public:
- AutoClosingQFile(const QString &name);
+ explicit AutoClosingQFile(const QString &name);
qint64 readData(char* data, qint64 maxlen) Q_DECL_OVERRIDE {
qint64 read = QFile::readData(data, maxlen);
if (read == -1 || read == bytesAvailable()) {
diff --git a/plugins/share/share_debug.h b/plugins/share/share_debug.h
index d6cf416..92e7b15 100644
--- a/plugins/share/share_debug.h
+++ b/plugins/share/share_debug.h
@@ -25,4 +25,4 @@
Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_SHARE)
-#endif //SHARE_DEBUG_H
\ No newline at end of file
+#endif //SHARE_DEBUG_H
--
kdeconnect packaging
More information about the pkg-kde-commits
mailing list