[pkg-kolab] Review libkolab 0.6.0

Diane Trout diane at ghic.org
Sat Feb 14 06:22:15 UTC 2015

Awesome. Thank you.

Most of the updates look reasonable. Though in the 
postinst/postrm/preinst/prerm scripts duplicicating the various blocks to 
configure the dummy module workaround seems a bit unclean.

Especially the big blocks in php-kolab.postinst and php-kolab.postrm.

For the postinst script I wrote a version where the initialization code is 
abstracted as a function. 

What do you think?


On Saturday, February 14, 2015 03:18:21 Sandro Knauß wrote:
> Hey,
> I now started also with work for libkolab [1].
> One big change in all post/pre scripts all these changes are related to that
> kolab bug [2]. I have no knowlege about these pre/post scripts - I only
> copied them so far.
> All other changes are documented in the changelog.
> one open issue is to update symbols for gcc5. But i want to seperate the
> changes for the upgrade and the changes for gcc5 for review.
> Regads,
> sandro
> --
> [1] https://mentors.debian.net/package/libkolab
> (be aware that you get the newest one - timestamp: 2015-02-14 02:04)
> [2] https://issues.kolab.org/show_bug.cgi?id=2050
-------------- next part --------------
A non-text attachment was scrubbed...
Name: php-kolab.postinst
Type: application/x-shellscript
Size: 1222 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-kolab-devel/attachments/20150213/d3a3849a/attachment.bin>

More information about the pkg-kolab-devel mailing list