[pkg-kolab] Review libkolab 0.6.0

Sandro Knauß bugs at sandroknauss.de
Sat Feb 14 13:50:01 UTC 2015


Hey,

I rewrote the scripts clean them up and move things to other places (priority 
management see phpenmod code -> /usr/share/php5/php5-helper). If someone knows 
good dash - please look to the $@ replacement - this is a tricky one.

Regards,

sandro

[1] https://mentors.debian.net/package/libkolab
(be aware that you get the newest one - timestamp: 2015-02-14 13:32)

--
> Most of the updates look reasonable. Though in the
> postinst/postrm/preinst/prerm scripts duplicicating the various blocks to
> configure the dummy module workaround seems a bit unclean.
> 
> Especially the big blocks in php-kolab.postinst and php-kolab.postrm.
> 
> For the postinst script I wrote a version where the initialization code is
> abstracted as a function.
> 
> What do you think?
> 
> Diane




More information about the pkg-kolab-devel mailing list