[pkg-kolab] Review libkolab 0.6.0

[Sandro Knauß]

Hey,

> Did you try building libkolab in a clean chroot? (cowbuilder or sbuild or
> something similar?)

well i didn't build the last changes, 'cause I thought, they are harmless in 
sense of building - Normally I build with sbuild.

> I ran into a build problem with libkolab-0.6.0. In override_dh_install
> there's a sed call to alter /usr/share/php5/kolab/kolabformat.ini.

Ah i now i checked - kolabformat is part of libkolabxml. Well changing files 
of another package sounds really wired... Is there a clean way to do such 
things?

sandro

--
> On Saturday, February 14, 2015 14:50:01 Sandro Knauß wrote:
> > Hey,
> > 
> > I rewrote the scripts clean them up and move things to other places
> > (priority management see phpenmod code -> /usr/share/php5/php5-helper). If
> > someone knows good dash - please look to the $@ replacement - this is a
> > tricky one.
> > 
> > Regards,
> > 
> > sandro
> > 
> > [1] https://mentors.debian.net/package/libkolab
> > (be aware that you get the newest one - timestamp: 2015-02-14 13:32)
> > 
> > --
> > 
> > > Most of the updates look reasonable. Though in the
> > > postinst/postrm/preinst/prerm scripts duplicicating the various blocks
> > > to
> > > configure the dummy module workaround seems a bit unclean.
> > > 
> > > Especially the big blocks in php-kolab.postinst and php-kolab.postrm.
> > > 
> > > For the postinst script I wrote a version where the initialization code
> > > is
> > > abstracted as a function.
> > > 
> > > What do you think?
> > > 
> > > Diane