[pkg-kolab] Review libkolab 0.6.0

[Diane Trout]

Sandro,

Did you try building libkolab in a clean chroot? (cowbuilder or sbuild or 
something similar?)

I ran into a build problem with libkolab-0.6.0. In override_dh_install there's 
a sed call to alter /usr/share/php5/kolab/kolabformat.ini.

Which doesn't exist yet the chroot. 

Should it only be in the php-kolabformat, postinst script or does the php-
kolab.postinst script need to do the check too?

Other than that the updates seem reasonable to me. 

Diane

On Saturday, February 14, 2015 14:50:01 Sandro Knauß wrote:
> Hey,
> 
> I rewrote the scripts clean them up and move things to other places
> (priority management see phpenmod code -> /usr/share/php5/php5-helper). If
> someone knows good dash - please look to the $@ replacement - this is a
> tricky one.
> 
> Regards,
> 
> sandro
> 
> [1] https://mentors.debian.net/package/libkolab
> (be aware that you get the newest one - timestamp: 2015-02-14 13:32)
> 
> --
> 
> > Most of the updates look reasonable. Though in the
> > postinst/postrm/preinst/prerm scripts duplicicating the various blocks to
> > configure the dummy module workaround seems a bit unclean.
> > 
> > Especially the big blocks in php-kolab.postinst and php-kolab.postrm.
> > 
> > For the postinst script I wrote a version where the initialization code is
> > abstracted as a function.
> > 
> > What do you think?
> > 
> > Diane