Bug#354000: madwifi-source: Should only recommend module-assistant

[Kel Modderman]

Julien Valroff wrote:

>As 2 build methods are clearly supported and explained in README.Debian, I think madwifi-source
>should only recommend module-assistant (and not depend).
>
>As an alternative, the package could depend on m-a OR kernel-package.
>
>Cheers,
>Julien
>
>  
>
This is wrong, and the recent upload with related changes was done in 
haste. Madwifi will fail to build without module-assistant (because it 
defines some debian/rules targets).

make[1]: Entering directory `/usr/src/modules/madwifi'
make[1]: *** No rule to make target `kdist_image'.  Stop.
make[1]: Leaving directory `/usr/src/modules/madwifi'
Module /usr/src/modules/madwifi failed.
Hit return to Continue

Even when some legacy code (kdist and kdist_image targets) is inserted 
into debian/rules.modules to try and remain compatible with 
kernel-package only, there are problems. Specifically, the package could 
be made to work with both kernel-package *or* module-assistant, but 
there would be conflicting debian/rules targets when *both* are installed.

IMHO, the best way to solve this is to drop any mention of 
kernel-package from the Depends field of debian/control, as 
module-assistant is sufficiently small enough to depend upon, and also 
has the benefit of allowing debian/rules to be clean and consise code.

I am going to revert the change in our svn working copy, and recommend 
kernel-package. The dependency on module-assistant must be a strict one, 
and it will remain that way so that the debian/rules.modules file can be 
maintained with the greatest of ease.

@ Loic, I suggest we make a semi-urgent upload of this, as the module 
build is clearly broken without strictly depending on module-assistant.

Thanks, Kel.