[Pkg-mc-devel] Bug#487611: Fixes for mcedit regexp replace

Michal Pokrywka mpokrywka at hoga.pl
Mon Jun 23 01:49:58 UTC 2008

Package: mc
Version: 4.6.2~git20080311-1
Severity: wishlist

Here is next round of patches fixing mcedit's regexp replace,
please include them in next version:

99a_fix-regex-bol-match.patch fixes matching beginning of line,
previously bol was matched at cursor after starting regexp replace.

99b_fix-regex-pattern-lengths.patch fixes subpattern byte offset
computation, previously mbstrlen function (which chokes on
nonprinting characters) was used and regex substrings that captured
for example tab characters were incorrectly truncated.

99c_fix-regex-newline-match.patch removes multiline matching -
make regexp less suprising because it is usually assumed that '.'
does not match newline. Function edit_find_string already splits
data on newlines before passing it to string_regexp_search,
so multiline matching is already crippled.

I also responded to bugreport http://bugs.debian.org/486676
with corrected patch for previous issues.

Michal Pokrywka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 99a_fix-regex-bol-match.patch
Type: text/x-patch
Size: 589 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mc-devel/attachments/20080623/aea3c466/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 99b_fix-regex-pattern-lengths.patch
Type: text/x-patch
Size: 1672 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mc-devel/attachments/20080623/aea3c466/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 99c_fix-regex-newline-match.patch
Type: text/x-patch
Size: 674 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mc-devel/attachments/20080623/aea3c466/attachment-0002.bin 

More information about the Pkg-mc-devel mailing list