[Pkg-mc-devel] Bug#607077: iso9660 extfs not recognizing joliet extension (short file names)
Vaclav Ovsik
vaclav.ovsik at gmail.com
Tue Dec 14 14:49:37 UTC 2010
Package: mc
Version: 3:4.7.0.9-1
Severity: minor
Tags: patch
Hi,
I noticed that mc lists content of iso file (SystemRescueCD) (Joliet but no RR)
without Joliet ext. MC from Lenny behaves correctly and lists long names from
Joliet. I found a problem in the mc shell script /usr/lib/mc/extfs.d/iso9660
after a while. There is used awk where grep should be used. Awk exit code
doesn't reflect if pattern is found or not. I'm surprised, why awk is
used there. Attached is a patch, that replaces awk with grep.
zito at bobek:/data/image$ /usr/lib/mc/extfs.d/iso9660.orig list systemrescuecd-x86-1.6.4.iso |grep -i zip
-r--r--r-- 1 root root 819988 Mar 2 2010 BOOTPROG/GRUB4DOS_0_4_4.ZIP;1
-r--r--r-- 1 root root 5572421 Apr 1 2010 BOOTPROG/SYSLINUX_3_86.ZIP;1
fixed version:
zito at bobek:/data/image$ /usr/lib/mc/extfs.d/iso9660 list systemrescuecd-x86-1.6.4.iso |grep -i zip
-r--r--r-- 1 root root 819988 Mar 2 2010 bootprog/grub4dos-0.4.4.zip
-r--r--r-- 1 root root 5572421 Apr 1 2010 bootprog/syslinux-3.86.zip
Thanks for your work.
Best Regards
--
Zito
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages mc depends on:
ii e2fslibs 1.41.12-2 ext2/ext3/ext4 file system librari
ii libc6 2.11.2-7 Embedded GNU C Library: Shared lib
ii libcomerr2 1.41.12-2 common error description library
ii libglib2.0-0 2.24.2-1 The GLib library of C routines
ii libgpm2 1.20.4-3.3 General Purpose Mouse - shared lib
ii libslang2 2.2.2-4 The S-Lang programming library - r
Versions of packages mc recommends:
ii mime-support 3.51-1 MIME files 'mime.types' & 'mailcap
Versions of packages mc suggests:
ii arj 3.10.22-9 archiver for .arj files
ii bzip2 1.0.5-6 high-quality block-sorting file co
pn catdvi <none> (no description available)
ii dbview 1.0.4-1 View dBase III files
ii djvulibre-bin 3.5.23-3 Utilities for the DjVu image forma
ii evince-gtk [pdf-viewer] 2.30.3-1 Document (postscript, pdf) viewer
ii file 5.04-5 Determines file type using "magic"
ii gv [pdf-viewer] 1:3.7.1-1 PostScript and PDF viewer for X
ii imagemagick 8:6.6.0.4-3 image manipulation programs
ii lynx 2.8.8dev.6-3 Text-mode WWW Browser (transitiona
pn odt2txt <none> (no description available)
ii okular [pdf-viewer] 4:4.4.5-2 universal document viewer
ii perl 5.10.1-16 Larry Wall's Practical Extraction
ii python 2.6.6-3+squeeze2 interactive high-level object-orie
pn python-boto <none> (no description available)
pn python-tz <none> (no description available)
ii unzip 6.0-4 De-archiver for .zip files
ii w3m 0.5.2-10 WWW browsable pager with excellent
ii xpdf [pdf-viewer] 3.02-11 Portable Document Format (PDF) rea
ii zip 3.0-3 Archiver for .zip files
-- Configuration Files:
/etc/mc/mc.ext changed [not included]
-- no debconf information
-- debsums errors found:
debsums: changed file /usr/lib/mc/extfs.d/iso9660 (from mc package)
-------------- next part --------------
--- /usr/lib/mc/extfs.d/iso9660.orig 2010-09-08 11:41:19.000000000 +0200
+++ /usr/lib/mc/extfs.d/iso9660 2010-12-14 15:29:44.000000000 +0100
@@ -15,7 +15,7 @@
fi
if test -n "$CHARSET"; then
CHARSET=`echo "$CHARSET" | tr '[A-Z]' '[a-z]' | sed -e 's/^iso-/iso/'`
- isoinfo -j $CHARSET -i /dev/null 2>&1 | awk "/Iconv not yet supported|Unknown charset/" >/dev/null && CHARSET=
+ isoinfo -j $CHARSET -i /dev/null 2>&1 | grep "Iconv not yet supported\|Unknown charset" >/dev/null && CHARSET=
fi
if test -n "$CHARSET"; then
JOLIET_OPT="-j $CHARSET -J"
@@ -23,7 +23,7 @@
JOLIET_OPT="-J"
fi
ISOINFO="isoinfo -R"
- isoinfo -d -i "$1" | awk "/UCS level 1|NO Joliet/" > /dev/null || ISOINFO="$ISOINFO $JOLIET_OPT"
+ isoinfo -d -i "$1" | grep "UCS level 1\|NO Joliet" > /dev/null || ISOINFO="$ISOINFO $JOLIET_OPT"
}
mcisofs_list () {
More information about the Pkg-mc-devel
mailing list