Dan Williams: Incremental: return success in 'container not enough' case

Martin F. Krafft madduck at alioth.debian.org
Thu Sep 2 10:01:21 UTC 2010


Module: mdadm
Branch: master
Commit: fd4c9ba49120bb0885491e953d7872b541ffa5a7
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=fd4c9ba49120bb0885491e953d7872b541ffa5a7

Author: Dan Williams <dan.j.williams at intel.com>
Date:   Tue Aug 10 08:44:45 2010 -0700

Incremental: return success in 'container not enough' case

Commit 97b4d0e9 "Incremental: honor an 'enough' flag from external
handlers" introduced a regression in that it changed the error return
code for successful invocations.

Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Reported-by: Ignacy Kasperowicz <ignacy.kasperowicz at intel.com>

---

 Incremental.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Incremental.c b/Incremental.c
index a8a072d..e4b6196 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -264,7 +264,7 @@ int Incremental(char *devname, int verbose, int runstop,
 		else {
 			if (verbose)
 				fprintf(stderr, Name ": not enough devices to start the container\n");
-			return 1;
+			return 0;
 		}
 
 		/* This is a pre-built container array, so we do something




More information about the pkg-mdadm-commits mailing list