Dan Williams: Incremental: accept '--no-degraded' as a deprecated option

Martin F. Krafft madduck at alioth.debian.org
Thu Sep 2 10:01:28 UTC 2010


Module: mdadm
Branch: master
Commit: 172356c93a787fe9cddfa5bbc6008b9ded6dd6f0
URL:    http://git.debian.org/?p=pkg-mdadm/mdadm.git;a=commit;h=172356c93a787fe9cddfa5bbc6008b9ded6dd6f0

Author: Dan Williams <dan.j.williams at intel.com>
Date:   Mon Aug  9 10:26:24 2010 -0700

Incremental: accept '--no-degraded' as a deprecated option

Commit 3288b419 (Revert "Incremental: honor --no-degraded to delay assembly")
killed the --no-degraded flag since commit 97b4d0e9 (Incremental: honor
an 'enough' flag from external handlers) made this the default behavior
of -I, and brought -I usage for external/container formats in line with
native metadata.  However, this breaks existing usages of '-I
--no-degraded', so allow it as a deprecated option.

Starting a degraded container, like the native metadata case, requires -R.

Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Reported-by: Ignacy Kasperowicz <ignacy.kasperowicz at intel.com>

---

 mdadm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mdadm.c b/mdadm.c
index 20a5638..08e8ea4 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -691,6 +691,8 @@ int main(int argc, char *argv[])
 		"     'summaries', 'homehost', 'byteorder', 'devicesize'.\n");
 			exit(outf == stdout ? 0 : 2);
 
+		case O(INCREMENTAL,NoDegraded):
+			fprintf(stderr, Name ": --no-degraded is deprecated in Incremental mode\n");
 		case O(ASSEMBLE,NoDegraded): /* --no-degraded */
 			runstop = -1; /* --stop isn't allowed for --assemble,
 				       * so we overload slightly */




More information about the pkg-mdadm-commits mailing list