New commits on branch debian/disable-udev-incr-assembly
Michael Tokarev
mjt at alioth.debian.org
Tue Jan 10 18:28:43 UTC 2012
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d3f1f42fc7e6ee9843cd5b259ed5c17e6008a91f
Merge: d298eab 319029b
Author: Michael Tokarev <mjt at tls.msk.ru>
Date: Tue Jan 10 16:46:57 2012 +0400
Merge commit 'refs/top-bases/debian/disable-udev-incr-assembly' into debian/disable-udev-incr-assembly
Conflicts:
udev-md-raid.rules
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=319029b6238e9836830b0c02aabd5ea01370b5ef
Author: Michael Tokarev <mjt at tls.msk.ru>
Date: Tue Jan 10 16:30:53 2012 +0400
updated to new upstream release 3.2.3
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ffcc983ba1ea8b0d45e1cc1e9d50eb1b3f2b2c71
Merge: c4c92db 1fbc5b7
Author: Michael Tokarev <mjt at tls.msk.ru>
Date: Tue Jan 10 16:08:36 2012 +0400
Merge commit 'mdadm-3.2.3'
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c4c92db88ab99095b3c79216ff81f83208767c1d
Author: Michael Tokarev <mjt at tls.msk.ru>
Date: Tue Jan 10 14:38:12 2012 +0400
fix debian/changelog to include 3.2.2-1 release
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1fbc5b7a5ea9709cdfff7fe7b63b43dfd4def124
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 14:32:44 2011 +1100
Release mdadm-3.2.3
Bug fix release.
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c0c1acd691e3809647f464f88e57405a01e12b30
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 14:10:41 2011 +1100
Grow/bitmap: support adding bitmap via sysfs.
Adding a bitmap via ioctl can only add it at a fixed location.
That location is not suitable for 4K-block devices.
So allow setting the bitmap location via sysfs if kernel supports it
and aim to always use 4K alignments.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b6db6fab11aedf2f04831d777e68a557b6d1f450
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 14:09:56 2011 +1100
super1: use awrite when writing a new bitmap.
This ensures it will succeed on 4K block devices like DASD.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a7322ae12f674e7eb1c7af183d130ae3120de2bd
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 14:09:29 2011 +1100
Subject: bitmap: used 4K aligned buffers when reading the bitmap.
This is needed on 4K block devices such as DASD as we do O_DIRECT
reads.
Do the same alignment for gpt just to be safe.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=adbb382b55779b1e662bec80e36efb9450d1448d
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 14:07:47 2011 +1100
super1 - fix for bigendian machines.
devflags is a single byte so endian conversions are now wanted.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=887162637fee00eab4fce09753cafc84b0da7f17
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 10:49:07 2011 +1100
Assemble: fix count in "assembled with .. but not started".
We need to include the count of pre-existing devices here.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=576d02800287e9d57d6f221cf418d07cdd7597a4
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 10:49:07 2011 +1100
Assemble: make some plurals conditional.
"1 devices" is ugly. Fix it.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a408d66c4f4a658f62df547ea5e06b4a7afc5ec0
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 10:47:07 2011 +1100
Incremental: make sure container name appears in /dev
We need to send a "change" event just like we do when
creating an array.
This reverts commit 382afe49b10cf3e5a4764cee74649d1cd8c91813
The problem is that we need udev to create the file in /dev
for us.
It might be unnecessary for udev to consider assembling things
in this array, but it shouldn't cause a problem. If it did that
would be a different bug which we probably need locking to fix.
Or maybe udev shouldn't trigger a "-I" for containers appearing.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6c9a5fa103c65dfe00fe6648c89357f1ffeb9e5c
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 09:07:14 2011 +1100
bitmap: print correct percentage of bitmap in use.
We were adding 1, presumably to avoid div-by-zero possibilities.
It is better to only substitute '1' if the value actually is zero,
else for small numbers of bits the difference is visible.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7b80ad6af2a1ae027eed140010c4d4e160bfe1f9
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 09:04:59 2011 +1100
ddf: fix auto-allocation problem.
We need to check every disk to see if it has a particular amount of
space spare, not just every subsequent disk.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ba3903d416524e0fb002eca971ce6026e5f2c3af
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 07:42:23 2011 +1100
allow --monitor to be run by non-privileged use.
Providing --no-sharing is given, monitoring should be permitted.
Unfortunately the kernel current rejects GET_DISK_INFO and
GET_ARRAY_INFO for non-privileged users which is unjustified.
The info is available in sysfs and we could get it from there,
but for now, require the kernel to be fixed.
Reported-by: Raphael Hertzog <hertzog at debian.org>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3e9df86add05b3a759148a8a1760a44887654322
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Fri Dec 23 07:13:55 2011 +1100
FIX: Verify if array name doesn't exist already
When e.g. array name (an) is correct and it is the same as container name (cn),
file element creation /dev/md/an will replace /dev/md/cn.
This can cause that user cannot access container using /dev/md/cn.
Verify during array creation if chosen name is not already existing
one.
[Changed to use map_by_name() rather than stat() to determine prior
existence - NeilBrown]
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=24daa16fa1a44635690015a28474de43eea3a679
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 06:59:51 2011 +1100
Grow.c: fix lots of white-space issues.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ce4783d3d60af3b89e4d06a6948a972d3e1c87cd
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 06:59:48 2011 +1100
Grow: fix reshape-array for shrinking reshapes.
The value in info->array.raid_disks is the total number of
devices, which is the 'after' number when the number is increasing,
and the 'before' number when the number is decreasing.
The code currently assumes it is always the 'after' number - so fix
that.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=27a1e5b5a48d89feffb49ceab94e1ac764258f79
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 06:59:45 2011 +1100
Grow: fix start_reshape for shrinking arrays.
When an array is being reshaped to fewer data devices the relationship
between sync_max and reshape_progress is different to when the number
of devices increases - we need to allow for that when setting
sync_max/sync_min.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=0b50d3359a66aaface15af2471227560d7707f3b
Author: NeilBrown <neilb at suse.de>
Date: Fri Dec 23 06:41:52 2011 +1100
tests/03r5assemV1 - slow down recovery a bit more.
In this test we stop and restart an array that is being recovered,
and we do that several times. Sometimes it completes the recovery
before we expect and test results are wrong.
So slow it down a bit more.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=cb0997242cd617c2c78295693af386add40b6ce2
Author: NeilBrown <neilb at suse.de>
Date: Tue Dec 20 15:01:53 2011 +1100
super1: getinfo_super should set write-mostly flag.
Otherwise it is not preserved when you re-add a device to
an array.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b307134253acf9c78a3952fe7821f67dfeba61da
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Fri Dec 16 14:04:53 2011 +0100
imsm: make messages more understandable
The printed messages should be more appropriate and understandable
for user. If maxsize is equal 0, this means there is no free space left
on device. If size is greater than maxsize, this means there is not enough
space to create a new volume of given size.
Acked-by: Dan Williams <dan.j.williams at intel.com>
Acked-by: Marcin Labun <marcin.labun at intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=5fe62b9455b6b43f050f3a52610ce1048a44623c
Author: Williams, Dan J <dan.j.williams at intel.com>
Date: Wed Dec 14 18:21:07 2011 -0800
imsm: FIX: UT '08imsm-overlap' fails
Make test for all sub arrays having the same number of devices
dependant on the option ROM requirements being checked.
08imsm-overlap disables the OROM check but then fails because this
test causes it to.
Reported-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=81a5b4f52f0697f3c494c7ee2723e5f833b9ec51
Author: NeilBrown <neilb at suse.de>
Date: Tue Dec 20 10:30:34 2011 +1100
Remove update_private
This fields doesn't work any more as ->getinfo_super clears the info
structure at an awkward time. So get rid of it and do it differently.
The issue is that the metadata handler cannot tell if the uuid it has
was randomly generated or explicitly requested, except on the first
call.
And we don't want to accept explicit requests for IMSM.
So when it was auto-generated, make it look distinctive by having the
same int copied in all 4 positions. If someone requests a uuid like
that, I guess they get away with it.
Reported-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=67a2db324f61326157373117c78a8314c7d220e4
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Dec 15 14:35:00 2011 +1100
imsm: FIX: Chunk size migration is not possible
Chunk size only migration for raid0 and raid5 is not possible.
(mdadm UT 15* fails). Mdadm exits with information:
mdadm: imsm unknown layout 0xffffffff for this raid level 0
Problem was introduced in patch (2011-11-16):
imsm: platform capabilities are not validated during level migration
During chunk size migration layout variable is not set correctly.
Set it correctly for this migration type.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=4c965cc9890334b5100a38a1a51a46ef1fe7fbf2
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Dec 15 14:34:51 2011 +1100
imsm: FIX: return correct status from load_imsm_migr_rec()
load_imsm_migr_rec() should see difference between no migration record due
to no migration in progress and loading migration record error.
Additional return value (-2) was introduced to this function.
Using new status load_super_imsm_all() can correctly check loading
migration record status.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=97a3490c0d9eb1672a3804625d5c58bcc29a08e1
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Dec 15 14:34:46 2011 +1100
FIX: Add error message in container_reshape()
Add proper error message for container reshape when device cannot be opened.
fd variable operation is moved down to display information what particular
device cannot be opened.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2d04d7e5c38b107905aea37277601d889ecf2302
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Dec 15 14:34:36 2011 +1100
FIX: Do not allow for multiple reshape_array() execution during reshape_container() call
It can happen during reshape restart that reshape_array() can exit without
error (e.g. Grow.c:1915) and reshape is not moved to next array.
reshape_array() is called again for the same device.
Do not allow for such execution and check if last reshaped array is not
the current one.
This patch can be treat not as solution, but it allows for such errors
detection.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a6482415178f1a834e15d7017a70547d0e965ff0
Author: NeilBrown <neilb at suse.de>
Date: Tue Dec 13 13:24:52 2011 +1100
Resolve some more warnings
unused variables when MDASSEMBLE is defined, and a typo in mdadm.8
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b4ab44d8cd5263bc2d082b5e8abbdc91f6a6ed79
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Dec 8 14:47:17 2011 +0100
imsm: FIX: Correct make everything and variable initialization
make everything doesn't compile (again) due to not used function warning
and uninitialized variable.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=17a4eaf90c8c78fb92511f9830dbe819679fd956
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 13 12:54:18 2011 +1100
imsm: FIX: Use definitions for migration record disk operations
Add definition:
MIGR_REC_BUF_SIZE
MIGR_REC_POSITION
to super-intel.c and do not use magic numbers
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=44bfe6dfe95427fc20eefab248373a6c8490da1a
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Dec 12 12:07:53 2011 +0100
imsm: FIX: Use first map only in migration record disk operations
This patch is addition to patch:
"imsm: FIX: Limit migration record operation by disk slot not by index"
Location of migration record (2 first slots) should be taken on up to date
information. It is in first map.
Change slot verification to use first map only.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3136abe58536334dc28d943f7b122a0327a5e540
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Dec 12 12:07:45 2011 +0100
imsm: FIX: Limit migration record operation by disk slot not by index
imsm should store migration record in to 2 first disks in array.
This should be evaluated based on disk slots, not on disks index.
It is not guaranteed that indexes are equal to slots.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=238c0a71dc3288807fd5f7328f2d9d3bdfe7a9f6
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:46 2011 +0100
imsm: FIX: Use defines for device map access
Maps should not be accessed using "magic numbers" /0, 1,-1/.
Add proper definitions and change all map access to use them.
Change present definitions /MAP_0/MAP_1/ to values already used
in code /0, 1, -1//
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=0a108d63d2dba518b4d8a5ced91fdbbb5230ca59
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:38 2011 +0100
imsm: FIX: Check correct slots on disk failure
When changes are made to 2nd map, slot in second map should be tested
instead first one /as change will be applied to second map).
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3d59f0c039281d0b393d11f6eb8b4ce6bcdbc236
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:30 2011 +0100
imsm: FIX: Finish rebuild and initialization when missing drive is handled
When missing device is handled for rebuild or initialization
end_migration() should be called to merge ords in case additional
degradation.
I've removed this call to end_migration() as it was called
for migration also.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=177889945307b38dabae42b9e937312866536829
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:22 2011 +0100
imsm: FIX: Mark failure for rebuild
Allow for marking failures in second map during rebuild and initialization
also (not during migration only)
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6ce1fbf1886f4939e26638324824a5fdbbb42d29
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:15 2011 +0100
imsm: FIX: Add array map state transition for failures during initialization
During initialization disk failure can occur also. Add code for such case
in imsm_set_disk() to support such event.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=fc8ca064477b0f018ed46c21d6f39bfefefad761
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:58:07 2011 +0100
imsm: FIX: Do not allow spare activation during rebuild
Do not allow for spare device activation while rebuild is in progress,
when additional degradation occur.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=94002678b65afdfa9dfa2d75a206e6a52b557b73
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:57:59 2011 +0100
imsm: Function imsm_set_disk() rework
Rework is needed to map state transition part to allow easier code reading.
After rework it is easy to find out what can happen in what map state
transition.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=809da78e600627f58b962579767438e0a7eac76e
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:57:51 2011 +0100
imsm: FIX: Correct ords merging in end_migration()
Ord's merging should occur when rebuild finishes and final state is other
than expected only /additional failures occur during rebuild/.
Exclude array initialization.
Merging ords on migration finish should never happen.
Any failure during migration should be immediately placed in first
/current/ map, so no merge is necessary.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=04ed49b3cf32d91714f25f390ff23fa89233866d
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Dec 7 13:57:43 2011 +0100
imsm: FIX: Remove longer map request
We shouldn't use longer map. mdadm should know what map is accessed
at the moment.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=70eb8219ac128ca88c1beff1e9cf48ed23846eea
Author: Hawrylewicz Czarnowski, Przemyslaw <przemyslaw.hawrylewicz.czarnowski at intel.com>
Date: Wed Dec 7 12:15:55 2011 +1100
fix: imsm: validate strip size - tuned up
Neil's proposal seems more reasonable and shows what is really going on
here.
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d97a5e60506343bd8cb2b75d5003b2a49cbc8566
Author: Sergey B Kirpichev <skirpichev at gmail.com>
Date: Wed Dec 7 08:41:57 2011 +1100
Report raid level type to syslog on RebuildFinished event.
Thus, for RAID1/RAID10 this can be filtered out in logcheck.
Relates-to: Debian bug 599821
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1c278e81813fc481114413f730ad348319382ffe
Author: NeilBrown <neilb at suse.de>
Date: Wed Dec 7 08:39:39 2011 +1100
monitor: don't unblock a device that isn't blocked.
When we see a failed device, we both unblock and remove it (after
updating the metadata).
However it might not be blocked as there can be a delay between
unblocking and the device being free to be removed.
If this happens the clearing of 'blocked' succeeds so md sends a sysfs
notification and mdmon checks again and tries to clear 'blocked'
again.
Thus it enters a busy-loop until the 'remove' succeeds.
To avoid this, only try to unblock if the device was blocked.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d1e02575f579abcb50c967c5126f07a60d4642bc
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:44:46 2011 +1100
FIX: resolve make everything compilation error
When mdadm is compiled using e.g. 'everything' option, mdasseble
compilation is broken.
Change code to enable mdasseble compilation
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=bf4442aba401633edff897c1fb142608962fbe57
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:44:07 2011 +1100
imsm: FIX: Just created redundant array is not in uninitialized state
When redundant array (e.g. raid5) is created metadata shows it is in
normal state. Initialization process is showed in metadata as rebuild from normal
to normal state. Redundant array should be initially in uninitialized state
before it's initialization.
Add code to put array in uninitialized state upon array creation.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=8aedc4eaf6efbe9fda78821e38e395fb322e72d1
Author: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Date: Tue Dec 6 11:41:27 2011 +1100
imsm: fix: does not allow to use invalid chunk size
Only least significant bit of chunk size provided by user has been used
in test with OROM capabilities. This way user could pass value which is
not a power of 2.
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=137debce82ba1731722d868cd91af386da5e3dd4
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:40:58 2011 +1100
imsm: FIX: Check maximum allowed degradation level in recover_backup_imsm()
Any degradation during backup recovery causes error and array assembly
failure.
Allow for degradation during backup recovery.
This allows for degraded array assembly.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9a7172822a9d776deb7f52dc2361d6b850efceec
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:39:58 2011 +1100
imsm: FIX: Check maximum allowed degradation level in open_backup_targets()
Any degradation during opening any backup device can causes error
and array assembly failure.
Allow for degradation during opening backup devices.
This allows for degraded array assembly.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d59851384305b64af5304581c4b804bc95987744
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:37:16 2011 +1100
imsm: FIX: Function rework - imsm_count_failed()
imsm_count_failed() assumes that on the same positions in both maps
the same disk indexes are kept. This is not always true /e.g. rebuild/
It can occur that disk taken for rebuild fails at once.
Degradation on the same positions in both maps refers to different disks.
Sum of both ords can point on not failed disk. This can cause wrong
failed disk counting.
Check both maps independently. This allows for getting real degradation
information.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3b451610b50c3e668a96fc2c9cf6e68970e36eed
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:36:30 2011 +1100
imsm: FIX: Manage second map state on array degradation
When degradation during migration occurs second map state is not set
to degraded value (map are updated correctly).
Correct second map state according to it's degradation level.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=f627f5ad437672d58e48ed0f32a5bb285efd1d76
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:30:16 2011 +1100
imsm: FIX: Restore critical section on degraded array
When during assembly degradation occurs restoring metadata critical section
fails whole assembly.
Allow for degradation during assembly and not restore data on degraded disk.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3f510843b1354538270ffa64a137f2bf6b656001
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:28:04 2011 +1100
imsm: FIX: Remove single map state limitation in getinfo
It can occur that degradation during migration occurs on disks that are not
present in both maps /e.g. degradation on just added disk during OLCE/.
This can cause that maps will be in different states (one will be in degraded
and second in normal state). In such situation getinfo_super_imsm_volume()
will not return migration information.
Remove single state limitation in both maps to allow migration information
retrieving.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=bf2f00718640b5c5cad3076344d347d885b523f9
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:27:57 2011 +1100
imsm: FIX: Finalize degraded migration
Currently mdadm for IMSM can finalize not-degraded migration only.
Add support for IMSM for migration finalization when array
are is degraded state.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=bd5f6849b0290d676eff9b6f5b3d890d7184641b
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:24:22 2011 +1100
imsm: FIX: Do not end migration when missing drive is handled
Currently when degradation occurs migration is finalized. This is wrong.
Finalizing migration when it is not finished can lead to data corruption
after next array assembly.
Do not finish migration when degradation occurs.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1ace84038d7913807037f4c3e6e1b49c065c037c
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:21:23 2011 +1100
imsm: FIX: Mark both maps on degradation while migrating
During migration degradation is set in first map only. This means that
according to second map disk is present. This is not true and not compatible
with OROM behavior.
Set disks in both maps to degraded state during migration.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9535fc478c4ce977f83add0dfeab767751745c92
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Tue Dec 6 11:17:26 2011 +1100
imsm: FIX: Return longer map for failure setting
When 2 maps are present, IMSM can use shorter map for setting disk
in to degraded state. It can happen that degraded disk can be not present
in shorter map.
We should use longer map for setting disk in to degraded state.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9645010f4a9a9db3d43915d3cef9f4e8bb856b14
Author: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Date: Thu Nov 24 16:23:21 2011 +1100
imsm: incorrect incremental behavior because of wrong index used
Incremental in some cases prematurely assembles degraded arrays due to
wrong index used in code which counts missing disks
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
Reviewed-by: Dan Williams <dan.j.williams at intel.com>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7728e1c635b6536e806e8adb5fb3a816d29b8742
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Fri Nov 18 15:34:33 2011 +0100
fix: correct metadata's update communication
The problem occurs when array under migration is assembled incrementally.
st->update_tail is not initialized in function
assemble_container_content() and during reshape
the checkpoint information in metadata is not being updated.
The value of st->update_tail is now initialized in function
assemble_container_content() and during reshape the checkpoint
information in metadata is being updated correctly on all disks.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=464d40e80abc61e0cd8824a9e2c73f0a2b45f04c
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Fri Nov 18 15:28:36 2011 +0100
imsm: fix: correct printing value of blocks per migration unit
The value of blocks per migration unit is not printed correctly
when the metadata's content is examined using -E option on disks
without present migration record. (Migration record is present only
on 2 first disks in array due to IMSM compatibility restrictions.)
Printing the value of blocks per migration unit was corrected.
It is printed as N/A (Not Available) for disks
without the migration record.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e91a3bade8ec195b833d48368fdae1972538f123
Author: Labun, Marcin <Marcin.Labun at intel.com>
Date: Wed Nov 16 15:24:10 2011 +1100
imsm: platform capabilities are not validated during level migration
Migration from RAID0 to RAID5 should be blocked on the system without
support for RAID5. No platform validation was performed in RAID
level migrations: verification for all level migrations added.
Signed-off-by: Marcin Labun <marcin.labun at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a510b1c7f07ba750979ba2f213ebe261bcfc4de4
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Mon Nov 14 15:52:52 2011 +0100
imsm: fix: correct checking newly missing disks
The problem occurs when RAID10 array under rebuild
(after one disk fails) is assembled incrementally.
Mdadm tries to start array just after adding the third disk
and the volume is assembled incorrectly (in degraded state).
The cause is that container_enough depends on
newly missing disks which are checked incorrectly now.
They should be checked using always the first map.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3baa56ab61e371e064db23e5c6b2fe0f23e79d84
Author: Lukasz Orlowski <lukasz.orlowski at intel.com>
Date: Mon Nov 14 16:41:03 2011 +1100
imsm: fix: Allowed to create 2 volumes with total size less then maximum.
mdadm allows to create second volume on the same disk set, whose size is
less then the free space left in the container (with IMSM_NO_PLATFORM
undefined or set to 0). This is an OROM compatibility issue.
It is fixed by verifying whether IMSM_NO_PLATFORM is set and for
the second volume creation scenario, requested size is verified against
remaining available space.
Signed-off-by: Lukasz Orlowski <lukasz.orlowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=68fe459825ff85304a9a13128abf4ae6c7a1bfcf
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Mon Nov 7 12:23:49 2011 +1100
imsm: fix: add support for OLCE and migration to imsm_count_failed
The problem occurs when array under OLCE (from 3 to 6 disks)
is assembled incrementally. Mdadm tries to start array
just after adding the third disk (this is equal to the number of disks
before the start of reshape). It does not succeed,
the volume does not assembly correctly.
The function counting failed disks (imsm_count_failed())
was fixed for migration case. Now all disk members in both maps
are checked when failed disks are counted correctly.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7c3367585ec04e249dca1d6e64afcb2be9723a9b
Author: Lukasz Orlowski <lukasz.orlowski at intel.com>
Date: Mon Nov 7 12:20:34 2011 +1100
fix: Allowed to assemble 2 volumes with the same names from config file.
mdadm allowes to assemble 2 volumes with the same names based on the
config file. The issue is fixed by iterating over the list of md device
identifiers and comparing the names of md devices against each other,
detecting identical names and blocking the assembly should the same names
be found.
Now having detected duplicate names, mdadm terminates without assembling
the container, displaying appropriate prompt.
Signed-off-by: Lukasz Orlowski <lukasz.orlowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=4584621ab439f009d7f6a3e61b7cc91c0374065f
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Nov 7 11:46:35 2011 +1100
FIX: Do not continue container reshape when mdmon is absent
When mdmon is absent metadata is not updated, and container_reshape()
can fall in to endless loop. This can cause user data corruption.
In case when mdmon is absent do not continue container reshape process.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=88e5516ea914f0e9d433a50dc0b2867085250308
Author: NeilBrown <neilb at suse.de>
Date: Mon Nov 7 11:44:21 2011 +1100
mdmon: avoid using victim_sock when it is -1.
It possible that we try to use victim_sock even when we couldn't open
it. This is never actually harmful but it looks wrong and it is best
to fix it.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=84a230d993d6a953876f3b83ae79ed519ebf4d07
Author: NeilBrown <neilb at suse.de>
Date: Mon Nov 7 11:37:12 2011 +1100
Revert "mdmon(): Error out if failing to connect to victim monitor"
This reverts commit 819c158866f466075a1c719f0dc496deb2fb3814.
Adam Kwolek reports that with this patch, mdmon sometimes doesn't start:
When array is not clean dismounted directory /dev/.mdadm is not cleaned up.
On array re-assembly read pid is not valid and it is not possible
to connect to monitor. This causes mdmon to exit and array remains
not monitored.
Problem is introduced by fix:
mdmon(): Error out if failing to connect to victim monitor
819c158866f466075a1c719f0dc496deb2fb3814
This is critical for container reshape when mdmon is should finish reshape.
when reshape is not finished, array is reshaped again by mdadm.
As victim_sock is subsequently tested, we don't really need to test-and-fail here.
Reported-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=62f5838f5be435ed0647659fae1920298d651cb9
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:10:08 2011 +1100
match_metadata_desc(): Fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7897de29b552b4395a31722a07ff74ba01673fc1
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:09:56 2011 +1100
fd2devname(): Don't dereference NULL pointer
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1471b8b14b2af593fcbb9584c90adbe6d9bc2977
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:09:41 2011 +1100
Manage_ro(): Check pointer rather than dereferencing it
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=29b59ca5c3b8d9c0385efbed232a9820ed9fe58e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:09:19 2011 +1100
unblock_monitor(): Check sra is valid before dereferencing
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=4dab422a6537ce38b7817fbe7eec21940f41c463
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:08:34 2011 +1100
ahci_enumerate_ports(): Don't close fd that failed to open
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c20478757de9b2746860365a3d644c441fb87f97
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:08:23 2011 +1100
close_aa(): Verify file descriptors are valid before trying to close them
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3e1d79b2d66e06ee33df57006f1c15404f849738
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:08:09 2011 +1100
disk_init_and_add(): Fail if opening sysfs file descriptors fail
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=f56128b9bc8e080ea576b0c1cbf0cb40cfc0b657
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:08:00 2011 +1100
array_try_spare(): open_dev() returns -1 on error, not zero
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=99f6e521592f06e7db0a2069c270dd6f9a5e2e89
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:07:39 2011 +1100
get_component_size(): Check read() return value for error before using it
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d94a4f62bfa7950741f320cc49475fbc8c7046a0
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:07:21 2011 +1100
mdstat_read(): Check return value of dup() before using file descriptor
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b36c89351659e1ee3367b32715cf12ef80682b12
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:07:02 2011 +1100
ping_monitor(): check file descriptor is valid before using and closing it
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=5a53aeec7f333e22682930d8fe228b572b7f55c9
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Nov 3 08:06:47 2011 +1100
mdadm: Rearrange option parsing for KillSubarray and UpdateSubarray
Extracting the 'subarray' arg for these options was being done at the
wrong place which lead to the code being a bit confusing and looking
wrong.
So reformat that code a bit better and move the extraction of
'subarray' down to the main parsing of these options rather than the
mode setting.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=96ae5973dda6f6f6487c74b5f3944720a5b9d21f
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 20:30:12 2011 +0100
make_parts(): Fix case of comparing against uninitialized variables
Silencing gcc's warning of uninitialized variables was hiding a bug
where if we have /dev/md64 as a symlink, and /dev/md64p1 was a real
device node.
In this case major_num and minor_num would not get populated, but we
end up comparing against them because the stat for md64p1 succeeds.
Instead of using the int foo = foo trick, change the code to set
set the variables to invalid values so comparisons will fail.
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b2916f251404433aa1eafd36cdb9e19a692f2269
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:34 2011 +0100
validate_geometry_imsm_volume(): Avoid NULL pointer dereference
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=39c74d5e25208e70ac7cc9e63932ff04125e0817
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:33 2011 +0100
bitmap_fd_read(): fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b657208c50a8924a3b9ae2d7b2dc9bfbf37220ee
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:32 2011 +0100
Monitor(): free allocated memory on exit
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=bccd8153faaf34dc53455d598a61e13ce8a986e9
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:31 2011 +0100
Manage_runstop(): Avoid memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b73e45ae6aaed88b44caa9094991d7edc1540690
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:30 2011 +0100
Managa_ro(): free() mdi before exiting
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b1efa6c25cabdb22b58f5dda133ff192050c3069
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:29 2011 +0100
IncrementalScan(): Fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=093d918759b2a3fa70691bdb5cb3e0c9c8ad4935
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:28 2011 +0100
Manage_subdevs(): avoid leaking super
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=aabe020dd2465c9a4df6e72f35f7a986bd7c5327
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:27 2011 +0100
enough_fd(): remember to free buffer for avail array
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=8e61e0d7f9e968505e94766adf8a3407166767c4
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:26 2011 +0100
Grow_reshape(): Fix another 'sra' leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d067351703f0c52d63fe96f22af57c4bbd5889d5
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:25 2011 +0100
Detail(): Remember to free 'avail'
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=518a60f3857b3f7db53756a72364c95c28fa3fd2
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:24 2011 +0100
Assemble(): don't dup_super() before we need it.
Avoid resource leak in case we bail loop early
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=730ae51fddab9052fd2b61c8525ba684655e2f7e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:23 2011 +0100
Grow_restart(): free() offsets after use
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=22472ee1d25511b4e78af88b87bca3995984f664
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:22 2011 +0100
assemble_container_content(): fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d9ca03e9c3d18cc031ee7d4c1a6970ff4c18d33e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:21 2011 +0100
remove_devices(): readlink returns -1 on error
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=93f1df335551a27b4d2cd1a3031ef6bf2a29809b
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:20 2011 +0100
sysfs_unique_holder(): Check read() return value before using as buffer index
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=fb745c4bb4e9e788c96510f6be57d2d973e9a3fb
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:19 2011 +0100
Incremental(): Check return value of dev_open() before trying to use it
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e7344e9007269af1277636c6e2a6bfa1e179ca0e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:18 2011 +0100
Grow_addbitmap(): don't try to close a file descriptor which failed to open
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=68fe8c6ed0e4c0825f8f9f7ac8910c2fc440bc3a
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 16:09:17 2011 +0100
Grow_Add_device(): dev_open() return a negative fd on error
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=446894ea8db17a2dfc740f81d58190c5ac8167d5
Author: NeilBrown <neilb at suse.de>
Date: Tue Nov 1 15:45:46 2011 +1100
Grow: fix check_reshape and open_code it.
check_reshape should not try to parse the subarray string - only
metadata handlers are allowed to do that.
The common code and only interpret a subarray string by passing it to
"container_content" which will then return only the member for that
subarray.
So remove check_reshape and place similar logic explicitly at the two
call-sites. They are different enough that it is probably clearer to
have explicit code.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ad098cdd7943bd16638280f8b7f59e9af250954d
Author: NeilBrown <neilb at suse.de>
Date: Tue Nov 1 15:17:03 2011 +1100
Incremental: Fix a merge error in recent patch
commit 81219e70f2a9be7292046860ea15528fe5854cab required
merging and I messed it up.
The locking shouldn't be there - the caller locks now.
Reported-by: "Labun, Marcin" <Marcin.Labun at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=819c158866f466075a1c719f0dc496deb2fb3814
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:56:28 2011 +1100
mdmon(): Error out if failing to connect to victim monitor
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2b710bac540f07489246a1d53b665f74a9c7dd50
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:56:12 2011 +1100
Write_rules(): Avoid stack corruption if using extremely long udev pathname
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a5cd79fec4db7be33eb707d1d09f506ad6125cf7
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:56:06 2011 +1100
policy_add(): Add missing va_end()
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ea944c8f50205ce25a44eda927383d1f08de171e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:55:59 2011 +1100
Avoid memory leak
In case of second posix_memalign() failing, release memory allocated
in first posix_memalign() call.
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2641101b2f84938fc03b7f7977b72b5a910129b9
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:55:14 2011 +1100
Add missing return in case of trying to grow sub-array
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c9aaf5effb5e4afe5dd1e4d08188140bc596808e
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:54:56 2011 +1100
Fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=be5c60e3fb44c9ca8ae37c3f20e2ccb95ab5e8d3
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:54:27 2011 +1100
partition_try_spare() use closedir() to release DIR * returned by opendir()
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1fdeb8a08457c80cec0d067d0916e2b9159a55ce
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:51:30 2011 +1100
Fix memory leak of 'st3' in array_try_spare()
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=5454b6f32475048a7fbc59e25701361985dc0299
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:51:14 2011 +1100
Fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=83366b33529567fb13a26773196a03a35b872c52
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 14:50:44 2011 +1100
Fix memory leak
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d152f53eaaa2e47090e73b3056ffb4acbbcd4b15
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Tue Nov 1 13:33:48 2011 +1100
Fix memory leaks in reshape_array()
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=88657e86d9c75d3ab68a03035fbc49366712558c
Author: NeilBrown <neilb at suse.de>
Date: Tue Nov 1 13:30:44 2011 +1100
Kill: remove duplicate tests on 'force'.
We test 'force' twice with the second having not chance of
taking effect.
As a result a subsequent message - intended for use in the 'force'
case is never generated.
So remove the first test - it is unnecessary.
Reported-by: Jes.Sorensen at redhat.com
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2244d1a9877d18bdc42a5204d31f41920d369e87
Author: NeilBrown <neilb at suse.de>
Date: Tue Nov 1 13:30:41 2011 +1100
Remove duplicated code: search_mdstat and conf_match
search_mdstat and conf_match are almost identical.
Put all the functionality in conf_match, and remove search_mdstat.
Reported-by: Jes.Sorensen at redhat.com
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=81219e70f2a9be7292046860ea15528fe5854cab
Author: Labun, Marcin <Marcin.Labun at intel.com>
Date: Mon Oct 31 11:29:46 2011 +1100
kill-subarray: fix, IMSM cannot kill-subarray with unsupported metadata
container_content retrieves volume information from disks in the
container. For unsupported volumes the function was not returning
mdinfo. When all volumes were unsupported the function was returning
NULL pointer to block actions on the volumes. Therefore, such volumes
were not activated in Incremental and Assembly. As side effect they
also could not be deleted using kill-subarray since "kill" function
requires to obtain a valid mdinfo from container_content.
This patch fixes the kill-subarray problem by allowing to obtain
mdinfo of all volumes types including unsupported and introducing new
array.status flags.
There are following changes:
1. Added MD_SB_BLOCK_VOLUME for blocking an array, other arrays in the
container can be activated.
2. Added MD_SB_BLOCK_CONTAINER_RESHAPE block container wide reshapes
(like changing disk numbers in arrays).
3. IMSM container_content handler is to load mdinfo for all volumes
and set both blocking flags in array.state field in mdinfo of
unsupported volumes. In case of some errors, all volumes can be
affected. Only blocked array is not activated (also reshaped as
result). The container wide reshapes are also blocked since by
metadata definition they require modifications of both arrays.
4. Incremental_container and Assemble functions check array.state and
do not activate volumes with blocking bits set.
5. assemble_container_content is changed to check container wide reshapes
before activating reshapes of assembled containers.
6. Grow_reshape and Grow_continue_command checks blocking bits
before starting reshapes or continueing (-G --continue) reshapes.
7. kill-subarray ignores array.state info and can remove requested array.
Signed-off-by: Marcin Labun <marcin.labun at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=db7fdfe422a7d280b1fae999cb72b20b0e58756c
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Mon Oct 31 10:24:55 2011 +1100
Avoid stack overflow if GPT partition entries on disk are > 128 bytes
Per [1] GPT partition table entries are not guaranteed to be 128
bytes, in which case read() straight into a struct GPT_part_entry
would result in a buffer overflow corrupting the stack.
[1] http://en.wikipedia.org/wiki/GUID_Partition_Table
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9ad6f6e65a535f77f180e87393043a8ffcfb30d8
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 26 18:16:55 2011 +0200
FIX: Close unused handle in child process during reshape restart
When array reshape (e.g. raid0->raid5 migration) is restarted during
array assembly, file system placed on this array cannot be mounted until
reshape is finished due to "busy" error.
This is caused when reshape is executed on array for external metadata
and array handle is cloned /forked/ to child process environment but not
closed.
Handle can't be closed before executing Grow_continue() because it is
used later in code.
Close unused handle in child process /reshape_container()/.
It is similar to close fd handle in reshape_array() before calling
manage_reshape()/child_monitor() in Grow.c:2290.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e9ef57a816de7bd2eada5a5eecb53ea7f2c9dba1
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Thu Oct 6 16:43:51 2011 +0200
GCC compile fix: remove calculation of unused variable 'reservation'
gcc 4.6.1 doesn't like calculating a variable that then isn't
used. Remove it.
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=65c83a8023e08f4233c562db62f61dc28ed19715
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Tue Oct 25 15:42:25 2011 +0200
util.c: two typos fixed
Two typos fixed.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=5961eeec2fe855a164c2e3719bd0835a5b7a8a04
Author: root <root at gklab-128-192.igk.intel.com>
Date: Sat Oct 22 11:42:16 2011 +1100
imsm: fix: Fixes metadata after migration from Raid 0 to Raid 10
After migration from Raid 0 to Raid 10, the metadata is incorrect,
leaving one mirror disk marked as spare and one missing disk as a member
of the array.
The reason is that the metadata update code for spare activation
procedure takes into account one spare disk only, not checking
the following ones.
Signed-off-by: Lukasz Orlowski <lukasz.orlowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=061d7da34cb6a551219afb726b2ed66af83e72ca
Author: Lukasz Orlowski <lukasz.orlowski at intel.com>
Date: Sat Oct 22 11:38:56 2011 +1100
imsm: Moves metadata update code for spare activation to separate function
The metadata update code during spare activation is moved to a separate
function for clarity of code, as a prework for the next patch fixing
the bug.
Signed-off-by: Lukasz Orlowski <lukasz.orlowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=25824e2d07e49ea4d64033dda42834301c715ef7
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:34:08 2011 +1100
Incremental() lock error handling
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e69104392b6f13b89c78280a055bce369fcd8ff7
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:33:53 2011 +1100
Create() check malloc() return value
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e06af9dd628c6b1c5525f069bbcd824bcc0e37db
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:32:52 2011 +1100
Create() don't leave the lock hanging on error
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=015da8f5a8cc8c90394d443cbd9a882006aaedd2
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:32:19 2011 +1100
array_try_spare(): missing map_unlock()
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=eafa60fd6ec35ac7c0a01a17c3018af4c90046ef
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:30:43 2011 +1100
Hold the map lock while performing Assemble to avoid races with udev
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=382afe49b10cf3e5a4764cee74649d1cd8c91813
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:30:02 2011 +1100
Don't tell sysfs to launch the container as we are doing it ourselves
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=5fc8cff3a4177dfbab594947283117620b4b8c9c
Author: Jes Sorensen <Jes.Sorensen at redhat.com>
Date: Sat Oct 22 11:29:47 2011 +1100
Remove race for starting container devices.
This moves the lock handling out of Incremental_container() and relies
on the caller holding the lock. This prevents conflict with a
follow-on mdadm comment which may try and launch the device in
parallel.
This involves replacing a call to "Incremental" with an
unrolled version with just the case that calls Incremental_container
and so needs a call to ->load_container.
Signed-off-by: Jes Sorensen <Jes.Sorensen at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9c8c121881769c9ce77fd7d981608c976aac8b5b
Author: NeilBrown <neilb at suse.de>
Date: Thu Oct 20 13:14:26 2011 +1100
super0: fix overflow when checking max size.
We need to force multiplication to use ULL before they
get to big, else it overflows. So move the "2ULL" to the start.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c4acd1e5c83a7ad746e8d0a0949e097c8aaf525c
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Wed Oct 19 15:16:33 2011 +0200
imsm: fix: correct debug printing of the volume's name
The volume's name is saved in the array of chars.
All elements of the array can have nonzero values
and the next byte in memory does not have to have
the value of 0, so one must be cautious when
printing out the volume's name.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7d0c5e24a5b2425abcfb778f9c31db39f53703c8
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Wed Oct 19 11:51:48 2011 +0200
imsm: fix: prevent segfault in mark_failure
Using an array of chars without the terminating null byte
as a parameter of sprintf() function causes segfault
when dealing with SAS drives (with 20-digits serial number).
The memcpy() function is used instead.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=fde139b91e0477d500015e0838e0bc180f1befba
Author: NeilBrown <neilb at suse.de>
Date: Mon Oct 17 16:51:31 2011 +1100
Grow: Only ping monitor on level change if array is container based.
Pinging the monitor for a NULL container is bad.
Reported-by: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
Tested-by: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=fca13185fc23760503a91e7f881286375e71ce4c
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Oct 13 11:22:13 2011 +0200
Fix unterminated buffer after readlink() call
Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9cf014ec4055d95f32e028f1a004ea165d90ffe4
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Thu Oct 13 11:21:07 2011 +0200
Fix off-by-one in readlink() buffer size handling
readlink() returns the number of bytes in the buffer.
If we do something like
len = readlink(path, buf, sizeof(buf));
buf[len] = '\0';
we might write one byte past the end of the buffer.
Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b601104eb4a4733a838fb86e9e279fed14ce9d3f
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Mon Oct 10 09:16:40 2011 +1100
imsm: fix: stopped resync does not continue after auto-assemblation
Resync stopped with "mdadm -Ss" command does not continue
after issuing "mdadm -As" command.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3bd58dc65f154993f2cc8b1460c67884cb901605
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Oct 6 11:13:22 2011 +0200
Always run Grow_continue() for started array.
So far there were 2 reshape continuation cases:
1. array is started /e.g. reshape was already invoked during initrd
start-up stage using "--freeze-reshape" option/
2. array is not started yet /"normal" assembling array under reshape case/
This patch narrows continuation cases in to single one. To do this
array should be started /set readonly in to array_state/ before calling
Grow_continue() function.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ea672ee1190e3ce4e4f0a0e612f9dd1808b31c41
Author: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Date: Wed Oct 5 11:59:50 2011 +0200
imsm: always use set_migr_type to set type of migration
For 'resync' besides the update of migration type (imsm_vol.migr_type
structure) additionally status (imsm_dev.status) flag is set to
DEV_VERIFY_AND_FIX. In order to clean up after migration, status flag
must be cleared. For this reason, migration type shouldn't be set
directly but via set_migr_type(). Otherwise status does not reflect
the state of array.
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b451aa4846c5ccca5447a6b6d45e5623b8c8e961
Author: NeilBrown <neilb at suse.de>
Date: Thu Oct 6 13:00:28 2011 +1100
Fix handling for "auto" line in mdadm.conf
Two problems.
1/ pol_merge was ignoring the pol_auto tag so any 'auto' information
was lost
2/ If a device had not path (e.g. loop devices) or if there were no
path-based policies, we didn't bother looking for policy at all.
So path-independant policies were ignored.
Reported-by: Christian Boltz <suse-beta at cboltz.de>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b303fe21b5ad9a239a2984649446fce060918571
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Wed Oct 5 14:17:38 2011 +1100
imsm: fix: correct adding and activation of spare disks
During activation of spare disks, only one of all available
spare disks can be activated at this moment.
It causes that for example during take-over from
RAID0 with 2 disks to RAID10, only one of two spare disks
is taken for recovery and a degraded RAID10 array
with only 3 of 4 working disks is created.
It has been fixed by adding more than one of all available
spare disks and saving them in additional_test_list
which is passed to imsm_add_spare().
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6937e6d21698b7a81aff9a116a6e09659defbe91
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 5 14:00:00 2011 +1100
Set correct reshape restart position
This patch version is simplified compared to previous one.
There is no use of freeze_reshape flag in start_reshape(). It is assumed
that for reshape starting condition reshape_progress field contains
0 value /correct start position/. For reshape restart case, it contains
correct restart position. This approach doesn't make start_reshape()
difficult to read/manage and /imho/ kernel changes to change mdstat
reporting behavior are not necessary.
Setting correct position allows user to see it in the mdstat during
reshape restart and reshape process is not reported as resync.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a93ada3b7d301eee390d35a39c23ce061de76820
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 5 13:59:28 2011 +1100
Monitor reshaped array
Reshape can be run for monitored arrays only /external metadata case/.
Before reshape can be executed, make sure that just starter array/container
is monitored. If not, run mdmon for it.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2370a4dc029bcf96076d7fbfc53a38123dad4cd3
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 5 13:33:29 2011 +1100
Remove freeze() call from Grow_continue()
Grow_continue() for external metadata should be executed on blocked
from monitoring array(s)/container.
Additional call to freeze() is not necessary in such case.
It produces meaningless error message only.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3ad2563886684ab89ed6615a1bb63e23c0d88de2
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 5 13:32:28 2011 +1100
imsm: Fill recovery_blocked field present in mdinfo
If any reshape in container is active set recovery_blocked field.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6e75048bc5121a3db33896b628683cdf7dc0d773
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Oct 5 13:30:50 2011 +1100
Add recovery blocked field to mdinfo
When container is assembled while reshape is active on one of its member
whole container can be required to be blocked from monitoring.
For such purpose field recovery blocked is added to mdinfo structure.
When metadata handler finds active reshape in container it should set
recovery_blocked field to disable whole container monitoring during
reshape.
For arrays that doesn't use containers, recovery_blocked field
has the same value as reshape_active field e.g. super0/1.
In fact,recovery is blocked during reshape for such arrays.
For ddf, metadata handler doesn't set reshape_active field,
so recovery_blocked is not set also.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=cc7f63e55319b5c372af20ce528e7e7230746d92
Author: NeilBrown <neilb at suse.de>
Date: Wed Oct 5 13:29:16 2011 +1100
restore_backup() throws core dump
restore_backup() throws core dump during releasing fdlist.
Loop for closing handlers checks next_spare variable,
but iterates disk_count.
Reported-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7aa437c2d8f0efb6554bfee9e26082874d98a9d9
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:32:02 2011 +1100
Move code to check_mdmon_version() function
Move code to function for code reuse.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b91726651d9a22c1f015817dd01efba932ac3bc7
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:31:22 2011 +1100
imsm: Do not mark resync during reshape
During reshape, resync/rebuild in the same container is not possible
due to fact that all arrays in container has to share the same disks set.
Block new resync/rebuild process initialization and setting resync_start
to 0 while any reshape in container is active. This avoids breaking
container reshape and doesn't allow for starting multiple processes
/resync/rebuild and reshape/ at the same time in md.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e2962bfc219ad89087d87da18ef8f9529a457bcd
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:30:28 2011 +1100
imsm: FIX: Do not allow for spare disk activation during reshape
Spare disk activation or starting repair for one array while on second
reshape is in progress, will lead to IMSM incompatible situation when
2 arrays in container shares different disks sets.
This can cause that 2 processes in container /reshape and rebuild/
are in progress in parallel. This is IMSM incompatible situation also.
Block spare disk activation and starting resync if any reshape in container
is in progress.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=f211a13788e261f4e2bb51c0a3b97c6fcba46e40
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:09:21 2011 +1100
Manual update for --continue option
Patch adds to mdadm man the following information:
--continue
This option is complementary pair to assembly --freeze-reshape option.
It is needed when --grow operation is interrupted and it is not restarted
automatically due to --freeze-reshape usage during array assembly.
Option --continue has to be used together with -G , ( --grow ) command
and device that it should be executed on. All parameters required for
reshape continuation will be read from array metadata. If initial
--grow command had required --backup-file= option to be set,
continuation option will require to have exactly the same backup
file pointed to also.
Any other parameter passed together with --continue option will be ignored.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=afd0a9690fb7f79e93b8e7613575fc9f3fa0d080
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:07:30 2011 +1100
Manual update for --continue option
Patch adds to mdadm man the following information:
--freeze-reshape
Option is intended to be used in start-up scripts during initrd boot
phase. When array under reshape is assembled during initrd phase,
this option stops reshape after reshape critical section is being
restored. This happens before file system pivot operation and avoids lost
of file system context. Loosing file system context would cause
reshape to be broken.
Reshape can be continued later using -continue option for grow command.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=f1fe496bce0c521af853a2fde946f44b90859d50
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 10:04:32 2011 +1100
Verify reshape restart position
Check if reshape restart position is the same as set in md.
If position doesn't match this means that we cannot restart reshape.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=577e8448e99454b12bdbb60cf8fe9f0c532e544c
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 09:57:12 2011 +1100
Move code to get_data_disks() function
Move code to function for code reuse.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2dddadb0f713c5bb335a80518b42c152ef955d27
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 09:26:48 2011 +1100
Add continue option to grow command
To allow for reshape continuation '--continue' option is added
to grow command.
Function that will be executed in grow-continue case doesn't require
information about reshape geometry. All required information are read
from metadata.
For external metadata reshape can be run for monitored array/container
only. In case when array/container is not monitored run mdmon for it.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b76b30e0f95008b840849e5f176eaeca20545a9a
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Mon Oct 3 09:15:22 2011 +1100
Do not continue reshape during initrd phase
During initrd phase continuing reshape will cause file system context
lost. This blocks ability to control reshape using checkpoints.
To avoid this, during initrd phase assemble has to be executed with
'--freeze-reshape' option. This causes that mdadm restores reshape
critical section only.
Reshape can be continued later after system full boot.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=cc700db34f6fb565b37f4edf7fe7fe40a5f2745b
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Mon Oct 3 08:55:02 2011 +1100
fix: correct unlocking of map file
1. Three missing map_unlock() calls were added.
2. Map file must be unlocked on fork, else child will hold lock.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e3da7890555d8cfe17fd9ee4f5f04ab64f855919
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Sun Oct 2 21:45:41 2011 +0200
Fix small memory leak
Credit goes to cppcheck.
Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b81221b74eba9fd7f670a8d3d4bfbda43ec91993
Author: Czarnowska, Anna <anna.czarnowska at intel.com>
Date: Mon Sep 19 12:57:48 2011 +0000
imsm: Calculate reservation for a spare based on active disks in container
New function to calculate minimum reservation to expect from a spare
is introduced.
The required amount of space at the end of the disk depends on what we
plan to do with the spare and what array we want to use it in.
For creating new subarray in an empty container the full reservation of
MPB_SECTOR_COUNT + IMSM_RESERVED_SECTORS is required.
For recovery or OLCE on a volume using new metadata format at least
MPB_SECTOR_CNT + NUM_BLOCKS_DIRTY_STRIPE_REGION is required.
The additional space for migration optimization included in
IMSM_RESERVED_SECTORS is not necessary and is not reserved by some oroms.
MPB_SECTOR_CNT alone is not sufficient as it does not include the
reservation at the end of subarray.
However if the real reservation on active disks is smaller than this
(when the array uses old metadata format) we should use the real value.
This will allow OLCE and recovery to start on the spare even if the volume
doesn't have the reservation we normally use for new volumes.
Signed-off-by: Anna Czarnowska <anna.czarnowska at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ecbd9e8160e9de9cc28ad869d303506b1dc69715
Author: NeilBrown <neilb at suse.de>
Date: Wed Sep 21 14:39:01 2011 +1000
Create: improve messages from validate_geometry.
When validate_geometry finds that we haven't committed to
a metadata yet and that the subdev is a member of 'our'
container, it needs to report any errors it finds as Create()
cannot report them effectively.
So make a slight change to the semantics of the 'verbose' flag
and allow validate_geometry to report if it printed any error
messages.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e7cb06c84548c9924a41c48f7d0e0c8a29b0996d
Author: Lukasz Orlowski <lukasz.orlowski at intel.com>
Date: Mon Sep 19 18:52:31 2011 +0200
Create: Allow to create two volumes of different sizes within one container
Allows to create RAID 5 volume on 3 disks and then RAID 1 volume on 2
disks withing the same container.
Signed-off-by: Lukasz Orlowski <lukasz.orlowski at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3f54bd62dc26c9d9dd3398ad07ab8fbd5a55474d
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Sep 21 12:17:30 2011 +1000
Move restore backup code to function
Reshape backup should be able to be restored during reshape continuation
also. To reuse already existing code it is moved to function.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=910e9fa7f95f65aba6adbaaa9a1720820cab60b5
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Sep 21 11:55:15 2011 +1000
FIX: Memory leak during Assembly
For fdlist pointer allocated in assemble_container_content() function,
free() is never called. This patch fixes this memory leak.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ddb12f6ca6c1b04fcc79f114f5d47d6c268ed37a
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Wed Sep 21 11:55:08 2011 +1000
FIX: Do not unblock array accidentally
When sysfs_set_array() function is called, it tests if array
can be configured using sysfs. Setting metadata_version entry
can accidentally unblock mdmon when array is under reshape.
To avoid this, blocking character '-' is checked and if is is set,
it is used for array test.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=7050aa3f6b45352539413492cafc1d26b2972e47
Author: NeilBrown <neilb at suse.de>
Date: Wed Sep 21 09:23:58 2011 +1000
mdadm.8: fix description of "--metadata=1".
This set the metadata to 1.2, not 1.0.
When the default was changed to 1.2 I forgot to update this part of
the man page.
Bug-Debian: http://bugs.debian.org/607375
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=758be4f1c9cda8eefb2fd241835521462196e16c
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Mon Sep 19 13:26:05 2011 +1000
Fix serious memory leak
During reshape function restore_stripes is called periodically
and every time the buffer stripe_buf (of size raid_disks*chunk_size)
is allocated but is not freed. It happens also upon successful completion.
In case of huge arrays it can lead to the seizure of the entire
system memory (even of the order of gigabytes).
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a8619d23b863cdce388527e1da12fea56f56c891
Author: Adam Kwolek <adam.kwolek at intel.com>
Date: Thu Sep 15 18:38:39 2011 +0200
imsm: FIX: Spare disk has wrong serial after takeover
Takeover marks disk as failed and adds to serial ':0' string and then
turns it in to spare. This causes that when new spare is about to be used,
it cannot be found due to different disk serial number.
Restore disk serial number to avoid this problem.
Signed-off-by: Adam Kwolek <adam.kwolek at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=e5e54ff1d974079f2e0e05f7e0dc2f94b6d6b572
Author: Michal Soltys <soltys at ziu.info>
Date: Thu Sep 8 09:25:08 2011 +0200
udev rules: use $tempnode, check for supported types, comments
Few things adjusted in addition to
0f82fe603a42f37f1e2a6f826b4164811bf2d188:
- keep strict tests for supported types
- when accessing the device, use $tempnode
- few more comments
Signed-off-by: Michal Soltys <soltys at ziu.info>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=16715c01f7ea4410d3b0eb3fe8bd66ab9241f036
Author: Doug Ledford <dledford at redhat.com>
Date: Mon Sep 19 13:06:38 2011 +1000
Fix readding of a readwrite drive into a writemostly array
If you create a two drive raid1 array with one device writemostly, then
fail the readwrite drive, when you add a new device, it will get the
writemostly bit copied out of the remaining device's superblock into
it's own. You can then remove the new drive and readd it as readwrite,
which will work for the readd, but it leaves the stale WriteMostly1 bit
in devflags resulting in the device going back to writemostly on the
next assembly.
The fix is to make sure that A) when we readd a device and we might have
filled the st->sb info from a running device instead of the device being
readded, then clear/set the WriteMostly1 bit in the super1 struct in
addition to setting the disk state (ditto for super0, but slightly
different mechanism) and B) when adding a clean device to an array (when
we most certainly did copy the superblock info from an existing device),
then clear any writemostly bits.
Signed-off-by: Doug Ledford <dledford at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3f555346fb26b7ee7447b004ecb2c2d57f243867
Author: NeilBrown <neilb at suse.de>
Date: Mon Sep 19 11:01:19 2011 +1000
Monitor: --oneshot must imply --no-sharing
Moving spares is not the purpose of '--oneshot' and without
currently --oneshot doesn't work as the check against multiple
spare-sharers prevents it.
So make --oneshot imply --no-sharing. This is sensible and allows
--oneshot to work again.
Reported-by: Jamie Heilman <jamie at audible.transient.net>
Resolves-Debian-Bug: 641886
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=aa4f7f357e286c8129e98c27d79d81ddd45d3f9e
Author: Michael Tokarev <mjt at tls.msk.ru>
Date: Wed Sep 14 20:01:11 2011 +0400
add boot ordering dependency on multipath-tools-boot and remove mention of devfsd
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a502ce96a78d4033ffde755f1f0829ed8d142ac3
Author: martin f. krafft <madduck at debian.org>
Date: Sun Sep 11 12:44:13 2011 +0200
add debian/no-Werror topic branch
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=bb88d27abe7e8909a1f6334934dbb1f740e0941c
Author: martin f. krafft <madduck at debian.org>
Date: Sun Sep 11 11:16:35 2011 +0200
forgot to run debconf-updatepo for new debconf translations
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=a5e5c0df6324f86f45d95af0b7c11119303f6aaa
Author: martin f. krafft <madduck at debian.org>
Date: Sun Sep 11 10:55:45 2011 +0200
update topgit patch queue
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=20a4675688e0384a1b4eac61b05f60fbf7747df9
Author: NeilBrown <neilb at suse.de>
Date: Thu Sep 8 13:08:51 2011 +1000
Grow: refuse to grow a 0.90 array beyond 2TB
A kernel bug makes handling for arrays using more than 2TB per device
incorrect, and the kernel doesn't stop an array from growing beyond
any limit.
This is fixed in 3.1
So prior to 3.1, make sure not to ask for an array to grow bigger than
2TB per device.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=11b391ece9fa284a151362537af093aa44883696
Author: NeilBrown <neilb at suse.de>
Date: Thu Sep 8 13:05:31 2011 +1000
Discourage large devices from being added to 0.90 arrays.
0.90 arrays can only use up to 4TB per device. So when a larger
device is added, complain a bit. Still allow it if --force is given
as there could be a valid use.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=01619b481883926f13da2b1b88f3125359a6a08b
Author: NeilBrown <neilb at suse.de>
Date: Thu Sep 8 12:20:36 2011 +1000
Fix component size checks in validate_super0.
A 0.90 array can use at most 4TB of each device - 2TB between
2.6.39 and 3.1 due to a kernel bug.
The test for this in validate_super0 is very wrong. 'size' is sectors
and the number it is compared against is just confusing.
So fix it all up and correct the spelling of terabytes and remove
a second redundant test on 'size'.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=42de2ac27d632236909f88bd5309161a32379327
Author: Thomas Jarosch <thomas.jarosch at intra2net.com>
Date: Fri Aug 26 07:33:37 2011 +0200
Fix small memory leak
Found by cppcheck
Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b990032d395ec092868dfd15275c969d7c2cab1d
Author: Czarnowska, Anna <anna.czarnowska at intel.com>
Date: Mon Aug 1 15:33:06 2011 +0100
fix: segfault when killing subarray of non-existent container
Negative value must be returned to indicate error in open_subarray
Reviewed-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: Anna Czarnowska <anna.czarnowska at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=0f82fe603a42f37f1e2a6f826b4164811bf2d188
Author: Michal Soltys <soltys at ziu.info>
Date: Wed Sep 7 14:02:29 2011 +1000
shorten remove rules
This implicitly adds ddf containers to 'add' and 'remove' rules.
Signed-off-by: Michal Soltys <soltys at ziu.info>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1913c3256bb657954dd84c3a73c11944a225ec04
Author: NeilBrown <neilb at suse.de>
Date: Wed Sep 7 13:00:32 2011 +1000
start_mdmon: provide more dynamic way to close-all-fds
When forking mdmon we need to close all other fds because we don't
use O_CLOEXEC yet.
Any approach will be fairly arbitrary, but as we can expect fds to be
fairly dense, closing until we find a set number that don't need
closing is possible safer than only closing the first 100.
So keep closing until we find 20 that are already closed.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=75c2df6509391e28257d696815bddb854a8c4a94
Author: NeilBrown <neilb at suse.de>
Date: Wed Sep 7 12:45:24 2011 +1000
FIX: Prevent using null list pointer
When not all attributes are supported (attributes incompatibility)
function container_content_imsm returns NULL pointer.
We need to cope with a NULL list better.
Reported-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ba714450698a966d184f5337235b100cbfa8685e
Author: Lukasz Dorau <lukasz.dorau at intel.com>
Date: Thu Sep 1 15:10:34 2011 +0200
FIX: Mdmon crashes after changing RAID level from 1 to 0
Description of the bug:
Sometimes mdmon crashes after changing RAID level from 1 to 0 (takeover).
Cause of the bug:
The managemon marks an active_array for removal from monitoring
by assigning a->container to NULL value (in the "manage_member" function).
Sometimes (during stress test) it happens right when the monitor
is in the "read_and_act" function and a->container pointer is in use.
This causes the monitor crashes.
Solution:
The active array has to be marked for removal in another way
than setting NULL pointer when it can be in use.
A new field "to_remove" was added to the "active_array" structure.
It is used in the managemon to mark a container to remove
(instead of the old assigment: a->container = NULL)
and monitor checks it to determine if the array should be removed.
The field "to_remove" should be checked in some other places
to avoid managing of the array which is going to be removed.
Signed-off-by: Lukasz Dorau <lukasz.dorau at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3960e579bfe77b3e16a4a6d8546019ff794eb515
Author: Dan Williams <dan.j.williams at intel.com>
Date: Tue Aug 30 13:11:42 2011 +1000
imsm: support 'missing' devices at Create
Specifying missing devices at create is very useful for array recovery.
For imsm create dummy disk entries at init_super_imsm time, and then use
them to fill in unoccupied slots in the final array (if the container is
unpopulated).
If the container is already populated (has a subarray)
'missing' disks must be in reference to already recorded missing devices
in the metadata.
Also add support for --assume-clean for imsm arrays.
Cc: Dave Jiang <dave.jiang at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1d446d52a79b8afcaf604a9a70f906e5605db1f6
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:29 2011 -0700
mdmon: fix, close spare activation race
The following test fails when the md_check_recovery() event triggered by
the ro->rw transition causes remove_and_add_spares() to run while mdmon
is attempting spare activation.
Result is that the kernel races to set the slot immediately after
sysfs_add_disk() writes new_dev. mdmon thinks the spare activation
failed and declines to send the monitor a new acitve_array. We show
degraded after the wait because the monitor cannot notify the metadata
that all disks are in_sync.
#!/bin/bash
i=0
false
while [ $? == 1 ]
do
i=$((i+1))
mdadm -Ss
mdadm -CR /dev/md0 /dev/loop[0-2] -n 3 -e imsm
mdadm -CR /dev/md1 /dev/loop[01] missing -n 3 -l 5
mdadm --wait /dev/md1
mdadm -E /dev/loop2 | grep -i degraded
done
echo "failed: $i"
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=b276dd33c74a51598e37fc72e6fb8f5ebd6620f2
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:24 2011 -0700
imsm: fix reserved sectors for spares
Different OROMs reserve different amounts of space for the migration area.
When activating a spare minimize the reserved space otherwise a valid spare
can be prevented from joining an array with a migration area smaller than
IMSM_RESERVED_SECTORS.
This may result in an array that cannot be reshaped, but that is less
surprising than not being able to rebuild a degraded array.
imsm_reserved_sectors() already reports the minimal value which adds to
the confusion when trying rebuild an array because mdadm -E indicates
that the device has enough space.
Cc: Anna Czarnowska <anna.czarnowska at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=d8924477b7fc513a54249b1b0c617adbfb78c7fe
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:19 2011 -0700
sysfs: fix sysfs_disk_to_scsi_id
Not sure how this ever worked, but now we just try to parse a directory
name that looks like <host>:<bus>:<target>:<lun>.
Array creation segfaults on Fedora 14 without this.
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=0ec1f4e8de3bb7c1b1086d39586123993647fa3f
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:14 2011 -0700
imsm: fix display spares
Commit 94827db3 "imsm: add spares to --examine output." may try to
display failed disks whose imsm_disk info is not uptodate (due to not
being able to look itself up by serial). The same effect can be had by
just loosening the restriction in print_imsm_disk().
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=86c54047e6685a4231e6b1eaff4c08bb84666d3a
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:09 2011 -0700
imsm: fix, stop metadata updates to newly failed devices
We already refrain from updating metadata on disks that are failed at
load, need to do the same for new failures. This also reverts b4add146
as we *do* want to update other disks' view of the failed device as out of
date.
Cc: Krzysztof Wojcik <krzysztof.wojcik at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=660260d027bed08fad2393998e1ca8cb67e1b573
Author: Dan Williams <dan.j.williams at intel.com>
Date: Thu Aug 25 19:14:04 2011 -0700
imsm: fix max disks per array
Validate geometry is incorrectly looking at max disks support which is
irrelevant for md/mdadm. ->dpa (disks per array) is how many disks the
orom will allow per volume.
Also cleanup an unnecessary ->orom check, is_raid_level_supported()
already does the right thing in the !orom case.
Cc: Marcin Labun <marcin.labun at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1b17b4e4ff57a4f7dcbc87c5a03f2d9c87f6cb2f
Author: Bill Allaire <vger at bogoflop.com>
Date: Mon Aug 22 17:24:17 2011 -0400
md.4: two typos fixed
Signed-off-by: Bill Allaire <vger at bogoflop.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=095407fa047df3b5ad4b6217e9714002316eb9f0
Author: Bill Allaire <vger at bogoflop.com>
Date: Sat Aug 20 19:11:03 2011 -0400
md.4: Fixed typo.
Signed-off-by: Bill Allaire <vger at bogoflop.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3b1dab1bdbda0c592ddc83a04c0353b426c79da7
Author: NeilBrown <neilb at suse.de>
Date: Thu Aug 18 15:17:52 2011 +1000
udev rules improvement
Don't try to pass and empty path to "mdadm -If" - it will cause
problems.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=15537e75b1f5b636088a445d664ecaa24d131329
Author: NeilBrown <neilb at suse.de>
Date: Thu Aug 18 12:55:24 2011 +1000
Update COPYING file.
Update to latest from http://www.gnu.org/licenses/gpl-2.0.txt
This corrects the address and some other minor details.
No change in the license.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c48d75d38f6bcc0a340add0ae5b55c73d89c0669
Author: Piergiorgio Sartor <piergiorgio.sartor at nexgo.de>
Date: Tue Aug 9 10:43:58 2011 +1000
RAID-6 check standalone man page
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=418f9b368a1200370695527d22aba8c3606172c5
Author: NeilBrown <neilb at suse.de>
Date: Tue Aug 9 08:49:34 2011 +1000
IMSM: allow some array attribute bits to be ignored.
Some bits are not handled by mdadm, but their presence should not
cause failure.
In particular MPB_ATTRIB_NEVER_USE appears harmless.
Reported-by: Thomas Steinborn <thestonewell at googlemail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=62184891192990bac2521b0d2b276bf2fa3e233d
Author: NeilBrown <neilb at suse.de>
Date: Tue Aug 2 13:36:08 2011 +1000
super1: fix spacing for 'Flags' field in --examine.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9a88e7b6d53859049aee0d118e10546780ca9de9
Author: Scott Schaefer <saschaefer at neurodiverse.org>
Date: Tue Aug 2 13:27:32 2011 +1000
--add incorrectly sets writemostly
Origin: vendor, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628667
Bug-Debian: http://bugs.debian.org/628667
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=4a96d9ff4f03f70d35026e5cf0d1189292d62cfd
Author: NeilBrown <neilb at suse.de>
Date: Mon Aug 1 12:21:19 2011 +1000
Add some more settings of ignore_hw_compat
There are some more times when we don't care that the hardware doesn't
support the metadata:
- when removing old metadata
- when reporting the metadata present before over-writing it.
So set ignore_hw_compat in these cases.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6560987b25a88f78ed53d37525d363c126a07b79
Author: NeilBrown <neilb at suse.de>
Date: Wed Jul 27 17:26:12 2011 +1000
Grow: ensure clean abort if we cannot read the 'completed' file.
If a read of 'completed' returns an error, select will never fail, so
this loop would never exit.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=656b6b5a55adb1fd223d82478c333264af52877a
Author: NeilBrown <neilb at suse.de>
Date: Wed Jul 27 16:11:48 2011 +1000
IMSM: set ->raid_disk correctly in getinfo_super_imsm_volume
The 'raid_disk' can be different to the 'number' and must be
the position of the device in the array, not in the container.
Normally these should not be different, but the test-suite creates a
possibility so it should work.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=9ab6e80a04532e55eb58ea4d320ed1104c8df1d6
Author: NeilBrown <neilb at suse.de>
Date: Wed Jul 27 14:06:13 2011 +1000
mdadm.8.in: clarify some issues with --size
- explain it's use in guarding against small replacements
- clarify relationship with containers.
- include information about --grow --size not being supported by IMSM metadata.
Reported-by: maciej.naruszewicz <maciej.naruszewicz at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=508ede8621a0aa2fd101945b66474cc7ad59c894
Author: Namhyung Kim <namhyung at gmail.com>
Date: Tue Jul 19 13:34:13 2011 +0900
Grow: fix version number in error message
As the conditional checks, reshape to fewer devices is supported
since Linux kernel 2.6.30 not 2.6.32.
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=cd9d1ac71536a2f73b241ccadb8d68c1370025ca
Author: Dan Williams <dan.j.williams at intel.com>
Date: Tue Jul 19 06:52:29 2011 +1000
imsm: fix default chunk in the !orom case
Set a valid default in the !orom case, otherwise we segfault, or
otherwise fail.
Cc: Anna Czarnowska <anna.czarnowska at intel.com>
Signed-off-by: Dan Williams <dan.j.williams at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=ca0748fa494425dc025441a8622088126e25e61d
Author: NeilBrown <neilb at suse.de>
Date: Thu Jul 14 15:42:10 2011 +1000
imsm: getinfo_super_imsm_volume() doesn't fill all disk information
getinfo_super_imsm_volume doesn't correctly set info.disk fields
because it doesn't know which disk to set them from.
It should be the last disk passed to add_to_super.
So add a field 'current_disk' to record this disk in add_to_super, and
use it in getinfo_super.
This allows us to remove a hack in Create.c
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=19986c721c9ac4b353c8592998d70d0dc8860bfd
Author: Milan Broz <mbroz at redhat.com>
Date: Thu Jul 14 13:58:36 2011 +1000
mdadm: fix build failures (ppc64)
This patch fixes these build issues:
super-intel.c: In function 'getinfo_super_imsm_volume':
super-intel.c:2327:4: error: format '%llu' expects argument of type 'long long
unsigned int', but argument 3 has type '__u64' [-Werror=format]
super-intel.c: In function 'imsm_reshape_super':
super-intel.c:8665:7: error: 'devnum' may be used uninitialized in this function [-Werror=uninitialized]
Signed-off-by: Milan Broz <mbroz at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=664d53258de31362475b43658add0ebcf95be168
Author: NeilBrown <neilb at suse.de>
Date: Wed Jul 13 12:38:50 2011 +1000
super-intel: fix buffer overflow in detail-platform.
The serial number is not necessarily nul terminated, so we need to be
sure to only use the allowed number of chars.
Signed-off-by: NeilBrown <neilb at suse.de>
Reported-by: Arvin Schnell <aschnell at novell.com>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=1e49aaa0696e843d5ec0ae6709558e0fe51afc06
Author: Namhyung Kim <namhyung at gmail.com>
Date: Fri Jun 24 13:26:50 2011 +0900
md.4: fix possible typos
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2f48b33d1d7da25cd54edf32edeb0a59a7f75f43
Author: Namhyung Kim <namhyung at gmail.com>
Date: Fri Jun 24 13:26:49 2011 +0900
mdmon.8: fix possible typos
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=2d3603ba0cb497429d2841d2fb4a5e36879e808b
Author: Krzysztof Wojcik <krzysztof.wojcik at intel.com>
Date: Thu Jun 23 12:06:47 2011 +1000
Show DELAYED, PENDING status of resync process in "--detail"
Initially there is no proper translation mdstat's DELAYED/PENDING processes
to "--detail" output.
For example, if we have recover=DELAYED in mdstat, "--detail"
shows "State: recovering" and "Rebuild Status = 0%".
It was incorrect in case of process waiting on checkpoint different
than 0%. In fact rebuild status is differnt than 0% and user is misled.
The patch fix the problem. Current "--detail" command shows
in the exampe: "State: recovering (DELAYED)" and no information
about precentage.
Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik at intel.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c281a8041977cdd4bd7eaed4e1fbead50b5640e6
Author: Andrew Burgess <aab at cichlid.com>
Date: Thu Jun 23 11:48:03 2011 +1000
mdadm --detail was incorrect for shrinking reshapes
Since info->delta_disks is signed it doesn't need to be special-cased.
This allowed my 9->8 reshape to display correctly instead of as 8->7
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=c0672664bffbca34f2c38ad25e4321d70e6845c1
Author: Namhyung Kim <namhyung at gmail.com>
Date: Thu Jun 23 11:40:14 2011 +1000
.gitignore: ignore mdadm.8 file
mdadm.8 is auto-generated from mdadm.8.in, so ignore it.
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=cb77f620767b98e1c508484b2671303d6fa14b55
Author: Namhyung Kim <namhyung at gmail.com>
Date: Thu Jun 23 11:40:10 2011 +1000
mdadm.8: fix possible typos
Fix random typos and add a few of missing words/macros.
Also update RAID website URL as it is not accessible anymore.
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=3c7efacb7d4b9a54f0c1e24a50bb1099612e3e5b
Author: Namhyung Kim <namhyung at gmail.com>
Date: Wed Jun 22 01:19:03 2011 +0900
mdadm.8: move description of --add under Grow mode
It is supposed to be under Grow mode. Since Create/Build/Grow modes
use common options and '-a' is already used for '--auto' in Create/
Build modes, describe it to avoid confusion.
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=6cbf8fb8c164fa141cf3c097b2b8f61f923b0c23
Author: Namhyung Kim <namhyung at gmail.com>
Date: Wed Jun 22 01:19:02 2011 +0900
mdadm.8: change linux version 2.6.40 -> 3.0
Signed-off-by: Namhyung Kim <namhyung at gmail.com>
Signed-off-by: NeilBrown <neilb at suse.de>
URL: http://git.debian.org/?p=pkg-mdadm/mdadm.git/?a=commit;h=f161d047eed634b3380262767f955eb888502e88
Author: NeilBrown <neilb at suse.de>
Date: Fri Jun 17 22:49:24 2011 +1000
util: correctly parse shorter linux version numbers.
The next version of Linux might be 3.0. If it is, get_linux_version
will fail.
So make it more robust.
Reported-by: Namhyung Kim <namhyung at gmail.com>
Reported-by: Milan Broz <mbroz at redhat.com>
Signed-off-by: NeilBrown <neilb at suse.de>
More information about the pkg-mdadm-commits
mailing list