[Pkg-mozext-commits] [SCM] perspectives-extension branch, debian, updated. 4.2-4-136-gd6962eb

[Dave Schaefer]

The following commit has been merged in the debian branch:
commit c3935c2cd72b1411283a800769ae6598d9b8a1eb
Author: Dave Schaefer <dave.schaefer at gmail.com>
Date:   Thu Jun 7 23:10:07 2012 -0700

    Unit tests - Improve test output and documentation
    
    - Add documentation link to actually show the spec not wanting BOM
    - Add explicit output so we know when a file doesn't contain BOM
    - Inform the tester they can use the build system to fix some dtd errors
    - Copyedit instructions for manual test cases and testing Localizations

diff --git a/test/Manual Test Cases.txt b/test/Manual Test Cases.txt
index 951fadb..a3ae955 100644
--- a/test/Manual Test Cases.txt	
+++ b/test/Manual Test Cases.txt	
@@ -20,20 +20,25 @@ UI
 
 
 'Report Attack' tests:
-- HTTP website
-- HTTPS website, before Perspectives has finished querying
-- HTTPS website, after Perspectives has finished querying
-- Invalid URL, such as 'aaa' or blank
-- file:// URL
+  Should NOT let you send a report for:
+    - HTTP website
+    - HTTPS website, before Perspectives has finished querying
+    - Invalid URL, such as 'aaa' or blank
+    - file:// URL
+
+  *Should* let you send a report for:
+    - HTTPS website, after Perspectives has finished querying
+
 
 'Add To Whitelist' tests:
-- Same as above; all but https should be rejected as invalid URLs
+- Try the same page types as above; all non-https pages should be rejected as invalid URLs
 
 
 Preferences:
 - Quorum Percentage must be <= 100
 - Quorum Percentage must be >= 1
 - Quorum Duration must be >= 1
+- Both Quorum Percentage and Duration must be integers
 
 
 
diff --git a/test/Testing Localizations.txt b/test/Testing Localizations.txt
index 8f01fb6..26e08cb 100644
--- a/test/Testing Localizations.txt	
+++ b/test/Testing Localizations.txt	
@@ -2,9 +2,13 @@ To test Localizations:
 
 - In a new tab, open about:config
 - Find the Preference 'general.useragent.locale'
-- Save your current value here:
+- Paste your current value here to save it:
 - Edit the value to the Perspectives localization you wish to test
 - Restart Firefox
+- Run through the tests in 'Manual Test Cases.txt' (and of course, make sure the automated ones in test.html work too)
+
+
+*Important:* Even if you don't speak the language, try to run the translation files through an online translator or other tool and check that the words roughly say what they should. This is not a test to check the grammar or structure but to make sure there are no swears, racial slurs, or other malicious text that would be bad to publish.
 
 
 For a list of localization targets see
diff --git a/test/test.html b/test/test.html
index 9ba490f..0ef39c6 100644
--- a/test/test.html
+++ b/test/test.html
@@ -201,11 +201,15 @@ function get_loc_keys(filelist, locdirname) {
         } while (readmore != 0);
 
         // according to the MDN spec, loc files should *not* contain the BOM
+        // https://developer.mozilla.org/en/XUL_Tutorial/Localization
         var BOM = "";
         if (data.substring(0,3) == BOM) {
           assert(false, "(" + locdirname + "): " + filename + " begins with BOM '" + BOM
             + "'. Loc files should be saved as UTF-8 with no BOM.");
         }
+        else {
+          assert(true, "(" + locdirname + "): " + filename + " does not contain BOM.");
+        }
 
         fstream.close();
 
@@ -278,7 +282,8 @@ function get_keys_from_stream(datastream, comment, delimiter, itemregex, keys, s
       var space = /^\s*$/;
       var justspace = space.exec(lines[i]);
       if (!justspace) {
-       assert(false, "(" + locdirname + "): Malformed entry '" + lines[i] + "' in " + sourcefilename);
+       assert(false, "(" + locdirname + "): Malformed entry '" + lines[i] + "' in " + sourcefilename
+        + ". You can try running 'make' or the perl script to fix this.");
       }
     }
   }

-- 
perspectives-extension