[Pkg-mozext-commits] [firebug] 47/82: Don't do anything risky to "with" scopes

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit 9b175bbb3996e59ee5102bbd6cf4c2100b888d6a
Author: Simon Lindholm <simon.lindholm10 at gmail.com>
Date:   Wed Jan 2 22:09:27 2013 +0100

    Don't do anything risky to "with" scopes
---
 extension/content/firebug/console/closureInspector.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/extension/content/firebug/console/closureInspector.js b/extension/content/firebug/console/closureInspector.js
index 8e2e7d7..a03472b 100644
--- a/extension/content/firebug/console/closureInspector.js
+++ b/extension/content/firebug/console/closureInspector.js
@@ -65,6 +65,12 @@ var ClosureInspector =
             if (ret !== undefined)
                 return ret;
 
+            // With scopes are based on real objects - don't try anything fancy.
+            // (Object properties probably don't get optimized away anyway, and
+            // "with" tends to inhibit optimizations).
+            if (scope.type === "with")
+                return undefined;
+
             // The variable is either optimized away or actually set to undefined.
             // Optimized-away ones are apparantly not settable, so try to detect
             // them by that (it seems rather safe).

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git